summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorReto Brunner <reto@labrat.space>2019-07-28 15:02:09 +0200
committerDrew DeVault <sir@cmpwn.com>2019-07-29 14:51:16 -0400
commitb812257ba97020e90e7598378b54f737364a1636 (patch)
treeef43964c6200d2a584114b56aa29f5674bc6c682
parentc81b3eb1cb8f25fb563b7d9ea99814e9ba21c737 (diff)
downloadaerc-b812257ba97020e90e7598378b54f737364a1636.tar.gz
Print errors from config load issues.
Currently we /dev/null stdout, if it is a tty.
The checkConfigPerms function, as well as the error print were incorrectly
writing to stdout and therefore weren't visible to most users.
-rw-r--r--aerc.go2
-rw-r--r--config/config.go6
2 files changed, 4 insertions, 4 deletions
diff --git a/aerc.go b/aerc.go
index 033de7b..cfd192a 100644
--- a/aerc.go
+++ b/aerc.go
@@ -135,7 +135,7 @@ func main() {
 
 	conf, err := config.LoadConfigFromFile(nil, ShareDir)
 	if err != nil {
-		fmt.Printf("Failed to load config: %v\n", err)
+		fmt.Fprintf(os.Stderr, "Failed to load config: %v\n", err)
 		os.Exit(1)
 	}
 
diff --git a/config/config.go b/config/config.go
index 356d562..8ba705c 100644
--- a/config/config.go
+++ b/config/config.go
@@ -465,9 +465,9 @@ func checkConfigPerms(filename string) error {
 	goPerms := perms >> 3
 	// group or others have read access
 	if goPerms&0x44 != 0 {
-		fmt.Printf("The file %v has too open permissions.\n", filename)
-		fmt.Println("This is a security issue (it contains passwords).")
-		fmt.Printf("To fix it, run `chmod 600 %v`\n", filename)
+		fmt.Fprintf(os.Stderr, "The file %v has too open permissions.\n", filename)
+		fmt.Fprintln(os.Stderr, "This is a security issue (it contains passwords).")
+		fmt.Fprintf(os.Stderr, "To fix it, run `chmod 600 %v`\n", filename)
 		return errors.New("account.conf permissions too lax")
 	}
 	return nil