| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Fix crash when no message is selected | Wiktor Kwapisiewicz | 2019-12-04 | 1 | -1/+4 |
| | | | | | | | | | | | | Pressing `Enter` on a view that has not yet loaded messages (e.g. at startup) would return `nil` from `Selected()`. Accessing `msg.Uid` on a `nil` reference crashes aerc. This patch moves the `msg == nil` check before accessing `msg.Uid` thus avoiding the crash. To test this patch repeatedly press `Enter` on startup. | ||||
| * | commands/account: Disable :view for deleted msgs | Kevin Kuehler | 2019-11-17 | 1 | -1/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | Allowing the user to view deleted messages creates all sorts of race conditions. The most devious race condition is pv.source can be set to a nil while another PartViewer is still running a goroutine in attemptCopy. Here is a trace when this happens. goroutine 76 [running]: io.copyBuffer(0x7f8ad02641d0, 0xc00040f590, 0x0, 0x0, 0xc0007cc000, 0x8000, 0x8000, 0x0, 0x0, 0x8b3d60) /usr/lib/go/src/io/io.go:402 +0x101 io.Copy(...) /usr/lib/go/src/io/io.go:364 git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy.func4(0xc00017efd0, 0xc0004da7c0) /home/keur/repos/aerc/widgets/msgviewer.go:576 +0x611 created by git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy /home/keur/repos/aerc/widgets/msgviewer.go:544 +0x144 We could add a guard in store.FetchBodyPart to only call the callback when msg.Part.Reader != nil, but we still get a hanging pager. Therefore it seems more reasonable to disable this completely. Signed-off-by: Kevin Kuehler <keur@xcf.berkeley.edu> | ||||
| * | all: purge redundant underscores | Wagner Riffel | 2019-09-04 | 1 | -3/+3 |
| | | | | | Signed-off-by: Wagner Riffel <wgrriffel@gmail.com> | ||||
| * | Implement basic tab completion support | Gregory Mullen | 2019-06-29 | 1 | -3/+12 |
| | | | | | | Tab completion currently only works on commands. Contextual completion will be added in the future. | ||||
| * | widget: Add ProvidesMessage interface | Kevin Kuehler | 2019-06-02 | 1 | -1/+1 |
| | | | | | | | | | | | | Consists of 3 functions * Store: Access to MessageStore type * SelectedAccount: Access to Account widget that the target widget belongs to * SelectedMessage: Current message (selected in msglist or the one we are viewing) Signed-off-by: Kevin Kuehler <keur@ocf.berkeley.edu> | ||||
| * | Rename :delete-message et al to :delete et al | Drew DeVault | 2019-05-19 | 1 | -0/+30 |