about summary refs log tree commit diff stats
path: root/widgets/account.go
Commit message (Collapse)AuthorAgeFilesLines
* Update internal state and draw from the same goroutineSimon Ser2019-05-191-7/+11
| | | | | | | | | | | | | | | | | | | | | | | | | This commit introduces a new Aerc.Tick function that should be called to refresh the internal state. This in turn makes each AccountView process worker events. The UI goroutine repeatedly refreshes the internal state before drawing a new frame. The reason for this is that many worker messages may need to be processed for a single frame, and drawing the UI is far slower than refreshing the internal state. This has been confirmed in my testing (calling Aerc.Tick only once per frame results in a slower display). Many synchronization code has been removed. We can now write widgets without having to care so much about races. The remaining sync users are: - widgets/spinner: the spinner value is updated from inside an internal goroutine - lib/ui/invalidatable: Invalidate may be called from any goroutine - lib/ui/grid: same - lib/ui/ui: an internal goroutine needs read access to UI.exit - worker/types/worker: Worker.callbacks is used for both worker and UI callbacks The exact goroutine requirements for Drawable have been documented.
* s/aerc2/aerc/gDrew DeVault2019-05-171-5/+5
|
* Remove unimplemented color configurationDrew DeVault2019-05-171-1/+1
| | | | Will probably end up doing this differently anyway
* Implement (basic form) of :replyDrew DeVault2019-05-161-4/+8
|
* Implement :copy (aka :cp)Drew DeVault2019-05-141-0/+4
|
* Handle incoming emails gracefullyDrew DeVault2019-05-131-6/+6
|
* Populate "From" header from config for new emailsDrew DeVault2019-05-131-0/+4
|
* lib/ui: introduce InvalidatableSimon Ser2019-04-271-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many Drawable implementations have their own Invalidate and OnInvalidate functions, with an unexported onInvalidate field. However OnInvalidate and Invalidate are usually not called in the same goroutine. This results in a race on this field, e.g.: Read at 0x00c000094748 by goroutine 7: git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList.func1() /home/simon/src/aerc2/widgets/dirlist.go:85 +0x56 git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start.func1() /home/simon/src/aerc2/widgets/spinner.go:93 +0x1bb Previous write at 0x00c000094748 by main goroutine: [failed to restore the stack] Goroutine 7 (running) created at: git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start() /home/simon/src/aerc2/widgets/spinner.go:46 +0x8f git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList() /home/simon/src/aerc2/widgets/dirlist.go:37 +0x286 git.sr.ht/~sircmpwn/aerc2/widgets.NewAccountView() /home/simon/src/aerc2/widgets/account.go:50 +0x5ca git.sr.ht/~sircmpwn/aerc2/widgets.NewAerc() /home/simon/src/aerc2/widgets/aerc.go:60 +0x800 main.main() /home/simon/src/aerc2/aerc.go:65 +0x33e To fix this, introduce a new type, Invalidatable, which protects the field. Unfortunately the Drawable must be passed to the callback function in Invalidate, so we still need to re-implement this in each Invalidatable user.
* Make message viewer real, part twoDrew DeVault2019-03-311-1/+1
|
* Correct color of error messagesDrew DeVault2019-03-301-1/+1
|
* Add body fetching support codeDrew DeVault2019-03-291-0/+3
|
* Implement :delete-messageDrew DeVault2019-03-201-0/+3
|
* Move exline handling up to aerc, add :termDrew DeVault2019-03-171-97/+23
|
* Add basic terminal widgetDrew DeVault2019-03-171-6/+21
|
* Move MessageStore into its own fileDrew DeVault2019-03-151-3/+4
|
* Implement default in accounts.confDrew DeVault2019-03-151-1/+1
|
* Implement sidebar-width config optionDrew DeVault2019-03-151-1/+1
|
* Rig up key bindingsDrew DeVault2019-03-151-27/+53
|
* Implement :{next,prev}-messageDrew DeVault2019-03-141-0/+4
|
* Use cached message store when re-opening dirsDrew DeVault2019-03-141-1/+9
|
* Implement :cd commandDrew DeVault2019-03-141-0/+5
|
* Implement message store side of message fetchingDrew DeVault2019-03-141-2/+2
|
* Lay out message list widget basic designDrew DeVault2019-03-141-4/+7
|
* Fetch valid UIDs from server after opening dirDrew DeVault2019-03-101-6/+29
|
* Improve error reportingDrew DeVault2019-03-101-3/+2
|
* Flesh out command parsing & handlingDrew DeVault2019-03-101-1/+1
|
* Start building out command subsystemDrew DeVault2019-03-101-1/+9
|
* Fix buildElias Naur2019-02-101-1/+1
|
* Implement Container interface in widgets/Drew DeVault2019-01-201-0/+4
|
* Send commands up to the top-level aerc widgetDrew DeVault2019-01-141-4/+10
|
* Handle errors from worker initializationDrew DeVault2019-01-131-1/+1
|
* Swap message list placeholder for spinnerDrew DeVault2019-01-131-1/+3
|
* Handle connection errors properlyDrew DeVault2019-01-131-3/+4
|
* Simplify approach to directory listDrew DeVault2019-01-131-5/+17
| | | | This doesn't really need to be abstract tbh
* Filter dirlist according to user configDrew DeVault2019-01-131-1/+1
|
* Add directory list widgetDrew DeVault2019-01-131-23/+26
|
* Move ex line into accountDrew DeVault2019-01-131-26/+49
|
* Move status line into account, update behaviorDrew DeVault2019-01-131-9/+35
|
* Initialize worker in account widgetDrew DeVault2019-01-131-2/+50
|
* Add basic account widget, populate real acct viewsDrew DeVault2019-01-131-0/+41
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-11-15 19:58:31 +0000