| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | lib/ui: introduce Invalidatable | Simon Ser | 2019-04-27 | 1 | -15/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many Drawable implementations have their own Invalidate and OnInvalidate functions, with an unexported onInvalidate field. However OnInvalidate and Invalidate are usually not called in the same goroutine. This results in a race on this field, e.g.: Read at 0x00c000094748 by goroutine 7: git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList.func1() /home/simon/src/aerc2/widgets/dirlist.go:85 +0x56 git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start.func1() /home/simon/src/aerc2/widgets/spinner.go:93 +0x1bb Previous write at 0x00c000094748 by main goroutine: [failed to restore the stack] Goroutine 7 (running) created at: git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start() /home/simon/src/aerc2/widgets/spinner.go:46 +0x8f git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList() /home/simon/src/aerc2/widgets/dirlist.go:37 +0x286 git.sr.ht/~sircmpwn/aerc2/widgets.NewAccountView() /home/simon/src/aerc2/widgets/account.go:50 +0x5ca git.sr.ht/~sircmpwn/aerc2/widgets.NewAerc() /home/simon/src/aerc2/widgets/aerc.go:60 +0x800 main.main() /home/simon/src/aerc2/aerc.go:65 +0x33e To fix this, introduce a new type, Invalidatable, which protects the field. Unfortunately the Drawable must be passed to the callback function in Invalidate, so we still need to re-implement this in each Invalidatable user. | ||||
| * | Fix segfault on :view-message for unloaded message | Tom Lebreux | 2019-04-10 | 1 | -0/+4 |
| | | | | | | | This also fixes segfault on :view-message on empty directory Signed-off-by: Tom Lebreux <tomlebreux@cock.li> | ||||
| * | Fix infinite loop on empty DirectoryContents | Tom Lebreux | 2019-04-05 | 1 | -2/+4 |
| | | | | | | | | | | When changing to an empty directory, ml.selected is 0, and the length of ml.store.Uids is 0. The loop condition is always true so we have an infinite loop causing 100% CPU usage and prevents us to change to other directories. Signed-off-by: Tom Lebreux <tomlebreux@cock.li> | ||||
| * | Show (no messages) for empty folders | Drew DeVault | 2019-04-04 | 1 | -0/+6 |
| | | |||||
| * | Use tcell.Style.Reverse instead of black on white | Drew DeVault | 2019-03-30 | 1 | -2/+1 |
| | | |||||
| * | Show deleted emails pending server ack in grey | Drew DeVault | 2019-03-30 | 1 | -0/+3 |
| | | | | | TODO: Don't let the user select or interact with deleted messages | ||||
| * | Add body fetching support code | Drew DeVault | 2019-03-29 | 1 | -1/+1 |
| | | |||||
| * | Improve cursor handling in embedded terminal | Drew DeVault | 2019-03-21 | 1 | -0/+3 |
| | | |||||
| * | Implement :delete-message | Drew DeVault | 2019-03-20 | 1 | -0/+20 |
| | | |||||
| * | Fix scrolling issues on :select-message | Drew DeVault | 2019-03-17 | 1 | -0/+7 |
| | | |||||
| * | Implement :select-message | Drew DeVault | 2019-03-15 | 1 | -0/+9 |
| | | |||||
| * | Implement scrolling in message list | Drew DeVault | 2019-03-15 | 1 | -3/+14 |
| | | |||||
| * | Implement :next-message n% | Drew DeVault | 2019-03-15 | 1 | -0/+6 |
| | | |||||
| * | Move MessageStore into its own file | Drew DeVault | 2019-03-15 | 1 | -83/+3 |
| | | |||||
| * | Rig up key bindings | Drew DeVault | 2019-03-15 | 1 | -2/+2 |
| | | |||||
| * | Implement :{next,prev}-message | Drew DeVault | 2019-03-14 | 1 | -0/+20 |
| | | |||||
| * | Invalidate when UIDs finish downloading | Drew DeVault | 2019-03-14 | 1 | -4/+0 |
| | | |||||
| * | Display message subjects in message list | Drew DeVault | 2019-03-14 | 1 | -3/+22 |
| | | |||||
| * | Implement message store side of message fetching | Drew DeVault | 2019-03-14 | 1 | -10/+52 |
| | | |||||
| * | Lay out message list widget basic design | Drew DeVault | 2019-03-14 | 1 | -0/+89 |
| | | |||||
| * | Fetch valid UIDs from server after opening dir | Drew DeVault | 2019-03-10 | 1 | -0/+36 |