| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | lib/ui: introduce Invalidatable | Simon Ser | 2019-04-27 | 1 | -21/+15 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many Drawable implementations have their own Invalidate and OnInvalidate functions, with an unexported onInvalidate field. However OnInvalidate and Invalidate are usually not called in the same goroutine. This results in a race on this field, e.g.: Read at 0x00c000094748 by goroutine 7: git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList.func1() /home/simon/src/aerc2/widgets/dirlist.go:85 +0x56 git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start.func1() /home/simon/src/aerc2/widgets/spinner.go:93 +0x1bb Previous write at 0x00c000094748 by main goroutine: [failed to restore the stack] Goroutine 7 (running) created at: git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start() /home/simon/src/aerc2/widgets/spinner.go:46 +0x8f git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList() /home/simon/src/aerc2/widgets/dirlist.go:37 +0x286 git.sr.ht/~sircmpwn/aerc2/widgets.NewAccountView() /home/simon/src/aerc2/widgets/account.go:50 +0x5ca git.sr.ht/~sircmpwn/aerc2/widgets.NewAerc() /home/simon/src/aerc2/widgets/aerc.go:60 +0x800 main.main() /home/simon/src/aerc2/aerc.go:65 +0x33e To fix this, introduce a new type, Invalidatable, which protects the field. Unfortunately the Drawable must be passed to the callback function in Invalidate, so we still need to re-implement this in each Invalidatable user. | ||||
| * | Re-render terminal on invalidate | Drew DeVault | 2019-04-15 | 1 | -4/+13 |
| | | |||||
| * | Clear damage on each terminal.Draw call | Drew DeVault | 2019-04-05 | 1 | -0/+2 |
| | | |||||
| * | Fix wrong row due to typo | Tom Lebreux | 2019-04-05 | 1 | -1/+1 |
| | | | | | Signed-off-by: Tom Lebreux <tomlebreux@cock.li> | ||||
| * | Fix crash on command not found | Drew DeVault | 2019-03-30 | 1 | -37/+42 |
| | | |||||
| * | Implement :pipe | Drew DeVault | 2019-03-30 | 1 | -6/+14 |
| | | |||||
| * | Expire status errors on input | Drew DeVault | 2019-03-21 | 1 | -6/+8 |
| | | |||||
| * | term: don't mess with cursor when unfocused | Drew DeVault | 2019-03-21 | 1 | -6/+15 |
| | | |||||
| * | Enable alt screen on built-in terminal | Drew DeVault | 2019-03-21 | 1 | -0/+1 |
| | | |||||
| * | Make terminal closure thread safe | Drew DeVault | 2019-03-21 | 1 | -1/+9 |
| | | |||||
| * | Use GetCursorPos instead of stored position | Drew DeVault | 2019-03-21 | 1 | -1/+4 |
| | | |||||
| * | Skip writes if term is closed | Drew DeVault | 2019-03-21 | 1 | -1/+1 |
| | | |||||
| * | Improve cursor handling in embedded terminal | Drew DeVault | 2019-03-21 | 1 | -8/+19 |
| | | |||||
| * | Fix cursor handling in embedded terminal | Drew DeVault | 2019-03-21 | 1 | -14/+8 |
| | | |||||
| * | Forward key events to child terminal | Drew DeVault | 2019-03-21 | 1 | -1/+135 |
| | | |||||
| * | moar colors | Drew DeVault | 2019-03-17 | 1 | -4/+10 |
| | | |||||
| * | s/:term-close/:close/g | Drew DeVault | 2019-03-17 | 1 | -1/+0 |
| | | |||||
| * | Wrap Terminal in TermHost | Drew DeVault | 2019-03-17 | 1 | -1/+1 |
| | | |||||
| * | Add :term-close | Drew DeVault | 2019-03-17 | 1 | -12/+30 |
| | | |||||
| * | Handle terminal title, login shell | Drew DeVault | 2019-03-17 | 1 | -0/+13 |
| | | |||||
| * | Fix terminal colors; wait until tty size is known | Drew DeVault | 2019-03-17 | 1 | -21/+75 |
| | | |||||
| * | Add basic terminal widget | Drew DeVault | 2019-03-17 | 1 | -0/+179 |