summary refs log tree commit diff stats
path: root/widgets
Commit message (Collapse)AuthorAgeFilesLines
* lib/msgstore: protect with a mutexSimon Ser2019-04-291-0/+18
| | | | | | MessageStore has a lot of exported fields that can be read from the outside. Each read must be protected, because a call from Update could happen at any time.
* widgets/msglist: fix MessageList.store raceSimon Ser2019-04-291-23/+32
| | | | | This field could be written to in the middle of a Draw call, which reads it multiple times. Use an atomic variable instead.
* lib/ui: introduce InvalidatableSimon Ser2019-04-278-95/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many Drawable implementations have their own Invalidate and OnInvalidate functions, with an unexported onInvalidate field. However OnInvalidate and Invalidate are usually not called in the same goroutine. This results in a race on this field, e.g.: Read at 0x00c000094748 by goroutine 7: git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList.func1() /home/simon/src/aerc2/widgets/dirlist.go:85 +0x56 git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start.func1() /home/simon/src/aerc2/widgets/spinner.go:93 +0x1bb Previous write at 0x00c000094748 by main goroutine: [failed to restore the stack] Goroutine 7 (running) created at: git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start() /home/simon/src/aerc2/widgets/spinner.go:46 +0x8f git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList() /home/simon/src/aerc2/widgets/dirlist.go:37 +0x286 git.sr.ht/~sircmpwn/aerc2/widgets.NewAccountView() /home/simon/src/aerc2/widgets/account.go:50 +0x5ca git.sr.ht/~sircmpwn/aerc2/widgets.NewAerc() /home/simon/src/aerc2/widgets/aerc.go:60 +0x800 main.main() /home/simon/src/aerc2/aerc.go:65 +0x33e To fix this, introduce a new type, Invalidatable, which protects the field. Unfortunately the Drawable must be passed to the callback function in Invalidate, so we still need to re-implement this in each Invalidatable user.
* widgets/spinner: fix Spinner.frame raceSimon Ser2019-04-271-12/+15
| | | | | | | | | | | | | | | | | | | | | | | | It's accessed by the goroutine which increments it and the goroutine that draws the widget at the same time. Use atomic instead. Write at 0x00c00000ebc0 by goroutine 7: git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start.func1() /home/simon/src/aerc2/widgets/spinner.go:50 +0x169 Previous read at 0x00c00000ebc0 by main goroutine: [failed to restore the stack] Goroutine 7 (running) created at: git.sr.ht/~sircmpwn/aerc2/widgets.(*Spinner).Start() /home/simon/src/aerc2/widgets/spinner.go:44 +0x8b git.sr.ht/~sircmpwn/aerc2/widgets.NewDirectoryList() /home/simon/src/aerc2/widgets/dirlist.go:37 +0x286 git.sr.ht/~sircmpwn/aerc2/widgets.NewAccountView() /home/simon/src/aerc2/widgets/account.go:50 +0x5ca git.sr.ht/~sircmpwn/aerc2/widgets.NewAerc() /home/simon/src/aerc2/widgets/aerc.go:60 +0x800 main.main() /home/simon/src/aerc2/aerc.go:65 +0x33e
* Re-render terminal on invalidateDrew DeVault2019-04-151-4/+13
|
* Fix segfault on :view-message for unloaded messageTom Lebreux2019-04-101-0/+4
| | | | | | This also fixes segfault on :view-message on empty directory Signed-off-by: Tom Lebreux <tomlebreux@cock.li>
* Lowercase MIME types while matching filtersGokberk Yaltirakli2019-04-071-1/+2
|
* Clear damage on each terminal.Draw callDrew DeVault2019-04-051-0/+2
|
* Fix wrong row due to typoTom Lebreux2019-04-051-1/+1
| | | | Signed-off-by: Tom Lebreux <tomlebreux@cock.li>
* Fix infinite loop on empty DirectoryContentsTom Lebreux2019-04-051-2/+4
| | | | | | | | | When changing to an empty directory, ml.selected is 0, and the length of ml.store.Uids is 0. The loop condition is always true so we have an infinite loop causing 100% CPU usage and prevents us to change to other directories. Signed-off-by: Tom Lebreux <tomlebreux@cock.li>
* Show (no messages) for empty foldersDrew DeVault2019-04-041-0/+6
|
* Remove extra debug statementDrew DeVault2019-03-311-1/+0
|
* Use shell to execute filters, fix non-determinismDrew DeVault2019-03-311-6/+3
|
* Implement header-regex-match filtersDrew DeVault2019-03-311-1/+18
|
* Improve error handling in message viewerDrew DeVault2019-03-311-10/+36
| | | | Still not great but at least it tells you when something went wrong
* Add basic filter implementationDrew DeVault2019-03-311-16/+65
|
* Decode messages before rendering themDrew DeVault2019-03-311-2/+22
|
* Make message viewer real, part twoDrew DeVault2019-03-312-11/+23
|
* Make the message viewer real, part oneDrew DeVault2019-03-312-120/+54
|
* Add message view commands, :closeDrew DeVault2019-03-301-0/+2
|
* Minor refactoring to header viewDrew DeVault2019-03-301-7/+12
|
* Fix crash on command not foundDrew DeVault2019-03-301-37/+42
|
* Use bold instead of inverted for header namesDrew DeVault2019-03-301-2/+3
|
* Add multipart selector mockup to msgviewerDrew DeVault2019-03-301-7/+50
|
* Add basic message viewer mockupDrew DeVault2019-03-303-64/+213
|
* Correct color of error messagesDrew DeVault2019-03-302-2/+2
|
* Use tcell.Style.Reverse instead of black on whiteDrew DeVault2019-03-304-12/+11
|
* Implement :pipeDrew DeVault2019-03-301-6/+14
|
* Show deleted emails pending server ack in greyDrew DeVault2019-03-301-0/+3
| | | | TODO: Don't let the user select or interact with deleted messages
* Add body fetching support codeDrew DeVault2019-03-292-1/+4
|
* Expire status errors on inputDrew DeVault2019-03-213-6/+21
|
* term: don't mess with cursor when unfocusedDrew DeVault2019-03-211-6/+15
|
* Enable alt screen on built-in terminalDrew DeVault2019-03-211-0/+1
|
* Make terminal closure thread safeDrew DeVault2019-03-211-1/+9
|
* Use GetCursorPos instead of stored positionDrew DeVault2019-03-211-1/+4
|
* Skip writes if term is closedDrew DeVault2019-03-211-1/+1
|
* Improve cursor handling in embedded terminalDrew DeVault2019-03-212-8/+22
|
* Fix cursor handling in embedded terminalDrew DeVault2019-03-211-14/+8
|
* Forward key events to child terminalDrew DeVault2019-03-211-1/+135
|
* Use : for keybindings even when ex is overriddenDrew DeVault2019-03-211-3/+9
|
* Rig up terminal keybinding groupDrew DeVault2019-03-211-0/+2
|
* Use user's configured ex keyDrew DeVault2019-03-211-1/+3
|
* Add context-specific keybindingsDrew DeVault2019-03-211-8/+38
|
* Implement :delete-messageDrew DeVault2019-03-202-0/+23
|
* moar colorsDrew DeVault2019-03-171-4/+10
|
* Fix scrolling issues on :select-messageDrew DeVault2019-03-171-0/+7
|
* s/:term-close/:close/gDrew DeVault2019-03-171-1/+0
|
* Wrap Terminal in TermHostDrew DeVault2019-03-173-1/+58
|
* Add :term-closeDrew DeVault2019-03-172-12/+38
|
* Handle terminal title, login shellDrew DeVault2019-03-172-1/+13
|
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-12-01 02:41:00 +0000