summary refs log tree commit diff stats
path: root/widgets
Commit message (Collapse)AuthorAgeFilesLines
* Update terminal color handling per vterm changesDrew DeVault2019-05-261-43/+22
|
* Update to the latest go-libvtermDrew DeVault2019-05-261-1/+1
|
* Implement :edit in compose screenDrew DeVault2019-05-261-27/+51
|
* msgviewer: copy stderr into pagerDrew DeVault2019-05-261-1/+17
| | | | This prevents a broken filter config from being a silent error
* Fix special characters in address.PersonalNameDrew DeVault2019-05-251-6/+9
|
* Show account wizard if no accounts configuredDrew DeVault2019-05-222-5/+8
|
* Implement opening tutorial after account wizardDrew DeVault2019-05-221-1/+21
|
* Write new accounts to config and open tabDrew DeVault2019-05-221-7/+139
|
* Fix always showing last account tabDrew DeVault2019-05-221-2/+2
|
* Remove excess padding from incoming config pageDrew DeVault2019-05-211-1/+1
|
* New account wizard, part oneDrew DeVault2019-05-212-0/+627
|
* Load IMAP worker for imap+insecureDrew DeVault2019-05-201-1/+5
|
* Show unsupported mimetype message in redDrew DeVault2019-05-201-1/+1
|
* Show attachment names in multipart viewDrew DeVault2019-05-201-1/+5
|
* Implement :next-part, :prev-partDrew DeVault2019-05-201-2/+31
|
* Flesh out multipart switcherDrew DeVault2019-05-201-65/+141
|
* Refactor message part into dedicated widgetDrew DeVault2019-05-201-86/+148
|
* Verify TLS certificatesDrew DeVault2019-05-201-7/+1
| | | | | | I was partway done implementing a UI for users to approve untrusted certs with, but let's just make them configure their servers right instead.
* Advance cursor after :delete and :moveDrew DeVault2019-05-191-4/+5
| | | | So that you can repeat the action on the next message if appropriate
* Reset message list cursor when switching storesDrew DeVault2019-05-191-1/+1
|
* Advance message list cursor when messages arriveDrew DeVault2019-05-191-0/+13
|
* Update internal state and draw from the same goroutineSimon Ser2019-05-193-28/+22
| | | | | | | | | | | | | | | | | | | | | | | | | This commit introduces a new Aerc.Tick function that should be called to refresh the internal state. This in turn makes each AccountView process worker events. The UI goroutine repeatedly refreshes the internal state before drawing a new frame. The reason for this is that many worker messages may need to be processed for a single frame, and drawing the UI is far slower than refreshing the internal state. This has been confirmed in my testing (calling Aerc.Tick only once per frame results in a slower display). Many synchronization code has been removed. We can now write widgets without having to care so much about races. The remaining sync users are: - widgets/spinner: the spinner value is updated from inside an internal goroutine - lib/ui/invalidatable: Invalidate may be called from any goroutine - lib/ui/grid: same - lib/ui/ui: an internal goroutine needs read access to UI.exit - worker/types/worker: Worker.callbacks is used for both worker and UI callbacks The exact goroutine requirements for Drawable have been documented.
* widgets/terminal: fix damage race conditionSimon Ser2019-05-191-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Terminal.damage is accessed when drawing and when invalidating the widget. For this reason we need to protect it with a mutex. This seems to fix various damage issues I've been experiencing (where some regions of the terminal weren't correctly repainted). Race detector trace: Read at 0x00c0000c6670 by main goroutine: git.sr.ht/~sircmpwn/aerc/widgets.(*Terminal).Draw() /home/simon/src/aerc/widgets/terminal.go:292 +0x191 git.sr.ht/~sircmpwn/aerc/lib/ui.(*Grid).Draw() /home/simon/src/aerc/lib/ui/grid.go:117 +0x575 git.sr.ht/~sircmpwn/aerc/lib/ui.(*Grid).Draw() /home/simon/src/aerc/lib/ui/grid.go:117 +0x575 git.sr.ht/~sircmpwn/aerc/widgets.(*MessageViewer).Draw() /home/simon/src/aerc/widgets/msgviewer.go:231 +0x253 git.sr.ht/~sircmpwn/aerc/lib/ui.(*TabContent).Draw() /home/simon/src/aerc/lib/ui/tab.go:124 +0x12e git.sr.ht/~sircmpwn/aerc/lib/ui.(*Grid).Draw() /home/simon/src/aerc/lib/ui/grid.go:117 +0x575 git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).Draw() /home/simon/src/aerc/widgets/aerc.go:95 +0x5a git.sr.ht/~sircmpwn/aerc/lib/ui.(*UI).Tick() /home/simon/src/aerc/lib/ui/ui.go:93 +0x1dd main.main() /home/simon/src/aerc/aerc.go:105 +0x539 Previous write at 0x00c0000c6670 by goroutine 37: git.sr.ht/~sircmpwn/aerc/widgets.(*Terminal).onDamage-fm() /home/simon/src/aerc/widgets/terminal.go:429 +0x131 git.sr.ht/~sircmpwn/go-libvterm._go_handle_damage() /home/simon/go/pkg/mod/git.sr.ht/~sircmpwn/go-libvterm@v0.0.0-20190421201021-3184f6f13687/vterm.go:481 +0xf9 git.sr.ht/~sircmpwn/go-libvterm._cgoexpwrap_5e22200b58b7__go_handle_damage() _cgo_gotypes.go:731 +0x58 runtime.call32() /usr/lib/go/src/runtime/asm_amd64.s:519 +0x3a git.sr.ht/~sircmpwn/go-libvterm.(*VTerm).Write.func1() /home/simon/go/pkg/mod/git.sr.ht/~sircmpwn/go-libvterm@v0.0.0-20190421201021-3184f6f13687/vterm.go:329 +0x9d git.sr.ht/~sircmpwn/go-libvterm.(*VTerm).Write() /home/simon/go/pkg/mod/git.sr.ht/~sircmpwn/go-libvterm@v0.0.0-20190421201021-3184f6f13687/vterm.go:329 +0x7f git.sr.ht/~sircmpwn/aerc/widgets.NewTerminal.func1() /home/simon/src/aerc/widgets/terminal.go:131 +0x18c Goroutine 37 (running) created at: git.sr.ht/~sircmpwn/aerc/widgets.NewTerminal() /home/simon/src/aerc/widgets/terminal.go:121 +0x23f git.sr.ht/~sircmpwn/aerc/widgets.NewMessageViewer() /home/simon/src/aerc/widgets/msgviewer.go:147 +0xfbe git.sr.ht/~sircmpwn/aerc/commands/account.ViewMessage() /home/simon/src/aerc/commands/account/view-message.go:26 +0x4a4 git.sr.ht/~sircmpwn/aerc/commands.(*Commands).ExecuteCommand() /home/simon/src/aerc/commands/commands.go:47 +0x1f0 main.main.func1() /home/simon/src/aerc/aerc.go:76 +0x205 git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).BeginExCommand.func1() /home/simon/src/aerc/widgets/aerc.go:262 +0x89 git.sr.ht/~sircmpwn/aerc/widgets.(*ExLine).Event() /home/simon/src/aerc/widgets/exline.go:47 +0x222 git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).Event() /home/simon/src/aerc/widgets/aerc.go:133 +0x83c git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).simulate() /home/simon/src/aerc/widgets/aerc.go:126 +0x12a git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).Event() /home/simon/src/aerc/widgets/aerc.go:148 +0x766 git.sr.ht/~sircmpwn/aerc/lib/ui.(*UI).Tick() /home/simon/src/aerc/lib/ui/ui.go:86 +0x11b main.main() /home/simon/src/aerc/aerc.go:105 +0x539
* s/aerc2/aerc/gDrew DeVault2019-05-1710-27/+27
|
* Remove unimplemented color configurationDrew DeVault2019-05-172-3/+3
| | | | Will probably end up doing this differently anyway
* Implement ui.empty-message config optionDrew DeVault2019-05-171-1/+1
| | | | | Also removes some options that aren't going to be supported any time soon.
* Fix date header on outgoing emailsDrew DeVault2019-05-171-1/+1
|
* Decode email when reading it for quotingDrew DeVault2019-05-161-0/+1
|
* Implement :reply -q and :reply -aDrew DeVault2019-05-161-0/+9
|
* Implement (basic form) of :replyDrew DeVault2019-05-162-7/+19
|
* Let caller pass in custom headers to composeDrew DeVault2019-05-161-6/+32
|
* Copy sent emails to the Sent folderDrew DeVault2019-05-151-1/+9
| | | | Or rather, to a user-specified folder
* Force INBOX to be included in dirlistDrew DeVault2019-05-141-0/+11
|
* Implement :copy (aka :cp)Drew DeVault2019-05-141-0/+4
|
* Update tab name as subject changesDrew DeVault2019-05-141-0/+12
| | | | Also moves truncation to the tab widget
* Add $EDITOR, internal config for composeDrew DeVault2019-05-141-5/+12
|
* Add distinct keybindings for each compose viewDrew DeVault2019-05-142-2/+19
|
* Implement sending emails /o/Drew DeVault2019-05-141-18/+42
|
* Add :send-message, prepares & writes email to /tmpDrew DeVault2019-05-142-4/+86
|
* Handle external message deletionsDrew DeVault2019-05-131-1/+0
|
* Handle incoming emails gracefullyDrew DeVault2019-05-132-6/+7
|
* Spec out review message screenDrew DeVault2019-05-131-6/+58
|
* Populate "From" header from config for new emailsDrew DeVault2019-05-132-12/+24
|
* Implement :{next,prev}-field in compose viewDrew DeVault2019-05-122-1/+19
|
* Expand compose focus handling a bitDrew DeVault2019-05-121-19/+30
|
* Add initial compose widgetDrew DeVault2019-05-123-1/+125
|
* "Press any key to close" for completed processesDrew DeVault2019-05-111-0/+6
|
* Refactor ctx stashing out of exlineDrew DeVault2019-05-111-8/+2
|
* Split ex line text handling into dedicated widgetDrew DeVault2019-05-113-107/+27
|
* lib/msgstore: protect with a mutexSimon Ser2019-04-291-0/+18
| | | | | | MessageStore has a lot of exported fields that can be read from the outside. Each read must be protected, because a call from Update could happen at any time.