summary refs log tree commit diff stats
path: root/.github/PULL_REQUEST_TEMPLATE.md
diff options
context:
space:
mode:
authorWojciech Siewierski <wojciech.siewierski@onet.pl>2016-06-29 22:29:11 +0200
committerWojciech Siewierski <wojciech.siewierski@onet.pl>2016-06-30 09:33:10 +0200
commit058a7ebe563e4c30ff9bd15b2861c1f86df7d23b (patch)
tree55875ffec9c59bce7a5f84770f951b3b80e4192e /.github/PULL_REQUEST_TEMPLATE.md
parenta9a75dde4cb02d63c1cf07884413e4d4d0b7aa32 (diff)
downloadranger-058a7ebe563e4c30ff9bd15b2861c1f86df7d23b.tar.gz
Refactor and improve the TERMCMD handling
Now only the first token of TERMCMD needs to exist in PATH. Previously
the whole value was checked, which could contain additional parameters.

The check and term guessing were performed in two places. Now it's done
by the get_term() function to reduce the code duplication. In that
function the second check was indented one level deeper (relative to the
original code). Keeping both checks on the same level, while visually
pleasing, was conveying the wrong message. One never wants to perform
the second check if the first one fails. Nesting shouldn't be a problem:
if the nesting will need to be any deeper than this, this code will need
to be refactored anyway.

Fixes #613.
Diffstat (limited to '.github/PULL_REQUEST_TEMPLATE.md')
0 files changed, 0 insertions, 0 deletions