summary refs log tree commit diff stats
diff options
context:
space:
mode:
authornfnty <git@nfnty.se>2016-12-24 06:49:39 +0100
committernfnty <git@nfnty.se>2017-01-17 05:59:03 +0100
commite30a3ee90c2c2c2d945d4d1684f5850700e3101a (patch)
tree2c6f4ccc994859fb583579089a79e1488c9bf50e
parent62a776bbd80408c110e2d536ae406420c47f6bb1 (diff)
downloadranger-e30a3ee90c2c2c2d945d4d1684f5850700e3101a.tar.gz
linting: Enable `access-member-before-definition`
-rw-r--r--.pylintrc2
-rw-r--r--ranger/core/actions.py4
-rw-r--r--ranger/core/fm.py2
-rw-r--r--ranger/gui/ui.py2
4 files changed, 6 insertions, 4 deletions
diff --git a/.pylintrc b/.pylintrc
index 56f0ec0e..43337df8 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -8,7 +8,7 @@ max-branches=16
 
 [FORMAT]
 max-line-length = 99
-disable=locally-disabled,locally-enabled,missing-docstring,duplicate-code,fixme,broad-except,cyclic-import,attribute-defined-outside-init,access-member-before-definition
+disable=locally-disabled,locally-enabled,missing-docstring,duplicate-code,fixme,broad-except,cyclic-import,attribute-defined-outside-init
 
 [TYPECHECK]
 ignored-classes=ranger.core.actions.Actions
diff --git a/ranger/core/actions.py b/ranger/core/actions.py
index 5270a8da..c2a93231 100644
--- a/ranger/core/actions.py
+++ b/ranger/core/actions.py
@@ -76,7 +76,7 @@ class Actions(  # pylint: disable=too-many-instance-attributes,too-many-public-m
 
         Change mode to "visual" (selection) or "normal" mode.
         """
-        if mode == self.mode:
+        if mode == self.mode:  # pylint: disable=access-member-before-definition
             return
         if mode == 'visual':
             self._visual_start = self.thisdir.pointed_obj
@@ -84,7 +84,7 @@ class Actions(  # pylint: disable=too-many-instance-attributes,too-many-public-m
             self._previous_selection = set(self.thisdir.marked_items)
             self.mark_files(val=not self._visual_reverse, movedown=False)
         elif mode == 'normal':
-            if self.mode == 'visual':
+            if self.mode == 'visual':  # pylint: disable=access-member-before-definition
                 self._visual_start = None
                 self._visual_start_pos = None
                 self._previous_selection = None
diff --git a/ranger/core/fm.py b/ranger/core/fm.py
index ddad8c94..4538a44f 100644
--- a/ranger/core/fm.py
+++ b/ranger/core/fm.py
@@ -36,7 +36,7 @@ from ranger.ext import logutils
 LOG = logging.getLogger(__name__)
 
 
-class FM(Actions,  # pylint: disable=too-many-instance-attributes,abstract-method
+class FM(Actions,  # pylint: disable=too-many-instance-attributes
          SignalDispatcher):
     input_blocked = False
     input_blocked_until = 0
diff --git a/ranger/gui/ui.py b/ranger/gui/ui.py
index bc3f024d..f33f306e 100644
--- a/ranger/gui/ui.py
+++ b/ranger/gui/ui.py
@@ -444,9 +444,11 @@ class UI(  # pylint: disable=too-many-instance-attributes,too-many-public-method
                 new_browser = self._viewmode_to_class(value)(self.win)
 
                 if hasattr(self, 'browser'):
+                    # pylint: disable=access-member-before-definition
                     old_size = self.browser.y, self.browser.x, self.browser.hei, self.browser.wid
                     self.replace_child(self.browser, new_browser)
                     self.browser.destroy()
+                    # pylint: enable=access-member-before-definition
                     new_browser.resize(*old_size)
                 else:
                     self.add_child(new_browser)