about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
* Fix two issues caught by pylint3ktoonn2020-07-052-1/+2
| | | | | One lacking `from __future__ import absolute_import` and one implicit-format-spec (a custom check!) : )
* Implement python 2 compatibility checkstoonn2020-07-055-0/+293
| | | | | | | | | We have been stuck on pylint <2 for a long time now because it dropped some of the python 2 lints we rely on. We maintain compatibility with python 2.6+ and 3.5+ and a lack of lints makes especially the former much harder. Incompatibilities had already snuck in in the form of implicit format specs. By implementing a custom checker we can make sure this doesn't happen again.
* Document expected failure of GH Actiontoonn2020-07-051-1/+1
| | | | | | | Github Actions don't support some of our tests, due to `ncurses`. This Action fails intentionally so it might get fixed once we figure it out. If we invert the failure condition to "make CI green" we might forget about it.
* Clarify excluded tests for github workflowtoonn2020-07-052-3/+3
| | | | | Add pytest to the failing workflow because otherwise it's not run with python 2.7.
* Possible bug caught in reviewtoonn2020-07-053-5/+9
| | | | | | | Forgot to cast the `programs` generator to a list when dropping the unnecessary continuation. Miscellaneous alignment fixes.
* Drop explicit return Nonetoonn2020-07-051-1/+0
|
* Use chained comparison instead of multiple clausestoonn2020-07-054-9/+9
|
* Adjust comment indentationtoonn2020-07-051-7/+7
|
* Drop unnecessary if-expressionstoonn2020-07-053-5/+6
|
* Use in instead of multiple equality clausestoonn2020-07-052-6/+6
|
* Drop unnecessary comprehensionstoonn2020-07-052-7/+3
| | | | | It's unclear why these comprehensions were used, maybe as a way of cloning the lists? However, this does not seem necessary.
* Drop redundant try-excepttoonn2020-07-051-4/+2
|
* Switch to testing after lower casing for consistencytoonn2020-07-051-2/+2
|
* Drop redundant pass statementstoonn2020-07-053-11/+0
| | | | | Because of the docstrings the function bodies aren't empty and pass is not required.
* Add local pylint disablestoonn2020-07-053-2/+4
|
* Disable dict-comprehension suggestiontoonn2020-07-051-0/+2
| | | | | Dict comprehensions were add in 2.7 so we can't use them for COMPAT reasons.
* Disable spurious warning, name is obviously passedtoonn2020-07-051-0/+1
|
* Replace if statement with dict.get with defaulttoonn2020-07-051-8/+2
|
* Add global Pylint ignorestoonn2020-07-052-2/+2
| | | | | | | | | | `no-else-break/continue/raise/return` because they're nonsense and result in actively less readable code. `useless-object-inheritance` because that's a py3-ism. `import-outside-toplevel` because we use this in many places to good effect.
* Prepare for Pylint transition from versions <2toonn2020-07-055-40/+17
|
* Merge branch 'touch-recursive'toonn2020-07-051-1/+5
|\
| * :touch create missing directoriestoonn2020-06-161-1/+5
| | | | | | | | | | | | | | | | `:mkdir` creates directories recursively like `mkdir -p`. `:touch` failed when parent directories didn't exist, for convenience and consistency it now creates missing directories recursively. Fixes #1998
* | Merge branch 'color-line-numbers'toonn2020-07-055-5/+16
|\ \
| * | Implement a line_number context for colorschemestoonn2020-04-095-5/+16
| | | | | | | | | | | | | | | | | | | | | | | | Changes the default color for line numbers to differ from the file's color to the terminal's base foreground color in the default theme. Green in the jungle theme and bold and/or bright in the snow theme. Fixes #1906
* | | Merge branch 'py-version-checks'toonn2020-07-0513-37/+34
|\ \ \
| * | | Factor out python 3 version checkingtoonn2020-06-2912-37/+34
| | | | | | | | | | | | | | | | | | | | | | | | We check whether we're running python 2 or 3 in many places. In some places we do more specific version checks but with the new `PY3` constant modeled after `six` this code should be slightly more readable.
| * | | Factor PY3 constant out into ranger moduletoonn2020-06-293-5/+5
| | | |
* | | | Merge branch 'rc_macro_error'toonn2020-07-052-68/+121
|\ \ \ \
| * | | | Add MacroDicttoonn2019-09-272-67/+120
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Macros are resolved for set commands. A contributor wanted to add a setting for a date format string to be used in ranger's status bar. The string they tried happened to include `%d` which is a valid ranger macro for the name of `thisdir`. This attribute is not yet defined when ranger is reading `rc.conf` and this uncaught exception would crash ranger. To work around this we need to catch `AttributeError`s for values that might not exist yet. To avoid the repetition that'd come with all these try-catch statements that behavior has been encapsulated in a new MacroDict. This is almost as easy to use as the regular python dictionary used previously. The only difference being that we need to wrap values that might cause problems in a python `lambda`, though it doesn't do any harm to wrap values that can't raise exceptions.
| * | | | Catch exceptions when resolving macros in rc.conftoonn2019-07-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | While parsing the settings in `rc.conf` `self.fm.thisfile` doesn't exist yet.
* | | | | Merge pull request #1816 from toonn/gifehfehWojciech Siewierski2020-07-051-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Feh does not handle animated gifs gracefully
| * | | | | Feh does not handle animated gifs gracefullytoonn2020-01-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fixes #1814
* | | | | | Merge pull request #1847 from toonn/rust-is-textWojciech Siewierski2020-07-051-5/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add rust to programming languages for rifle
| * | | | | | Add rust to programming languages for rifletoonn2020-02-211-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the Rust extension `.rs` to the list of programming languages to match editor and pager because it is erroneously guessed as being `application/rls-services+xml`.
* | | | | | | Merge branch 'cache-hash' [#2019]Wojciech Siewierski2020-07-051-11/+9
|\ \ \ \ \ \ \
| * | | | | | | Switch from SHA-1 to SHA-512 for the cachetoonn2020-06-291-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The performance hit is negligible. File name lengths are usually 255 bytes at minimum (except for FAT, but a SHA-1 digest is truncated too). An attack on the ranger cache based on hash collisions is probably fairly unlikely but preventing it is almost free. This should be merged soon after #1838 because both these PRs change the cache hashes and can therefore cause generation of previews that have been cached before, wasting some disk space.
| * | | | | | | Get rid of redundant codetoonn2020-06-291-6/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The python version dependence is gone because we no longer want to hash the path. We've been doubling up `os.path.join` calls for a long time, that's silly, let's just not.
| * | | | | | | Drop file path from cache hashtoonn2020-06-291-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because we include the device identifier and the inode in cache hashes now we no longer need the path to the file. Files are already more uniquely identified (if the path was reused for another file with an acceptable mtime there used to be a collision). A small benefit is that hardlinked and symlinked files should now only require a single cached preview.
| * | | | | | | Include mtime in hash rather than comparingtoonn2020-06-291-7/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Comparing the mtimes of a file and a cached preview or including the mtime in the preview's hash are almost equivalent except this way we don't need to find out the preview's mtime. We include the device identifier and the inode in the hash, this makes sure duplicate filenames don't cause erroneous hits in the cache.
| * | | | | | | Allow equal mtime for cached previewstoonn2020-02-121-1/+1
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows the use of symlinks to prevent copying files to the cache. Fixes #1837
* | | | | | | Merge pull request #1824 from toonn/pprime-draw-bookmarksWojciech Siewierski2020-07-051-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Add bookmark drawing to the paste to bookmark map
| * \ \ \ \ \ \ Merge branch 'master' into pprime-draw-bookmarksWojciech Siewierski2020-07-0510-71/+80
| |\ \ \ \ \ \ \ | | | |_|_|/ / / | | |/| | | | |
| * | | | | | | Add bookmark drawing to the paste to bookmark maptoonn2020-02-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Neglected to add drawing of bookmarks to the mapping that allows pasting the contents of the copybuffer to a bookmark's path. Brought to my attention by discussion in #1277.
* | | | | | | | Merge pull request #1870 from toonn/py26-format-fixWojciech Siewierski2020-07-055-19/+25
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Py26 does not support implicit format spec numbering
| * \ \ \ \ \ \ \ Merge branch 'master' into py26-format-fixWojciech Siewierski2020-07-052-3/+13
| |\ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | Merge pull request #1961 from toonn/pass-fileWojciech Siewierski2020-07-051-2/+6
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Revert "Revert "ranger <path> can select files""
| * \ \ \ \ \ \ \ \ Merge branch 'master' into pass-fileWojciech Siewierski2020-07-052-3/+3
| |\ \ \ \ \ \ \ \ \ | | | |_|/ / / / / / | | |/| | | | | | |
| * | | | | | | | | Revert "Revert "ranger <path> can select files""toonn2020-05-191-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I can't reproduce the problems with <Right> and I don't see anything in the commit that could've caused them in the first place tbh. The issue this introduces keeps coming up so I'm verting the original change. Fixes #1655 Fixes #1386 This reverts commit 11549e2c0c73a8a0bb543801af4e134b3e076095.
* | | | | | | | | | Merge pull request #2013 from toonn/silence-bulkrenameWojciech Siewierski2020-07-051-1/+7
|\ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / |/| | | | | | | | | Implement passing of flags for :bulkrename
| * | | | | | | | | Implement passing of flags for :bulkrenametoonn2020-06-231-1/+7
|/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The flags a bulkrename command passed to the command runner were fixed to `w`, which means "wait for an enter keypress." Now it's possible to pass whichever flags you want. Passing any flag overrides the default so if you still want the confirmation you need to explicitly pass `w`. Fixes #2002
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-11-23 07:03:11 +0000