about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
* Fix memleaks & more auto-freeSteffen Jaeckel2023-05-121-15/+5
| | | | | | | | | | | | | | | | | | | | | | | | | `data_dir` would have been leaked if directory creation failed. `editor_argv` was leaked at some point, no idea why. ``` ==1244734== 118 (32 direct, 86 indirect) bytes in 1 blocks are definitely lost in loss record 6,299 of 7,824 ==1244734== at 0x4846CC3: realloc (vg_replace_malloc.c:1451) ==1244734== by 0x5E85AD0: g_realloc (in /usr/lib/libglib-2.0.so.0.7600.1) ==1244734== by 0x5E4A004: ??? (in /usr/lib/libglib-2.0.so.0.7600.1) ==1244734== by 0x5E4A7B1: g_ptr_array_add (in /usr/lib/libglib-2.0.so.0.7600.1) ==1244734== by 0x5EA4235: g_strsplit (in /usr/lib/libglib-2.0.so.0.7600.1) ==1244734== by 0x1F143C: get_message_from_editor (editor.c:92) ==1244734== by 0x193F6B: _inp_rl_send_to_editor (inputwin.c:950) ==1244734== by 0x614642F: _rl_dispatch_subseq (readline.c:916) ==1244734== by 0x6146C85: _rl_dispatch_callback (readline.c:823) ==1244734== by 0x616739F: rl_callback_read_char (callback.c:241) ==1244734== by 0x1923DB: inp_readline (inputwin.c:188) ==1244734== by 0x149860: prof_run (profanity.c:117) ==1244734== by 0x2283E8: main (main.c:186) ``` Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Improve const-correctness of APISteffen Jaeckel2023-05-124-4/+4
| | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Fix potential double-freeSteffen Jaeckel2023-05-121-1/+1
| | | | | | introduced in 8d3c1f79ac7cc2b0830f0afed48dc1fb9008ab0e Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Consider global CFLAGS and use libstrophe CFLAGSSteffen Jaeckel2023-05-121-2/+2
| | | | | | global `CFLAGS` were ignore before Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Merge pull request #1839 from H3rnand3zzz/cleanup/gchar-charMichael Vetter2023-05-1125-267/+137
|\ | | | | Cleanup: gchar as gchar instead of char
| * Merge branch 'master' into cleanup/gchar-charMichael Vetter2023-05-1113-90/+111
| |\ | |/ |/|
* | Merge pull request #1847 from profanity-im/minor-improvementsMichael Vetter2023-05-1110-27/+46
|\ \ | | | | | | Minor improvements
| * | fix memory leaksSteffen Jaeckel2023-05-102-21/+22
| | | | | | | | | | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * | fix `/reconnect now`Steffen Jaeckel2023-05-107-3/+22
| | | | | | | | | | | | | | | | | | | | | This fixes #1846 Issue introduced by a0aa26b6fa65ba625f4a6d3495a345c7120ff16d Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * | more `auto_char`Steffen Jaeckel2023-05-101-2/+1
| | | | | | | | | | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * | fix "window `NULL` issue" (hopefully)Steffen Jaeckel2023-05-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were multiple reports where after a reconnect the window of the MUC that was last opened, was empty. `muc_join()` creates an instance of a MUC, `presence_join_room()` works with this instance. Therefore the instance has to exist before working on it. I'm not sure if this really fixes the issue, but at least it didn't happen anymore after I applied this modification. I can't remember how I stumbled over this, either while looking at debug logs or while looking at Valgrind output while a reconnect happened, but something went wrong. Then I came to the conclusion that this may fix the issue and for now it did ... maybe it comes back, then my RCA was wrong. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* | | Merge pull request #1845 from profanity-im/fix/avatarMichael Vetter2023-05-114-64/+65
|\ \ \ | |/ / |/| | Improvements for /executable and /avatar code
| * | Add helper function for individual cmd_executable_*() functionsMichael Vetter2023-05-101-46/+7
| | | | | | | | | | | | | | | | | | Each of the cmd_executable_editor(), cmd_executable_urlopen() etc calls this helper function since they were all doing the same just for different configurations.
| * | Add autocompletion for /executable parametersMichael Vetter2023-05-101-0/+32
| | | | | | | | | | | | | | | We autocompleted `/executable` to `avatar`, `vcard_photo`, `editor` etc. But didn't autocomplete the next parameter. Namely `set` and `default`.
| * | Make it possible to reset editor to defaultMichael Vetter2023-05-102-0/+5
| | | | | | | | | | | | | | | All the other commands (avatar, vcard_photo, urlsave, urlopen) have the ability to reset to default already.
| * | Add vcard_photo to /executable autocompletionMichael Vetter2023-05-101-0/+1
| | | | | | | | | | | | Was forgotten in f934c5b59.
| * | Align avatar behaviour with urlopenMichael Vetter2023-05-103-19/+24
| | | | | | | | | | | | | | | | | | `/executable avatar` now also uses cmdtemplate and parse %p. It seems to me that the `/avatar` command was actually completely broken on master.
| * | Remove parsing of /avatar cmdMichael Vetter2023-05-101-3/+0
| | | | | | | | | | | | | | | | | | This is done in `/executable avatar set` since d7848e38b. The command help also didn't mention this anymore. Seems like it was forgotten to remove the actual parsing of this.
| | * Cleanup: gchar as gchar instead of charJohn Hernandez2023-05-0426-269/+138
| |/ |/| | | | | | | | | | | | | Use gchar instead of char in most of the cases where gchar is intended. Reason: improve compatibility and stability. Issue #1819 Minor refactoring.
* | Merge pull request #1843 from IsaacM88/masterMichael Vetter2023-05-038-20/+92
|\| | | | | Add ability to disable avatar publishing
| * Add ability to disable avatar publishingIsaacM882023-05-028-20/+92
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add "/avatar disable" to comply with point "3.5 Publisher Disables Avatar Publishing" in XEP-0084. src/command/cmd_defs.c:2416 Add "disable" argument. Reword the "/avatar" command description so it flows better. src/command/cmd_ac.c:1101 Add "disable" to the "/avatar" autocomplete dictionary. src/command/cmd_funcs.c:9277 Split "/avatar" commands into two groups with an if statement; those with a parameter and those without. "cons_bad_cmd_usage()" is in both groups, which is messy. "disable" has similar logic to "set", but it includes a failure message. src/xmpp/avatar.c:152 "avatar_publishing_disable()" uses the same logic to publish metadata as in "avatar_set()". src/xmpp/avatar.c:238 Add a message to inform users when they do not receive an avatar after using "/avatar get" and "/avatar open". In case of a failure, the user will be subscribed to future avatar updates as long as they continue to use their current instance of profanity. Adding "caps_remove_feature()" after "cons_show()" will unsubscribe the user from avatar updates and prevent the user from downloading an avatar unexpectedly hours later without issuing an "/avatar" command. src/xmpp/stanza.c:2698 The new "disable" function follows the same logic as "stanza_create_avatar_metadata_publish_iq()".
* Merge pull request #1838 from H3rnand3zzz/fix/omemo-trust-notificationMichael Vetter2023-04-191-3/+3
|\ | | | | Improve OMEMO messages
| * Improve OMEMO messagesJohn Hernandez2023-04-191-3/+3
| |
* | Merge pull request #1840 from H3rnand3zzz/fix/plugins-unloadMichael Vetter2023-04-191-31/+22
|\ \ | | | | | | Fix `/plugins update`
| * | Fix `/plugins update`John Hernandez2023-04-191-31/+22
| |/ | | | | | | | | | | | | | | | | | | | | Before it tried to unload the plugin first and check the output. But if broken plugin was loaded, then it couldn't unload it, so before it require uninstall and install after it, making update useless for plugin development purposes. Unload is part of the uninstall so no unload is needed inside of the cmd function. Refactoring of cmd_plugins_update.
* | Merge pull request #1837 from profanity-im/fix/memleakclientcheckMichael Vetter2023-04-192-0/+4
|\ \ | |/ |/| Fix two recently introduced memleaks
| * Fix memleak in _inp_rl_linehandlerMichael Vetter2023-04-181-0/+1
| | | | | | | | Introduced in 59b99fece.
| * Fix memleak in stanza_create_caps_query_elementMichael Vetter2023-04-181-0/+3
|/ | | | Got introduced with 5d3c8ce7c.
* Merge pull request #1835 from H3rnand3zzz/fix/message-loggingMichael Vetter2023-04-182-19/+12
|\ | | | | Fix crash, add consistency to logging
| * Add logging consistencyJohn Hernandez2023-04-181-1/+2
| | | | | | | | | | | | | | Since MUC private messages are not logged by design, part where this logging happening is removed to add consistency. Add explanation in comment.
| * Fix `/log level` crashJohn Hernandez2023-04-181-18/+10
|/ | | | | | Fix crash caused by `/log level` command. Minor refactoring of command function.
* Merge pull request #1827 from H3rnand3zzz/feature/sessions-alarmMichael Vetter2023-04-1818-24/+180
|\ | | | | New Feature: Session Alarm
| * Add vscode support to .gitignoreJohn Hernandez2023-04-181-0/+1
| |
| * Add sessions_alarmJohn Hernandez2023-04-1817-24/+179
| | | | | | | | | | | | | | | | | | Introduce new feature: sessions_alarm. Added new account setting: max_connections. On exceeding this number, user will get an alert. If number is less than 1, no alert will happen. Tests altered to fit new feature.
* | Merge pull request #1829 from H3rnand3zzz/fix/readline-historyMichael Vetter2023-04-181-5/+8
|\ \ | | | | | | Don't add the same command twice to history
| * | Don't add the same command twice to historyJohn Hernandez2023-04-171-5/+8
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | Expected behaviour When you type /command /command it should be just 1 entry in the history. Behaviour All the entries were saved. Behaviour is changed by introducing check. Before adding to history, entry now is compared to the last history entry.
* | doscs: Add terminology section to man pageMichael Vetter2023-04-171-1/+13
| | | | | | | | | | | | | | Let's just define some basic terminology. In many sections of the /help we actually use these terms. This should help new users understand what they mean.
* | Merge pull request #1831 from profanity-im/man_encMichael Vetter2023-04-171-0/+21
|\ \ | | | | | | Add encryption section to man page
| * | Add encryption section to man pageMichael Vetter2023-04-171-0/+21
|/ / | | | | | | | | | | | | | | The goal should be that users can make a more informed decision about which encryption they actually want to use. We can also use this to document usage details of implementation quirks, if any.
* | Merge pull request #1830 from profanity-im/feat/codspellciMichael Vetter2023-04-151-0/+14
|\ \ | | | | | | Add spellcheck to CI
| * | Add spellcheck to CIMichael Vetter2023-04-151-0/+14
| | |
* | | docs: Add info about different clang-format versionsMichael Vetter2023-04-151-0/+2
|/ / | | | | | | | | Make this clear to new users. Since sjaeckel had reservations on https://github.com/profanity-im/profanity/pull/1828.
* | Merge pull request #1828 from profanity-im/newclangMichael Vetter2023-04-146-151/+144
|\ \ | |/ |/| Use GH action for code style check
| * Add another formatting commit to git blame ignoreMichael Vetter2023-04-141-0/+1
| |
| * Format code with clang-format 16Michael Vetter2023-04-144-134/+137
| |
| * Switch to clang-format check actionMichael Vetter2023-04-141-17/+6
|/ | | | | | | | | | | | Instead of running clang-format outselves on the old Ubuntu version. This let's us easily configure which version of clang-format we want to execute. Used action: https://github.com/marketplace/actions/clang-format-check Properly fix: https://github.com/profanity-im/profanity/pull/1774
* docs: Fix formatting in SECURITY.mdMichael Vetter2023-04-141-1/+2
|
* Merge pull request #1823 from H3rnand3zzz/fix/msg-crashMichael Vetter2023-04-142-7/+8
|\ | | | | Fix memory corruption crash
| * Cleanup p_ox_gpg_decryptJohn Hernandez2023-04-131-4/+6
| | | | | | | | | | | | In OX implementation gpgme's buffer remains untouched, thus not leading to the crash. But code can be shorter and more concise.
| * Fix memory corruption crashJohn Hernandez2023-04-131-3/+2
| | | | | | | | | | | | | | Under certain circumstances setting plain_str[len] to 0 might lead to crash and it does not follow the best practices as well. This change allows better handling of buffer copying and prevents crash.
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-11-17 04:23:41 +0000