about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
* Safe last MUC message timestamp per MUCMichael Vetter2019-06-113-8/+10
| | | | | | After pasis review of my code he thinks it's better to safe the timestamp per MUC so we can account for some problems that could occur with timing.
* Only show MUC subject on first connectMichael Vetter2019-06-051-1/+1
| | | | | | For #704 we don't show the room history upon reconnect. Now we also don't show the room subject in the channel upon re-established connection.
* Reduce timestamp call when saving last muc messageMichael Vetter2019-06-051-12/+13
| | | | Let's test for mucwin earlier.
* Only print room history for new messages upon reconnectMichael Vetter2019-06-053-1/+53
| | | | | | | | | | | | | | | | If re-establish a connection don't print the room history again. In case there there happened nothing at all since we got the room history on the last connection. And in case there were no new messages during the time we have been disconnected. Instead of printing the room history again we now print 'Re-established Connection'. This adds a bit of overhead since we save the timestamp upon every MUC message. See: https://github.com/profanity-im/profanity/issues/704
* Merge pull request #1109 from profanity-im/fix/1083Michael Vetter2019-06-053-28/+47
|\ | | | | Fix SIGABRT on lost connection
| * statusbar: check if roster existsMichael Vetter2019-06-043-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | We destory the roster in ev_disconnect_cleanup(). Adding a function to test if the roster has been destroyed and testing for it in the statusbar. So now when the connection is lost 'Lost connection' is printed in all open windows. We can then reconnect with `/connect accountname`. Should fix https://github.com/profanity-im/profanity/issues/1083
| * statusbar: reduce duplicate codeMichael Vetter2019-06-041-32/+9
| | | | | | | | | | | | | | | | | | | | status_bar_new() and status_bar_active() are almost identical. Let's use one helper function to not duplicate code. I thought about renaming both functions into one and adding another parameter but didn't come up with a good name for the function that clearly describes what it does. So staying with current names + helper functions.
| * Determine chat window names beforehandMichael Vetter2019-06-041-13/+44
| | | | | | | | | | | | | | | | | | Save the name for displaying the windows in the statusbar inside the tab object. So far we calculated them repeatedly and this created issues when we lost the connection. Regards https://github.com/profanity-im/profanity/issues/1083
* | Add release dates to changelogMichael Vetter2019-06-051-5/+5
|/
* Merge pull request #1106 from profanity-im/saved-accountMichael Vetter2019-06-031-28/+7
|\ | | | | Don't clear saved account data in session_disconnect()
| * Don't clear saved account data in session_disconnect()Dmitry Podgorny2019-06-031-28/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If connection loss occurs, it calls session_disconnect() eventually. This function clears saved account data which is required for reconnection. Therefore, when reconnect timer expires, we get errors: 02/06/2019 04:53:42: stderr: ERR: (profanity:17115): GLib-CRITICAL **: 04:53:42.305: g_key_file_has_group: assertion 'group_name != NULL' failed 02/06/2019 04:53:43: prof: ERR: Unable to reconnect, account no longer exists: (null) To solve it, don't clear the saved data in session_disconnect(). It will be cleared properly on connection loss if reconnect timer is not configured. But won't be cleared with /disconnect command. So, after /disconnect the data will live in memory until the next /connect. Also, remove some copy-paste in connection loss path.
* | Merge pull request #1105 from profanity-im/autoping-timer-cancelMichael Vetter2019-06-034-8/+15
|\ \ | |/ |/| Cancel autoping timer on disconnect or connection loss
| * Cancel autoping timer on disconnect or connection lossDmitry Podgorny2019-06-034-8/+15
|/ | | | | | | | | If Profanity is disconnected in any way before ping response is received, the autoping timer will expire after the next connection is established. As result, user will be disconnected immediately. Cancel autoping timer in ev_disconnect_cleanup(), so it is done for all kind of disconnections.
* Merge pull request #1104 from profanity-im/fix-1103Michael Vetter2019-06-031-11/+28
|\ | | | | xmpp/connection: fix #1103
| * xmpp/connection: fix #1103Dmitry Podgorny2019-06-011-11/+28
|/ | | | | | | | | | | | When connection is lost, profanity tries to disconnect what leads to an infinite loop. The loop occurs, because connection_disconnet() runs xmpp_run_once() separately and waits for XMPP_CONN_DISCONNECT event. But it doesn't happen, because the connection object is disconnected. As solution, don't disconnect after XMPP_CONN_DISCONNECT is received. Also, don't free libstrophe objects while the event loops executes, because the event loop continues using objects after callbacks quit.
* Close windows on connection loss not general disc.Michael Vetter2019-05-272-1/+1
| | | | | | | | | | Call `ui_close_all_wins();` only if we disconnect on purpose not when connection is lost. Otherwise users might miss messages. This partly reverts 6ac73db876c83c7068c4795b19c09ea59eb18a40. Regards https://github.com/profanity-im/profanity/issues/1083
* Merge pull request #1092 from frnky/remove_mblenMichael Vetter2019-05-231-5/+2
|\ | | | | Don't call mblen() to not depend on locale
| * Don't call mblen() to not depend on localeFrank Zschockelt2019-05-221-5/+2
| | | | | | | | | | | | | | | | | | | | mblen will fail with return code -1 if the locale used by the unit tests isn't available on the machine. This will lead to an off by one error in some tests where the needle is at the end of the haystack. Since prof_occurrences expect null-terminated strings, the character after the needle can simply be found by incrementing the address of the found needle with strlen(needle).
* | Merge pull request #1102 from paulfariello/fix/malformed-omemo-messageMichael Vetter2019-05-231-4/+8
|\ \ | |/ |/| Correctly handle malformed OMEMO messages
| * Correctly handle malformed OMEMO messagesPaul Fariello2019-05-231-4/+8
|/ | | | Fix #1101
* Merge pull request #1098 from optmzr/fix-omemo-gen-messageMichael Vetter2019-05-221-0/+1
|\ | | | | | | | | Force UI update before generating OMEMO crypto materials The message wouldn't show up before the generation of OMEMO crypto materials started.
| * Force UI update before generating OMEMO crypto materialsWilliam Wennerström2019-05-211-0/+1
| |
* | Create seperate function for disconnect cleanupMichael Vetter2019-05-195-30/+115
| | | | | | | | | | Duplicate code in client_events.c and server_events.c. Let's have events/common.c and a function containing that code.
* | Merge pull request #1091 from frnky/fix_tests_on_32bitMichael Vetter2019-05-175-25/+25
|\ \ | |/ |/| Fix unit tests on 32-bit architectures
| * Use mock_type() for casting mock()Frank Zschockelt2019-05-084-13/+13
| |
| * Use mock_ptr_type() to silence compiler warningsFrank Zschockelt2019-05-084-12/+12
|/ | | | | | Unit tests on 32-bit architectures were failing due to "cast to pointer from integer of different size" warnings. mock_ptr_type silences those by first casting to uintptr_t.
* Fix ifdef guard (should have been OMEMO)Michael Vetter2019-05-061-1/+1
|
* Merge pull request #1090 from jubalh/fix/connection-loss-1089Michael Vetter2019-05-061-0/+5
|\ | | | | Reset things on connection loss
| * Reset things on connection lossMichael Vetter2019-05-061-0/+5
| | | | | | | | | | Remove the windows, clear tls certs, clean omemo. Regards https://github.com/profanity-im/profanity/issues/1089
* | Merge pull request #1084 from jubalh/occupants-charMichael Vetter2019-05-039-3/+94
|\ \ | |/ |/| Add occupants char
| * Add occupants charMichael Vetter2019-05-029-3/+94
| | | | | | | | | | | | | | `/occupants char` now sets a character that is displayed before the nick in MUCs. Similar like `/roster char` is displaying a char for the roster. Regards #690
* | Update travis URLMichael Vetter2019-05-031-1/+1
| |
* | Update profanity repo URLMichael Vetter2019-05-036-9/+9
| | | | | | | | Move from github.com/boothj5/* to github.com/profanity-im/*
* | Update tests with new URLMichael Vetter2019-05-037-40/+40
| | | | | | | | https://github.com/profanity-im/profanity/issues/1085
* | Update profanity URL in entity capabilities stanzaMichael Vetter2019-05-031-1/+1
| | | | | | | | Regards https://github.com/profanity-im/profanity/issues/1085
* | Update profanity URL in /tiny exampleMichael Vetter2019-05-031-1/+1
| | | | | | | | Regards https://github.com/profanity-im/profanity/issues/1085
* | Check for new profanity version using new URLMichael Vetter2019-05-032-2/+2
| | | | | | | | Regards https://github.com/profanity-im/profanity/issues/1085
* | Update profanity URL in spec fileMichael Vetter2019-05-031-1/+1
| | | | | | | | Regards https://github.com/profanity-im/profanity/issues/1085
* | Update profanity URL in manpageMichael Vetter2019-05-031-3/+3
| | | | | | | | Regards https://github.com/profanity-im/profanity/issues/1085
* | Replace profanity URL in READMEMichael Vetter2019-05-031-3/+3
|/ | | | Regards https://github.com/profanity-im/profanity/issues/1085
* OMEMO: Initialize result in omemo_automatic_startMichael Vetter2019-04-291-1/+1
| | | | | | | | | This is actually not needed because result will always be set. hartmann had problems building profanity on OpenBSD and he proposed this patch. Let's use it to make the compiler happy there.
* Merge pull request #1080 from jubalh/omemo-no-device-idMichael Vetter2019-04-241-1/+5
|\ | | | | OMEMO: Check if ID is present before using it
| * OMEMO: Check if ID is present before using itMichael Vetter2019-04-241-1/+5
|/ | | | Fixes https://github.com/boothj5/profanity/issues/1079
* Merge pull request #1078 from jubalh/statusbarnuMichael Vetter2019-04-241-1/+1
|\ | | | | Fix statusbar number in theme
| * Fix statusbar number in themeMichael Vetter2019-04-241-1/+1
|/ | | | There is a typo here. So this actually never worked ;-)
* Add occupants.wrap to theme templateMichael Vetter2019-04-241-0/+1
|
* Fix formatting for privileges onMichael Vetter2019-04-241-0/+4
| | | | | `/privileges on` lists `Moderator`, `Visitor` etc. Formatting was wrong here. Printing privilige followed by nickaname in the same line.
* Occupantswin: handle newline correctlyMichael Vetter2019-04-241-6/+6
|
* Add occupants wrap to helpMichael Vetter2019-04-241-2/+4
|
* Fix occupants header char messageMichael Vetter2019-04-241-2/+2
|
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-07-11 18:59:11 +0000