about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
* Refactor win_print_outgoing_muc_msg()Michael Vetter2020-02-173-15/+7
| | | | We never use the printf like behaviour anyways.
* Refactor win_println_incoming_muc_msg()Michael Vetter2020-02-173-15/+7
| | | | We never use the printf like behaviour anyways.
* Refactor win_print_outgoing()Michael Vetter2020-02-174-19/+10
| | | | We never use the printf like behaviour anyways.
* Fix typoMichael Vetter2020-02-171-1/+1
|
* Merge branch 'feature/sendfile-enc-warn'Michael Vetter2020-02-177-7/+157
|\ | | | | | | Close https://github.com/profanity-im/profanity/pull/1270
| * Mention how to enable unencrypted file transerMichael Vetter2020-02-171-2/+2
| | | | | | | | Regards https://github.com/profanity-im/profanity/pull/1270
| * Make /sendfile in PGP session configurableMichael Vetter2020-02-176-3/+33
| | | | | | | | | | | | `/pgp sendfile on` allows unencrypted file transfer in an PGP session. Regards https://github.com/profanity-im/profanity/pull/1270
| * Make /sendfile in OTR session configurableMichael Vetter2020-02-177-6/+47
| | | | | | | | | | | | `/otr sendfile on` allows unencrypted file transfer in an OMEMO session. Regards https://github.com/profanity-im/profanity/pull/1270
| * Make /sendfile in OMEMO session configurableMichael Vetter2020-02-177-10/+54
| | | | | | | | | | | | | | `/omemo sendfile on` allows unencrypted file transfer in an OMEMO session. Regards https://github.com/profanity-im/profanity/pull/1270
| * Disallow sendfile in e2ee chat sessionsmoppman2020-02-171-0/+35
|/
* test: Init window.layout to make compiler happyMichael Vetter2020-02-141-0/+1
| | | | | Fix tests/unittests/test_cmd_otr.c:415: warning: 'window.layout' is used uninitialized in this function on openbsd (thanks optmzr)
* Add workaround for compiler warningMichael Vetter2020-02-141-1/+1
| | | | Regards https://github.com/profanity-im/profanity/issues/1265
* xep-0308: Add note about tab completionMichael Vetter2020-02-141-1/+2
|
* xep-0308: add note about where corrections are possibleMichael Vetter2020-02-141-1/+2
|
* xep-0308: only allow /correct when corrections are enabledMichael Vetter2020-02-141-0/+5
|
* Merge pull request #1267 from profanity-im/feature/xep-0308-lmcMichael Vetter2020-02-1434-154/+594
|\ | | | | XEP-0308 Last Message Correction
| * xep-0308: add caution noteMichael Vetter2020-02-141-1/+1
| | | | | | | | | | We need to change the buffer structure first, so that we save the from field there.
| * Rename buffer->from to buffer->display_fromMichael Vetter2020-02-143-10/+12
| |
| * xep-0308: enable for carbon copied messagesMichael Vetter2020-02-142-1/+15
| | | | | | | | | | | | | | If we are connected with another client and send a message, then correct it. We now display it correctly in Profanity. Id wasn't saved for carbon copied messages too so far.
| * xep-0308: enable correction in outgoing messages with delivery receiptsMichael Vetter2020-02-143-8/+10
| |
| * Always send delivery receipts if enabledMichael Vetter2020-02-141-14/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | So far receipts are only send if we have enabled it and the other client supports it. But it could be that the other person is connected with several clients. One supporting it and the other which doesn't. If the not supporting one is active and we send to a fulljid, then we won't get receipts. Probably it's best to just always send them if they are enabled in Profanity. And not try to find out the capabilities of the other client. Fix https://github.com/profanity-im/profanity/issues/1268
| * Rename win_print_with_receipt() -> win_print_outgoing_with_receipt()Michael Vetter2020-02-143-4/+4
| |
| * Add myself to copyrightMichael Vetter2020-02-144-0/+4
| |
| * Rename `win_println_them_message()` -> `win_println_incoming_muc_msg()`Michael Vetter2020-02-143-3/+3
| | | | | | | | | | | | | | | | In aa3693daa211b36c78d136d5a1ee9f3258e21352 I renamed `win_println_me_message()` -> `win_print_outgoing_muc_msg()`. Now: `win_println_them_message()` -> `win_println_incoming_muc_msg()` to be more consistent and descriptive.
| * Fix testsMichael Vetter2020-02-142-8/+8
| |
| * xep-0308: remove replace_id from privwin signatureMichael Vetter2020-02-143-4/+4
| | | | | | | | No `/correct` allowed in privwins
| * xep-0308: adapt unit test stubsMichael Vetter2020-02-142-8/+6
| |
| * xep-0308: only replace messages if the user enabled the featureMichael Vetter2020-02-141-3/+3
| | | | | | | | Outgoing `/correct` will still work.
| * xep-0308: Make /correct work without quotation marksMichael Vetter2020-02-144-11/+14
| | | | | | | | | | | | Now we can specify an unlimited amount of arguments for commands. Maybe this is also helpful for other commands that use quotation marks so far.
| * xep-0308: Fix sending corrections for multiple wordsMichael Vetter2020-02-143-4/+7
| |
| * xep-0308: Add autocompletion of last message for /correctMichael Vetter2020-02-141-4/+29
| |
| * xep-0308: Implement LMC for outgoing MUC messagesMichael Vetter2020-02-1410-17/+71
| | | | | | | | | | | | Including OMEMO encrypted ones. Also rename `win_println_me_message()` to `win_print_outgoing_muc_msg() as I think it's a more descriptive name.
| * Rename MUC PM handlerMichael Vetter2020-02-141-3/+3
| | | | | | | | | | Rename from _private_chat_handler() to _handle_muc_private_message() to be more consistent with other handler names.
| * xep-0308: Dont allow to correct MUC PMsMichael Vetter2020-02-143-10/+0
| | | | | | | | | | People could change messages of other people if the nick isn't registered.
| * xep-0308: correct incoming MUC PMsMichael Vetter2020-02-121-0/+14
| |
| * xep-0308: Display corrected incoming MUC messages correctlyMichael Vetter2020-02-124-5/+21
| |
| * xep-0308: Don't check whether receiving clients supports this featureMichael Vetter2020-02-121-16/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | XEP-0308 Version 1.1.0 (2019-05-15) states "It is expected that clients will not send message corrections to clients that do not support them, as non-supporting clients will render these as duplicate (corrected) messages" ``` 10:12:47 - jubalh: Do clients actually check whether other clients support xep0308 (LMC) before sending? 10:13:13 - pep.: not poezio, and I doubt anybody does. it's the "but carbons/MAM" argument 10:13:49 - jubalh: Profanity doesnt support this yet. So I always get the message twice. One time the message, and then the corrected ones. And I think that's right. But I understood xep0308 correctly it sais a client shouldnt sent a message with 'replace' if the client doesnt support it? I don't see why 10:14:50 - Ge0rG: jubalh: because you might also use Conversations and read the backlog from MAM on conversations 10:15:51 - jubalh: Ge0rG: sorry? 10:16:36 - Ge0rG: jubalh: when I'm sending you a message, I don't know which client you'll use to read it. So it doesn't make sense to limit the features I use 10:27:57 - jubalh: Yes. That's why I'm confused by thestatement in the XEP 10:28:13 - jubalh: "It is expected that clients will not send message corrections to clients that do not support them, as non-supporting clients will render these as duplicate (corrected) messages. " 10:28:37 - Holger: Yes, you're both saying the same thing. And yes I agree, that part of the XEP is nonsense. We have that "check whether the peer's client supports it" stuff in various XEPs that depend on recipient's features and it never makes sense as it doesn't cope with multi-device, MAM, groupchat. 10:28:53 - jubalh: First: You don't know if he is connected with several clients. Some supporting it and some not. Second: Why not just resend the new corrected message? Then he has both messages and no information is lost. If he only gets the first one information is lost 10:29:20 - jubalh: Okay 10:29:30 - jubalh: Then I won't implement it this way. Thanks guys! 10:29:34 - Holger: Well UX is a bit meh if the recipient doesn't support it (I'm an MCabber user and know what I'm talking about) but I see no better solution, yes. ``` So it makes more sense to just always send it. Non supporting clients will then get the message and the corrected message. So they get it "twice". Which is the right thing to do in my opinion.
| * xep-0308: enable corrections for outgoing encrypted messagesMichael Vetter2020-02-128-44/+55
| |
| * Distinguish between _win_print() and _win_printf()Michael Vetter2020-02-121-19/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | _win_print() and _win_printf() sound like they are the same. But actually they are something totally different. I renamed _win_print() to _win_print_internal() for that reason. It's more about actually drawing to the ncurses window. _win_printf() calls _win_print() and also writes the text to the window buffer. Which _win_print() didn't, it was really just the ncurses specific things. In some cases there is _win_print_internal() called after a buffer_append() in those cases it might be more correct to actually call _win_printf(). It was not done so far. But probably is better. But will mean a bit more operations. I'll have to check this later.
| * Rename win_correct_incoming to win_correctMichael Vetter2020-02-121-4/+4
| | | | | | | | and make it static.
| * xep-0308: update the UI upon sending a corrected messageMichael Vetter2020-02-118-24/+37
| | | | | | | | | | So far we don't do this for encrypted messages. Still needs to be done. And MUC also needs to be done.
| * xep-0308: Implement `/correct` to correct the last send messageMichael Vetter2020-02-1013-11/+132
| | | | | | | | | | | | | | | | So far the correction is sent. But the UI in Profanity itself is not updated. Also autocompletion for `/correct` with the last sent message is missing.
| * xep-0308: add cons_correction_setting stub to testsMichael Vetter2020-02-101-0/+1
| |
| * xep-0308: make correction.char themeableMichael Vetter2020-02-103-0/+10
| |
| * xep-0308: create setting to toggle lmcMichael Vetter2020-02-107-11/+27
| | | | | | | | and print settings if only `/correction` is run.
| * xep-0308: set correction char in configMichael Vetter2020-02-105-1/+58
| |
| * xep-0308: add `correction` autocompletionMichael Vetter2020-02-104-0/+48
| |
| * xep-0308: Initial support for incoming LMCMichael Vetter2020-02-105-7/+75
|/
* travis: Update icons switchMichael Vetter2020-02-081-2/+2
| | | | Use --enable-icons-and-clipboard instead of old --enable-icons
* Start next development cycleMichael Vetter2020-02-071-1/+1
|
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-07-12 10:30:22 +0000