about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
* fix display of a "list type" in a form if there's no value assigned yetSteffen Jaeckel2023-04-041-27/+21
| | | | | | | | | | | | | | | | | | | | | It is possible, that a server sends a form with a field as follows, which has no (default) value assigned. ``` <field label="foo" type="list-single" var="bar"> <option label="a"><value>a</value></option> <option label="b"><value>b</value></option> <option label="c"><value>c</value></option> </field> ``` This patch fixes profanity to show that list. Before this patch profanity showed nothing. I stumbled over this while running the `/room config` command inside a newly created muc on the `sure.im` XMPP server. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* refactor into array of a `struct`Steffen Jaeckel2023-04-041-5/+15
| | | | | | ...instead of having two separate arrays. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* only create hashtable onceSteffen Jaeckel2023-04-041-72/+74
| | | | | | | Before this change the same hashtable was re-created each time one used the auto-completion feature. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* fix memory leakSteffen Jaeckel2023-04-041-9/+8
| | | | | | | | `found` was leaked before This was somehow missed in e9aaba938b4f1b62b5f9018583a82ed7e7180977 Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Merge pull request #1811 from shahab-vahedi/batman-fixMichael Vetter2023-04-031-2/+2
|\ | | | | Fix color name in batman theme
| * themes/batman: Use "bold_black" iso "black_bold"Shahab Vahedi2023-04-031-2/+2
| | | | | | | | | | | | | | | | | | | | This makes all the related errors in the log files go away: ... prof: ERR: Color: bad color name black_bold_default prof: ERR: Unable to load colour theme ... Fixes https://github.com/profanity-im/profanity/issues/1810
* | Fix typosMichael Vetter2023-04-034-4/+4
| |
* | Merge pull request #1808 from ↵Michael Vetter2023-04-032-1/+5
|\ \ | | | | | | | | | | | | MarcoPolo-PasTonMolo/fix/empty_window_after_reconnect Fix empty window after reconnect
| * | Fix empty window after reconnectMarcoPolo-PasTonMolo2023-04-022-1/+5
| |/ | | | | | | | | | | | | | | Sometimes after a reconnect the current window would get cleared. This was a deliberate change to fix the profanity window looking all garbled up after providing the passphrase for a gpg key using pinentry-curses. Fixes https://github.com/profanity-im/profanity/issues/1556
* | Merge pull request #1809 from MarcoPolo-PasTonMolo/fix/no-ac-for-reconnect-nowMichael Vetter2023-04-031-0/+16
|\ \ | | | | | | Add autocomplete for the /reconnect command
| * | Add autocomplete for the /reconnect commandMarcoPolo-PasTonMolo2023-04-021-0/+16
| |/ | | | | | | | | After typing `/reconnect ` and pressing tab nothing appeared where in reality, it should have been autocompleted to `/reconnect now`
* | Merge pull request #1807 from alexandre1985/fix/typosMichael Vetter2023-04-034-5/+8
|\ \ | |/ |/| Fix typos and add codespell configuration
| * Fix typos and update codespell configurationDaniel Santos2023-04-034-5/+8
|/ | | | | | | | | | * Fix typos. * Add words that are not typos to codespell's ignore words list and ignore regex. * Make codespell ignore URIs. * Make `make doublecheck` throw no error. Signed-off-by: Daniel Santos <dacs.git@brilhante.top>
* Merge pull request #1801 from alexandre1985/editor-with-argumentsMichael Vetter2023-03-312-2/+8
|\ | | | | Editor executable support flags
| * Add editor executable to CMD_SYNDaniel Santos2023-03-311-0/+1
| | | | | | | | | | | | * Add missing text of how to set editor in CMD_SYN Signed-off-by: Daniel Santos <dacs.git@brilhante.top>
| * Editor executable support flagsDaniel Santos2023-03-302-2/+7
| | | | | | | | | | | | | | | | * Make editor executable into a string to be able to support (multiple) flags. * Change /help executable to suit this new feature Signed-off-by: Daniel Santos <dacs.git@brilhante.top>
* | Fix headings in contributing.mdMichael Vetter2023-03-311-2/+2
| |
* | Merge pull request #1802 from H3rnand3zzz/pgp-fixMichael Vetter2023-03-314-17/+10
|\ \ | |/ |/| Security fix of OTR, PGP and other
| * Fix OTRJohn Hernandez2023-03-311-4/+0
| | | | | | | | Fix OTR: carbon in stanza breaks OTR and prevents it from starting and working properly.
| * Fix PGPJohn Hernandez2023-03-313-13/+10
|/ | | | Fix of PGP and potentially other encryption methods by calling correct function that would initiate them in case if someone writes.
* Merge pull request #1800 from profanity-im/switchMichael Vetter2023-03-233-33/+39
|\ | | | | Improve some UI functions
| * Add WIN_VCARD to win_get_tab_identifier()Michael Vetter2023-03-231-0/+4
| | | | | | | | | | | | Thanks to 12b997c5f34776f34634d4ca155a14586aebc905 we already found a place where we should add this missing window type. AFAIK there can be only one vcard window.
| * Adapt to new g_string_free() usageMichael Vetter2023-03-232-13/+4
| | | | | | | | | | Somehow this must have been overlooked when doing e59c401c840f379e64945734969db03b0e55ef22.
| * ui: make it easier to find non covered window typesMichael Vetter2023-03-231-20/+31
|/ | | | | | | | | | | | | | | | Rewrite `win_get_title()` to using switch without a default case. So the compiler warns us (`enumeration value ‘WIN_XXX’ not handled in switch`) in case we add a new window type (WIN_CHAT, WIN_PRIV etc) and forget to adapt this function. Add assert() in the end to make compiler happy when he realizes there the function might have no return value (`control reaches end of non-void function`). This should ever be reached. Replace the default value of `win_to_string()`, `win_get_tab_identifier()` as well, and replace it with an assert. See discussion started at https://github.com/profanity-im/profanity/pull/1799#discussion_r1142444684
* Merge pull request #1799 from profanity-im/glib276gsfMichael Vetter2023-03-2217-145/+42
|\ | | | | Adapt to g_string_free glib 2.75.3 change
| * Adapt to g_string_free glib 2.75.3 changeMichael Vetter2023-03-2117-145/+42
|/ | | | | | | | | | | | glib 2.75.3 changes warning behaviour of `g_string_free()`. See: * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3219 * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3226 Use this opportunity to replace the use of GString with `g_strdup_printf()` where possible. Otherwise correctly take the return value of `g_string_free()` which is nicer anyways.
* Merge pull request #1796 from profanity-im/minor-improvementsMichael Vetter2023-03-137-46/+54
|\ | | | | Minor improvements
| * change OMEMO QR code `0` bits to 'space'Steffen Jaeckel2023-03-121-2/+6
| | | | | | | | | | | | This makes the generated QR code a lot better recognizable in my case. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * fix #1797Steffen Jaeckel2023-03-121-1/+1
| | | | | | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * fix #1761 by changing the implementation from recursiveSteffen Jaeckel2023-03-111-23/+22
| | | | | | | | | | | | ... to an iterative approach Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * add test-case for #1761Steffen Jaeckel2023-03-113-0/+24
| | | | | | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * simplify some codeSteffen Jaeckel2023-03-111-5/+1
| | | | | | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * remove compat codeSteffen Jaeckel2023-03-111-15/+0
|/ | | | | | We already depend on libstrophe >= 0.12, so this code can go. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Correct ML URL in SPONSORS.mdMichael Vetter2023-03-101-1/+1
|
* Merge pull request #1795 from IsaacM88/masterMichael Vetter2023-03-1012-28/+43
|\ | | | | Fix duplicate download IDs when using "/url save"
| * Fix duplicate download IDs.IsaacM882023-03-0912-28/+43
| | | | | | | | | | | | | | | | | | | | Fixes https://github.com/profanity-im/profanity/issues/1794 Explanation The problem is the download's identifier. Downloads are given an ID so they can be referenced later when their progress changes. Currently, the download's ID is the download's URL. When you download the same file twice, you have two downloads with the same ID. Download progress updates are shown on the first of both downloads with the same ID. Solution Change the download's ID from its URL to a random number. A random ID is generated when get_random_string() is called from cmd_funcs.c. Several other functions are updated to cope with the new ID format.
* | Update sponsorsMichael Vetter2023-03-011-5/+1
| | | | | | | | Thanks again guys!
* | Update to new mailing listMichael Vetter2023-03-013-4/+4
|/ | | | Maintained by https://github.com/StefanKropp
* cmd: Update MAM helpMichael Vetter2023-02-151-2/+2
|
* Merge pull request #1789 from MarcoPolo-PasTonMolo/fix/autocompletion_after_MAMMichael Vetter2023-02-158-20/+41
|\ | | | | Fix quote and url autocompletion for MAM and history
| * Fix quote and url autocompletion for MAM and historyMarcoPolo-PasTonMolo2023-02-138-20/+41
| | | | | | | | | | | | | | | | After adding MAM quote and url autocompletion wouldn't pick up messages from MAM or history(from DB) or would have them in the wrong order. This commit fixes that. Fixes https://github.com/profanity-im/profanity/issues/1770
* | Merge pull request #1791 from ↵Michael Vetter2023-02-151-4/+4
|\ \ | |/ |/| | | | | MarcoPolo-PasTonMolo/fix/MAM_not_loading_recent_messages Fix MAM not loading some recent messages
| * Fix MAM not loading some recent messagesMarcoPolo-PasTonMolo2023-02-141-4/+4
|/ | | | | Reverse a small change from commit e886ba0 that caused this issue. Fixes https://github.com/profanity-im/profanity/issues/1790
* Merge pull request #1788 from profanity-im/minor-improvementsMichael Vetter2023-01-302-9/+13
|\ | | | | Minor improvements
| * prevent setting invalid combination of libstrophe flagsSteffen Jaeckel2023-01-271-2/+10
| | | | | | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * simplify some codeSteffen Jaeckel2023-01-261-4/+2
| | | | | | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * fix libstrophe timer-callback usageSteffen Jaeckel2023-01-261-3/+1
| | | | | | | | | | | | | | The timer will be auto-removed if the callback returns `0`. The way it was done before breaks some internals of libstrophe. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* | Merge pull request #1786 from thexhr/develMichael Vetter2023-01-304-5/+11
|\ \ | |/ |/| Don't pass NULL pointers to vprintf
| * Remove space to match clang coding stylethe xhr2023-01-261-1/+1
| |
| * Add macro for possible NULL prints and use it on known sportsthe xhr2023-01-264-5/+11
| | | | | | | | | | The macro is effective on OpenBSD and basically a no op on other platforms. Use it for one existing and the other known debug statements.