| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
introduced in 8d3c1f79ac7cc2b0830f0afed48dc1fb9008ab0e
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
|
|
|
|
|
| |
global `CFLAGS` were ignore before
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
|\
| |
| | |
Cleanup: gchar as gchar instead of char
|
| |\
| |/
|/| |
|
|\ \
| | |
| | | |
Minor improvements
|
| | |
| | |
| | |
| | | |
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This fixes #1846
Issue introduced by a0aa26b6fa65ba625f4a6d3495a345c7120ff16d
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There were multiple reports where after a reconnect the window of the
MUC that was last opened, was empty.
`muc_join()` creates an instance of a MUC, `presence_join_room()` works
with this instance. Therefore the instance has to exist before working on
it.
I'm not sure if this really fixes the issue, but at least it didn't
happen anymore after I applied this modification.
I can't remember how I stumbled over this, either while looking at debug
logs or while looking at Valgrind output while a reconnect happened, but
something went wrong. Then I came to the conclusion that this may fix
the issue and for now it did ... maybe it comes back, then my RCA was
wrong.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
|\ \ \
| |/ /
|/| | |
Improvements for /executable and /avatar code
|
| | |
| | |
| | |
| | |
| | |
| | | |
Each of the cmd_executable_editor(), cmd_executable_urlopen() etc calls
this helper function since they were all doing the same just for
different configurations.
|
| | |
| | |
| | |
| | |
| | | |
We autocompleted `/executable` to `avatar`, `vcard_photo`, `editor` etc.
But didn't autocomplete the next parameter. Namely `set` and `default`.
|
| | |
| | |
| | |
| | |
| | | |
All the other commands (avatar, vcard_photo, urlsave, urlopen) have the
ability to reset to default already.
|
| | |
| | |
| | |
| | | |
Was forgotten in f934c5b59.
|
| | |
| | |
| | |
| | |
| | |
| | | |
`/executable avatar` now also uses cmdtemplate and parse %p.
It seems to me that the `/avatar` command was actually completely broken
on master.
|
| | |
| | |
| | |
| | |
| | |
| | | |
This is done in `/executable avatar set` since d7848e38b.
The command help also didn't mention this anymore.
Seems like it was forgotten to remove the actual parsing of this.
|
| |/
|/|
| |
| |
| |
| |
| |
| | |
Use gchar instead of char in most of the cases where gchar is intended.
Reason: improve compatibility and stability. Issue #1819
Minor refactoring.
|
|\|
| |
| | |
Add ability to disable avatar publishing
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add "/avatar disable" to comply with point "3.5 Publisher Disables
Avatar Publishing" in XEP-0084.
src/command/cmd_defs.c:2416
Add "disable" argument. Reword the "/avatar" command description
so it flows better.
src/command/cmd_ac.c:1101
Add "disable" to the "/avatar" autocomplete dictionary.
src/command/cmd_funcs.c:9277
Split "/avatar" commands into two groups with an if statement; those
with a parameter and those without. "cons_bad_cmd_usage()" is in both
groups, which is messy. "disable" has similar logic to "set", but it
includes a failure message.
src/xmpp/avatar.c:152
"avatar_publishing_disable()" uses the same logic to publish metadata
as in "avatar_set()".
src/xmpp/avatar.c:238
Add a message to inform users when they do not receive an avatar after
using "/avatar get" and "/avatar open". In case of a failure, the user
will be subscribed to future avatar updates as long as they continue
to use their current instance of profanity. Adding
"caps_remove_feature()" after "cons_show()" will unsubscribe the user
from avatar updates and prevent the user from downloading an avatar
unexpectedly hours later without issuing an "/avatar" command.
src/xmpp/stanza.c:2698
The new "disable" function follows the same logic as
"stanza_create_avatar_metadata_publish_iq()".
|
|\
| |
| | |
Improve OMEMO messages
|
| | |
|
|\ \
| | |
| | | |
Fix `/plugins update`
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before it tried to unload the plugin first and check the output.
But if broken plugin was loaded, then it couldn't unload it,
so before it require uninstall and install after it,
making update useless for plugin development purposes.
Unload is part of the uninstall so no unload is needed inside of the cmd function.
Refactoring of cmd_plugins_update.
|
|\ \
| |/
|/| |
Fix two recently introduced memleaks
|
| |
| |
| |
| | |
Introduced in 59b99fece.
|
|/
|
|
| |
Got introduced with 5d3c8ce7c.
|
|\
| |
| | |
Fix crash, add consistency to logging
|
| |
| |
| |
| |
| |
| |
| | |
Since MUC private messages are not logged by design,
part where this logging happening is removed to add consistency.
Add explanation in comment.
|
|/
|
|
|
|
| |
Fix crash caused by `/log level` command.
Minor refactoring of command function.
|
|\
| |
| | |
New Feature: Session Alarm
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Introduce new feature: sessions_alarm.
Added new account setting: max_connections. On exceeding this number,
user will get an alert. If number is less than 1, no alert will happen.
Tests altered to fit new feature.
|
|\ \
| | |
| | | |
Don't add the same command twice to history
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Expected behaviour
When you type
/command
/command
it should be just 1 entry in the history.
Behaviour
All the entries were saved.
Behaviour is changed by introducing check. Before adding to history,
entry now is compared to the last history entry.
|
| |
| |
| |
| |
| |
| |
| | |
Let's just define some basic terminology.
In many sections of the /help we actually use these terms.
This should help new users understand what they mean.
|
|\ \
| | |
| | | |
Add encryption section to man page
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
The goal should be that users can make a more informed decision about
which encryption they actually want to use.
We can also use this to document usage details of implementation quirks,
if any.
|
|\ \
| | |
| | | |
Add spellcheck to CI
|
| | | |
|
|/ /
| |
| |
| |
| | |
Make this clear to new users. Since sjaeckel had reservations
on https://github.com/profanity-im/profanity/pull/1828.
|
|\ \
| |/
|/| |
Use GH action for code style check
|
| | |
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
| |
Instead of running clang-format outselves on the old Ubuntu version.
This let's us easily configure which version of clang-format we want to
execute.
Used action:
https://github.com/marketplace/actions/clang-format-check
Properly fix:
https://github.com/profanity-im/profanity/pull/1774
|
| |
|
|\
| |
| | |
Fix memory corruption crash
|
| |
| |
| |
| |
| |
| | |
In OX implementation gpgme's buffer remains untouched, thus not leading to the crash.
But code can be shorter and more concise.
|
| |
| |
| |
| |
| |
| |
| | |
Under certain circumstances setting plain_str[len] to 0 might lead to crash
and it does not follow the best practices as well.
This change allows better handling of buffer copying and prevents crash.
|
|\ \
| |/
|/| |
Add nickname support for `/roster remove`
|
|/
|
|
|
|
| |
Add support of name/nickname instead of only JID for `/roster remove` command.
Add tests for it as well.
|