about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix invalid read in muc codeMichael Vetter2019-10-061-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We didn't set the variables to NULL, but the rest of the code depends on this check. ``` ==22201== Invalid read of size 8 ==22201== at 0x44E560: autocomplete_clear (autocomplete.c:69) ==22201== by 0x427B2C: muc_invites_clear (muc.c:190) ==22201== by 0x461328: ev_disconnect_cleanup (common.c:59) ==22201== by 0x463FB5: cl_ev_disconnect (client_events.c:91) ==22201== by 0x431252: cmd_disconnect (cmd_funcs.c:1234) ==22201== by 0x47E883: clears_chat_sessions (test_cmd_disconnect.c:28) ==22201== by 0x487E9E1: _run_test (in /usr/lib64/libcmocka.so.0.7.0) ==22201== by 0x487ECCC: _run_tests (in /usr/lib64/libcmocka.so.0.7.0) ==22201== by 0x47F1BE: main (unittests.c:629) ==22201== Address 0x814b690 is 0 bytes inside a block of size 24 free'd ==22201== at 0x48379AB: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==22201== by 0x44E5F7: autocomplete_free (autocomplete.c:90) ==22201== by 0x4278A0: muc_close (muc.c:97) ==22201== by 0x47DBAA: cmd_join_uses_password_when_supplied (test_cmd_join.c:169) ==22201== by 0x487E9E1: _run_test (in /usr/lib64/libcmocka.so.0.7.0) ==22201== by 0x487ECCC: _run_tests (in /usr/lib64/libcmocka.so.0.7.0) ==22201== by 0x47F1BE: main (unittests.c:629) ==22201== Block was alloc'd at ==22201== at 0x483677F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==22201== by 0x44E51B: autocomplete_new (autocomplete.c:57) ==22201== by 0x427837: muc_init (muc.c:88) ==22201== by 0x47DA77: cmd_join_uses_password_when_supplied (test_cmd_join.c:154) ==22201== by 0x487E9E1: _run_test (in /usr/lib64/libcmocka.so.0.7.0) ==22201== by 0x487ECCC: _run_tests (in /usr/lib64/libcmocka.so.0.7.0) ==22201== by 0x47F1BE: main (unittests.c:629) ```
* Fix memleak in cmd_joinMichael Vetter2019-10-061-0/+5
| | | | | | Free `room` string in case we allocated it ourselves. Regards https://github.com/profanity-im/profanity/issues/1019
* Free strings in all cases in cmd_roomsMichael Vetter2019-10-061-0/+3
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Free strings in test_cmd_aliasMichael Vetter2019-10-061-0/+4
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Free lits in test_cmd_roster unittestMichael Vetter2019-10-061-0/+4
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Remove not needed strdupin test_cmd_roomsMichael Vetter2019-10-061-2/+3
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Free autocomplete_complete results in unittestMichael Vetter2019-10-061-1/+19
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Fix autocomplete memleak in test_autocompleteMichael Vetter2019-10-061-16/+16
| | | | | | | autocomplete_free() calls autocomplete_clear() and then frees the struct itself. Regards https://github.com/profanity-im/profanity/issues/1019
* Free list in error case in parse_optionsMichael Vetter2019-10-061-0/+3
| | | | | | Fix memleaks. Regards https://github.com/profanity-im/profanity/issues/1019
* Free lists in test_roster_listMichael Vetter2019-10-061-0/+20
| | | | | Fix memleaks. Regards https://github.com/profanity-im/profanity/issues/1019
* Fix two memleaks in test_parserMichael Vetter2019-10-061-0/+4
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Fix memleak in cmd_bookmark_list_shows_bookmarks unittestMichael Vetter2019-10-061-0/+16
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Fix memleak in test_parser unittestMichael Vetter2019-10-061-0/+2
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Fix memleak in test_callbacks unittestMichael Vetter2019-10-061-0/+2
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Fix memleak in test_parser unittestMichael Vetter2019-10-061-1/+7
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Fix memleak in get_start()Michael Vetter2019-10-061-0/+1
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Destroy hash table ein autocompleters_destroy()Michael Vetter2019-10-061-0/+3
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Free options in error case for cmd_connect()Michael Vetter2019-10-061-0/+5
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Fix test_callbacks memleakMichael Vetter2019-10-061-0/+5
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Fix test_jid unittest memleakMichael Vetter2019-10-061-0/+29
| | | | Regards https://github.com/profanity-im/profanity/issues/1019
* Fix unittest memleak in test_cmd_joinMichael Vetter2019-10-051-0/+8
| | | | | | muc_init() call without muc_close() Regards https://github.com/profanity-im/profanity/issues/1019
* Fix preferences memory leakMichael Vetter2019-10-051-0/+4
| | | | | | Memory leak detected through unit tests. Regards https://github.com/profanity-im/profanity/issues/1019
* Add /clear autocompletion and improve helpMichael Vetter2019-10-053-6/+60
| | | | | | | | | | | Regards https://github.com/profanity-im/profanity/issues/855 https://github.com/profanity-im/profanity/pull/874 brought us the `/clear` command. The author of that patch couldn't follow up with the review boothj5 did. So the autocompletion and updated help was missing. This commit adds it.
* Merge pull request #874 from spiridoncha/masterMichael Vetter2019-10-053-1/+13
|\ | | | | Change /clear behaviour. Closes issue #855.
| * Makes /clear behavior configurable.Spiridonov Alexander2016-11-073-0/+9
| |
| * Change /clear behaviour. Closes issue #855.Spiridonov Alexander2016-10-221-1/+4
| |
* | Merge remote-tracking branch 'philipflohr/master'Michael Vetter2019-10-051-10/+3
|\ \
| * | Don't stop plugin installation if given path points to a directoryPhilip Flohr2019-02-261-11/+3
| | | | | | | | | | | | | | | | | | | | | The command "/plugins install <path_to_folder> should install all plugins in the given folder. This commit removes the check if the path points to a file (which is repeated in the section installing a plugin from file) and makes the existing code installing multiple plugins accessible
* | | Check errors in is_dir() is_regular_file()Michael Vetter2019-10-041-2/+10
| | | | | | | | | | | | | | | | | | | | | In case of error print the error. And return right value. Improvement based on @pasis advice in https://github.com/profanity-im/profanity/pull/1036 Applying in preparation to merge that PR.
* | | Introduce /reload commandMichael Vetter2019-10-045-18/+58
| | | | | | | | | | | | | | | | | | This command reloads the configuration file. Fix https://github.com/profanity-im/profanity/issues/627
* | | Log outgoing carbons instead of incomingMichael Vetter2019-10-041-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | Incoming carbons are logged as normal message already. So we had this logged twice but didn't log outgoing carbons, send from our account but by another client, at all. Fix https://github.com/profanity-im/profanity/issues/1181
* | | Merge pull request #1200 from mzagozen/masterMichael Vetter2019-10-011-1/+1
|\ \ \ | | | | | | | | Include $PYTHON_EXTRA_LIBS in libtool config
| * | | Include PYTHON_EXTRA_LIBS in libtool configMarko Zagožen2019-10-011-1/+1
|/ / / | | | | | | | | | Fixes compilation when using custom Python installed with pyenv.
* | | Update version in spec fileMichael Vetter2019-09-301-1/+1
| | |
* | | Mention XEP-0191 in blocked commandMichael Vetter2019-09-301-1/+1
| | |
* | | Document how to block users in MUCsMichael Vetter2019-09-301-2/+4
| | | | | | | | | | | | Regards https://github.com/profanity-im/profanity/issues/618
* | | Bind key to switch to next active windowMichael Vetter2019-09-303-0/+41
| | | | | | | | | | | | | | | | | | alt-a brings one to the next window with unread messages. Regards https://github.com/profanity-im/profanity/issues/1114
* | | Define keybindings to switch to up to 20 windowsMichael Vetter2019-09-301-0/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | alt-2 brings one ot the window. irssi supports alt + 1234567890qwertyuio to easily switch to 20 windows instead of just ten. Hardcode this too. Regards https://github.com/profanity-im/profanity/issues/1114
* | | Detect MUC history correctly with some Prosody versionsMichael Vetter2019-09-301-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some versions of prosody send the domainpart. See https://issues.prosody.im/1416 Workaround to handle those cases. Thanks to Holger Weiss for helping with this! Fix https://github.com/profanity-im/profanity/issues/1190
* | | Remove not needed codeMichael Vetter2019-09-291-4/+0
| | | | | | | | | | | | Was left over from refactoring a long time ago.
* | | Add comment about statusbar.currentMichael Vetter2019-09-291-0/+3
| | |
* | | Add statusbar.current to templateMichael Vetter2019-09-291-0/+1
| | |
* | | Fix typo conact -> contactMichael Vetter2019-09-291-4/+4
| | |
* | | Use helper function for cmd_statusMichael Vetter2019-09-291-15/+13
| | |
* | | Allow pasing a jid to info command in chat windowMichael Vetter2019-09-291-12/+18
| | | | | | | | | | | | | | | | | | | | | If we pass a jid/nick to `/info` in a chat window we will still get the output. But on the console window. Regards https://github.com/profanity-im/profanity/issues/1194
* | | Allow pasing a jid to status command in chat windowMichael Vetter2019-09-291-2/+10
| | | | | | | | | | | | Regards https://github.com/profanity-im/profanity/issues/1194
* | | Merge pull request #1199 from mdosch/masterMichael Vetter2019-09-251-3/+3
|\ \ \ | | | | | | | | Fix solarized dark theme
| * | | Fix solarized dark thememdosch2019-09-251-3/+3
|/ / / | | | | | | | | | | | | This fixes a whitespace issue that was probably introduced by using the github editor.
* | | Merge pull request #1198 from mdosch/patch-6Michael Vetter2019-09-251-2/+3
|\ \ \ | | | | | | | | Update theme solarized dark
| * | | Update theme solarized darkMartin2019-09-251-2/+3
|/ / / | | | | | | | | | The theme `solarized dark` is updated to play well with the newly added `statusbar.active` from #1195