about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
...
| * ox: only process proper messagesMichael Vetter2022-05-041-12/+11
| | | | | | | | | | | | | | | | | | | | We only want to have the decrypted message or the alternative body in message->plain. Also let's print error messages if it makes sense and log other issues. Partly addresses the commit in the comit mesage of: 2dc0cc489c872941e18a622c091f74bf5b0b043f
| * ox: prefix function _openpgp_signcrypt with ox_Michael Vetter2022-05-041-3/+3
|/ | | | To make the destinction clearer and easier to search.
* ox: have metadata node openMichael Vetter2022-05-041-0/+6
| | | | | | | Should have been done alogn with e9f218cdf6e15f4469d77cbaee59cc8501ed4e82. Like this people who are not in the roster can get our public key and write messages to use.
* ox: return upon invalid fingerprintMichael Vetter2022-05-041-1/+2
|
* Merge pull request #1703 from profanity-im/feat/ox-improvements1Michael Vetter2022-05-047-112/+236
|\ | | | | Several OX improvements
| * ox: fix mistakes in p_ox_gpg_decrypt()Michael Vetter2022-05-041-1/+3
| | | | | | | | | | | | | | strcpy() can't work here because the data doesn't have to be NULL-terminated. So let's use memcpy. Fix memleak of plain_str.
| * Improve ox command helpMichael Vetter2022-05-041-2/+3
| | | | | | | | | | Mention new man page. Correct the usage of /ox request.
| * ox: print message when `/ox end` is run but not startedMichael Vetter2022-05-041-4/+8
| |
| * ox: print more error messages to UIMichael Vetter2022-05-031-2/+6
| |
| * ox: dont require marginal trust levelMichael Vetter2022-05-031-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Maybe we can make this configurable later. So users have the freedom to be more strict. This commit partly reverts 62018f48c5f1a0410445fce5bca5fdd6a9e4d907. Example to edit trust level: ``` gpg --edit-key somekeyid gpg (GnuPG) 2.3.4; Copyright (C) 2021 Free Software Foundation, Inc. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. pub rsa4096/keyid created: 2020-06-26 expires: 2022-06-26 usage: SC trust: unknown validity: full sub rsa4096/keyid created: 2020-06-26 expires: 2022-06-26 usage: E [ full ] (1). xmpp:user@domain.de gpg> trust pub rsa4096/keyid created: 2020-06-26 expires: 2022-06-26 usage: SC trust: unknown validity: full sub rsa4096/keyid created: 2020-06-26 expires: 2022-06-26 usage: E [ full ] (1). xmpp:user@domain.de Please decide how far you trust this user to correctly verify other users' keys (by looking at passports, checking fingerprints from different sources, etc.) 1 = I don't know or won't say 2 = I do NOT trust 3 = I trust marginally 4 = I trust fully 5 = I trust ultimately m = back to the main menu Your decision? 3 pub rsa4096/keyid created: 2020-06-26 expires: 2022-06-26 usage: SC trust: marginal validity: full sub rsa4096/keyid created: 2020-06-26 expires: 2022-06-26 usage: E [ full ] (1). xmpp:user@domain.de Please note that the shown key validity is not necessarily correct unless you restart the program. gpg> quit ```
| * Bugfix OX rpad generationStefan Kropp2022-05-031-4/+6
| | | | | | | | | | | | | | | | | | | | ________________________________________ < No comment - should be much better now > ---------------------------------------- \ \ \ >()_ (__)__ _
| * ox_key_is_usable - Logging and owner trust checkStefan Kropp2022-05-031-0/+6
| | | | | | | | | | | | | | * Added logging messages (INFO if key can not be used) * Check owner_trust < GPGME_VALIDITY_MARGINAL The key can not be used if the owner_trust is less than MARGINAL.
| * ox: use glib date function in _gettimestamp and fix memleakMichael Vetter2022-05-031-12/+10
| |
| * ox: Use connection_create_stanza_id() instead of xmpp_uuid_gen()Michael Vetter2022-05-031-4/+4
| |
| * ox: implement `/ox end`Michael Vetter2022-05-031-0/+12
| | | | | | | | We also need to be able to stop an ox conversation :-)
| * ox: use iq_id_handler_add instead of xmpp_id_handler_addMichael Vetter2022-05-031-6/+6
| |
| * ox: use iq_send_stanza instead of xmpp_sendMichael Vetter2022-05-031-4/+10
| |
| * ox: use pubsub acces model open when announce ox public keyMichael Vetter2022-05-031-0/+7
| |
| * Add draft of OX setup manpageMichael Vetter2022-05-031-0/+153
| | | | | | | | | | | | | | | | | | | | | | This man page should help people to set up OX in profanity. We have profanity-ox.1 which is the same as `/help ox` and describes how to use OX. This man page will help with the setup with the external gpg program. Based on the blogpost of Stefan: https://profanity-im.github.io/blog/post/openpgp-for-xmpp-ox/
| * Remove developer notes on OXMichael Vetter2022-05-031-76/+0
|/ | | | | | | | | This was done before OX was implemented. In 0.10 ox landed in Profanity and we have the blogpost: https://profanity-im.github.io/blog/post/openpgp-for-xmpp-ox/ to describe the usage. We will have a man page to help users with the setup as well.
* Restore default behaviour for stampsMichael Vetter2022-05-032-2/+2
| | | | | | | | | | | | @mdosch discovered that we now don't print `:` for messages from others anymore. Until https://github.com/profanity-im/profanity/pull/1663#issuecomment-1114625151 is fixed lets restore the default behaviour to always add `:` in `_win_print_internal()`. The result will be that a stamp set to `-->` will also look like `-->:`.
* Merge pull request #1702 from mdosch/fix-autocomplete-ox-discoverMichael Vetter2022-05-021-1/+1
|\ | | | | Fix autocomplete for `/ox discover`.
| * Fix autocomplete for `/ox discover`.Martin Dosch2022-05-021-1/+1
|/
* ox: add jid autocompletion for /ox requestMichael Vetter2022-05-021-0/+5
|
* contrib: request screenshot upon UI changeMichael Vetter2022-05-021-0/+1
|
* Merge pull request #1701 from profanity-im/log-changesMichael Vetter2022-04-292-11/+16
|\ | | | | Log file improvements
| * Use profanity.001.log instead of profanity.log.001 for rotated logsMichael Vetter2022-04-291-8/+13
| | | | | | | | | | | | | | | | Rotated log files will now be: `.local/share/profanity/logs/profanity.001.log` We only use logrotation if we use the default log file ending with .log. So Replacing the `.` should be fine. User supplied log files are not rotated.
| * Use 3 digits for rotated logfilesMichael Vetter2022-04-291-3/+3
| | | | | | | | profanity.log.001 -> 999.
| * Set default max log size to 10MBMichael Vetter2022-04-291-1/+1
|/ | | | In case logrotate is on.
* Merge pull request #1700 from profanity-im/feat/change-chatlogMichael Vetter2022-04-291-3/+3
|\ | | | | Use ISO8601 as date format in log files
| * Use ISO8601 for log filesMichael Vetter2022-04-291-1/+1
| |
| * Use ISO8601 for chatlogsMichael Vetter2022-04-291-2/+2
| | | | | | | | For both 1:1 and groupchat.
* | Merge pull request #1663 from akaWolf/add_stamp_settingsMichael Vetter2022-04-287-2/+95
|\ \ | |/ |/| Add option to configure incoming/outgoing stamps
| * Merge branch 'master' into add_stamp_settingsMichael Vetter2022-04-2830-325/+636
| |\ | |/ |/|
* | Merge pull request #1697 from cockroach/feature/offline-muc-notificationsMichael Vetter2022-04-289-1/+63
|\ \ | | | | | | Add support for offline MUC notifications
| * | Add support for offline MUC notificationsStefan Ott2022-04-239-1/+63
| | |
* | | Fix ox autocompletionMichael Vetter2022-04-281-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sometimes this happened: `ox d<tab>` → `/ox request` `ox a<tab>` → `/ox request` `ox c<tab>` → `/ox keys` `ox s<tab>` → `/ox keys` `ox e<tab>` → `/ox keys` We didn't reset the ox_*_ac variables.
* | | ox: group online autocompletion togetherMichael Vetter2022-04-281-10/+5
| | |
* | | ox: dont print empty body messageMichael Vetter2022-04-271-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix https://github.com/profanity-im/profanity/issues/1693 ``` @StefanKropp @DebXWoody please check `_handle_ox_chat()` I don't understand what you are doing there. 1) First plain is assigned `message->plain = p_ox_gpg_decrypt(xmpp_stanza_get_text(ox));` and then in the same if block you overwrite this with `message->plain = xmpp_stanza_get_text(b);` without freeing the old value as far as I can see. 2) Sometimes even doing `message->plain = "OX error: No payload found";`. Shouldn't there be a `strdup()`? I think later on we try to free the whole message struct. So we can't mix this static things. ```
* | | Merge pull request #1699 from profanity-im/1698-fixoxabrtMichael Vetter2022-04-272-7/+6
|\ \ \ | | | | | | | | Fix SIGABRT when using wrong argument order for receiving ox key
| * | | ox: print invalid fingerprint instead of abortingMichael Vetter2022-04-271-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Asserting here is not the right thing to do at all. A person could have a typo in the fingerprint. Or like in the case of the reported bug just confuse the arguments. An additional check for valid jid should be added later to the calling function maybe. Fix https://github.com/profanity-im/profanity/issues/1698
| * | | ox: print bad usage instead of custom messageMichael Vetter2022-04-271-1/+1
| | | |
| * | | Remove commentMichael Vetter2022-04-271-5/+0
| |/ /
* | | ci: rename TW python packagesMichael Vetter2022-04-271-2/+2
| | |
* | | ox: remove commentMichael Vetter2022-04-271-4/+0
|/ /
* | Merge pull request #1696 from paulfertser/fix-xscreensaver-configureMichael Vetter2022-04-211-1/+2
|\ \ | | | | | | Fix xscreensaver detection
| * | Fix xscreensaver detectionPaul Fertser2022-04-211-1/+2
|/ / | | | | | | | | | | | | Using pkg-config to find libraries requires explicit mention of the relevant _CFLAGS and _LIBS variables. Fixes #1695.
* | Fix typo Annonuce -> AnnounceMichael Vetter2022-04-141-4/+4
| |
* | Fix typo: paylod -> payloadMichael Vetter2022-04-121-1/+1
| |
* | Merge pull request #1690 from paulfertser/symbol-for-embedded-newlinesMichael Vetter2022-04-122-11/+41
|\ \ | | | | | | Show return symbol for embedded newlines
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-12-04 11:33:06 +0000