| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Code below explicitly refers past `args_len`th element:
c_arguments[args_len][0] = NULL;
c_arguments[args_len][1] = NULL;
Let's always allocate space for `NULL`. Noticed by Steffen Jaeckel.
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc-12 detects redundant check against array of arrays as:
src/plugins/python_api.c: In function ‘python_api_register_command’:
src/plugins/python_api.c:199:31: error: the comparison will always evaluate as ‘true’ for the address of ‘c_arguments’ will never be NULL [-Werror=address]
199 | while (c_arguments[i] != NULL && c_arguments[i][0] != NULL) {
| ^~
src/plugins/python_api.c:161:15: note: ‘c_arguments’ declared here
161 | char* c_arguments[args_len == 0 ? 0 : args_len + 1][2];
| ^~~~~~~~~~~
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc-12 detects redundant check against array of arrays as:
src/plugins/callbacks.c: In function ‘_free_command_help’:
src/plugins/callbacks.c:85:26: error: the comparison will always evaluate as ‘true’ for the address of ‘args’ will never be NULL [-Werror=address]
85 | while (help->args[i] != NULL && help->args[i][0] != NULL) {
| ^~
In file included from ./src/ui/ui.h:44,
from ./src/command/cmd_defs.h:42,
from src/plugins/callbacks.c:41:
./src/command/cmd_funcs.h:48:12: note: ‘args’ declared here
48 | gchar* args[128][2];
| ^~~~
|
| |
|
|
|
|
|
| |
Change all instances of *get_nick_from_roster to *get_name_from_roster
to match the convention of names in the roster itself.
|
| |
|
|
|
|
| |
Related to https://github.com/profanity-im/profanity/issues/1512
|
| |
|
|
|
|
| |
We require c99/gnu99 anyways.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we receive a message we get:
<< room message: eagle@conference.anoxinon.me (win 2)
Same for private chats and regular chats.
And several other kinds of notifications.
If we only receive notifications from a chat window it would be nice to
also clear the hilight on the console window since we already catched up
by reading the actual message in the chat window.
Probably not the best description :-) I hope you get it..
Regards https://github.com/profanity-im/profanity/issues/1399
|
| |
|
|
|
|
|
|
| |
This reverts commit 9b55f2dec0ea27a9ce4856e303425e12f866cea2.
Sorting the includes creates some problems.
|
|
|
|
| |
Regards https://github.com/profanity-im/profanity/issues/1396
|
|
|
|
|
|
| |
"base" was not really base but the filename :-)
Fix https://github.com/profanity-im/profanity/issues/1362
|
|
|
|
|
| |
Is usefult in many cases if we want cleaner code.
Hope this edit didn't break anything though ;-)
|
|
|
|
| |
Fix https://github.com/profanity-im/profanity/issues/1264
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ncursesw defines _XOPEN_SOURCE macro via command-line. In particular, it
is defined in ncursesw.pc and extracted via pkg-config. From other side,
Python defines the same macro unconditionally in pyconfig.h. Python-3.x
defines the macro with value different than ncursesw does. In turn, this
causes a warning that the macro is redefined. And warnings are treated
as errors.
Since both entities define the mecro unconditionally, we can't simply
reorder headers as Python developers suggest. So, undefine the macro
just before the <Python.h> to fix this silly issue.
|
| |
|
|
|
|
| |
Regards https://github.com/profanity-im/profanity/issues/1019
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Probably missing copy of body to plain in carbon and privmessage.
Only covers the incoming message path because goal is OMEMO decryption
of untrusted message.
Cover some of the log functions but not all.
|
|
|
|
|
|
| |
In case Python or C plugins are disabled install/load failed silently.
Notify the user that we can't load them because profanity was built
without support for plugins.
|
|
|
|
|
|
| |
We try to decrypt all messages, if it's successful we use
sv_ev_incoming_message even for OMEMO messages. We pass an OMEMO
boolean to let UI be aware that message were encrypted.
|
|\
| |
| | |
Fail plugin unloading if plugin does not exist
|
| | |
|
|\ \
| | |
| | | |
let plugins_unload_all fail if one plugin unload operation fails
|
| |/ |
|
| | |
|
| |
| |
| |
| | |
Fixes problems found in PR #999
|
| | |
|
| | |
|
| |
| |
| |
| | |
therefore installation will fail. -> The unload code is not needed
|
| | |
|
|/ |
|
| |
|
| |
|
| |
|
|
|
|
| |
issue #956
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|