about summary refs log tree commit diff stats
path: root/src/tools
Commit message (Collapse)AuthorAgeFilesLines
* Fix memleaks & more auto-freeSteffen Jaeckel2023-05-121-15/+5
| | | | | | | | | | | | | | | | | | | | | | | | | `data_dir` would have been leaked if directory creation failed. `editor_argv` was leaked at some point, no idea why. ``` ==1244734== 118 (32 direct, 86 indirect) bytes in 1 blocks are definitely lost in loss record 6,299 of 7,824 ==1244734== at 0x4846CC3: realloc (vg_replace_malloc.c:1451) ==1244734== by 0x5E85AD0: g_realloc (in /usr/lib/libglib-2.0.so.0.7600.1) ==1244734== by 0x5E4A004: ??? (in /usr/lib/libglib-2.0.so.0.7600.1) ==1244734== by 0x5E4A7B1: g_ptr_array_add (in /usr/lib/libglib-2.0.so.0.7600.1) ==1244734== by 0x5EA4235: g_strsplit (in /usr/lib/libglib-2.0.so.0.7600.1) ==1244734== by 0x1F143C: get_message_from_editor (editor.c:92) ==1244734== by 0x193F6B: _inp_rl_send_to_editor (inputwin.c:950) ==1244734== by 0x614642F: _rl_dispatch_subseq (readline.c:916) ==1244734== by 0x6146C85: _rl_dispatch_callback (readline.c:823) ==1244734== by 0x616739F: rl_callback_read_char (callback.c:241) ==1244734== by 0x1923DB: inp_readline (inputwin.c:188) ==1244734== by 0x149860: prof_run (profanity.c:117) ==1244734== by 0x2283E8: main (main.c:186) ``` Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Cleanup: gchar as gchar instead of charJohn Hernandez2023-05-042-5/+3
| | | | | | | | Use gchar instead of char in most of the cases where gchar is intended. Reason: improve compatibility and stability. Issue #1819 Minor refactoring.
* fix memory leakSteffen Jaeckel2023-04-041-9/+8
| | | | | | | | `found` was leaked before This was somehow missed in e9aaba938b4f1b62b5f9018583a82ed7e7180977 Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Editor executable support flagsDaniel Santos2023-03-301-1/+6
| | | | | | | | * Make editor executable into a string to be able to support (multiple) flags. * Change /help executable to suit this new feature Signed-off-by: Daniel Santos <dacs.git@brilhante.top>
* Adapt to g_string_free glib 2.75.3 changeMichael Vetter2023-03-212-11/+2
| | | | | | | | | | | | glib 2.75.3 changes warning behaviour of `g_string_free()`. See: * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3219 * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3226 Use this opportunity to replace the use of GString with `g_strdup_printf()` where possible. Otherwise correctly take the return value of `g_string_free()` which is nicer anyways.
* Fix duplicate download IDs.IsaacM882023-03-096-19/+24
| | | | | | | | | | Fixes https://github.com/profanity-im/profanity/issues/1794 Explanation The problem is the download's identifier. Downloads are given an ID so they can be referenced later when their progress changes. Currently, the download's ID is the download's URL. When you download the same file twice, you have two downloads with the same ID. Download progress updates are shown on the first of both downloads with the same ID. Solution Change the download's ID from its URL to a random number. A random ID is generated when get_random_string() is called from cmd_funcs.c. Several other functions are updated to cope with the new ID format.
* Fix quote and url autocompletion for MAM and historyMarcoPolo-PasTonMolo2023-02-132-3/+8
| | | | | | | | After adding MAM quote and url autocompletion wouldn't pick up messages from MAM or history(from DB) or would have them in the wrong order. This commit fixes that. Fixes https://github.com/profanity-im/profanity/issues/1770
* fix more memory leaksSteffen Jaeckel2023-01-181-1/+1
| | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* minor changesSteffen Jaeckel2023-01-181-40/+9
| | | | | | | | | | | * fix typo * less code duplication * less `GString` usage * more `auto_gchar` usage * document connecting to servers supporting SASL ANONYMOUS * ignore valgrind output Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Update copyright yearMichael Vetter2023-01-106-6/+6
|
* Spawn external programs asynchronouslyMarouane L2022-10-122-2/+2
| | | | | | | | Drawback is that we can't check the exitcode anymore. But we were unsure why/when we need this, see: https://github.com/profanity-im/profanity/pull/1760/files#r980868708 Fixes https://github.com/profanity-im/profanity/issues/1759
* Tell user where the downloaded file is storedSteffen Jaeckel2022-09-071-2/+2
| | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Include common.h and xmpp.h in editor.cMichael Vetter2022-06-281-0/+2
| | | | That was pulled in through log.h
* Include xmpp.h in bookmark_ignore.cMichael Vetter2022-06-281-0/+2
| | | | That was pulled in through log.h
* Improve cmd argument parserMarcoPolo-PasTonMolo2022-06-161-3/+12
| | | | | | | | | "" used to become " now it just becomes an empty argument. Also if quotes appeared after a token started then if the number of quotes in the token is n the resulting one would be a token with the n last characters cut off, now it's fixed. Fixes https://github.com/profanity-im/profanity/issues/497
* Update copyright yearMichael Vetter2022-05-094-4/+4
|
* Fix a segfault when uploading or downloading filesMaxi Wuttke2022-04-022-2/+2
| | | | The variable `ccount->tls_policy` was not null-tested before `strcmp`.
* Fix crash on /editorMarcoPolo-PasTonMolo2022-03-241-1/+5
|
* apply `tls.policy` to cURL callsSteffen Jaeckel2022-03-222-0/+14
| | | | | | | | | | | | In case the user decides to ignore the validity-state of certificates we also have to configure libcurl accordingly. `tls.policy` can be set via ``` /account set <account> tls trust ``` Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* add profanity-specific CAfileSteffen Jaeckel2022-03-222-0/+12
| | | | | | | | The profanity-internal mechanism to allow connecting to a server isn't easily portable to cURL. Therefor introduce a profanity-specific CAfile which is managed individually and will be configured in libcurl calls. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* re-factor `get_message_from_editor()`Steffen Jaeckel2022-03-141-62/+50
| | | | | | | * use GLib functions to write&read compose file * trim trailing new-line characters from compose file Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* prevent segfaultSteffen Jaeckel2022-03-131-0/+3
| | | | | | | In case we're not connected yet and press Alt+c a segfault occurred since `conn.xmpp_conn` is dereferenced while it's still `NULL`. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Add stat.h to editorMichael Vetter2022-03-041-0/+1
| | | | | | Fix on openbsd: `src/tools/editor.c:55:36: error: 'S_IRWXU' undeclared (first use in this function)`
* Include errno header in editor.cMichael Vetter2022-03-041-1/+2
|
* Move get_message_from_editor to appropriate file and change its keybindingMarcoPolo-PasTonMolo2022-03-032-0/+176
|
* auto-formatSteffen Jaeckel2022-02-011-1/+1
| | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Format code correctlyMichael Vetter2021-10-051-1/+1
|
* Fix segfault when aesgcm url isn't the expected sizeMichael Vetter2021-06-301-0/+1
| | | | | | | | Fixes the bug mentioned in https://github.com/profanity-im/profanity/issues/1478#issuecomment-794161606 The rest of https://github.com/profanity-im/profanity/issues/1478 I can't reproduce. Seems to work fine.
* http upload: use correct content typeMichael Vetter2021-06-021-1/+1
| | | | | | | | | | This bug was introduced in 1ec606540eb0f474f3d968d3566a7c56d778a367 when `g_strdup_printf` was used instead of `asprintf`. Problem discoverd by raspeguy. Mistake discovered by optmzr and Martin. Thanks to everybody involved!
* Get rid of asprintf and _GNU_SOURCE defineMichael Vetter2021-03-305-51/+49
| | | | | | | _GNU_SOURCE was even in some files where it was not needed at all (http*). Let's replace asprintf() with g_strdup_printf().
* Add config.h in files were it was missingMichael Vetter2021-03-263-0/+6
| | | | Related to https://github.com/profanity-im/profanity/issues/1512
* autocomplete: remove duplicate code in search functionsMichael Vetter2021-03-111-54/+16
| | | | | | _search_next and _search_prev where exactly the same except taking the nex/prev from the list. Use one function with a direction argument.
* autocomplete: Use asprintf don't calculate length twiceMichael Vetter2021-03-111-4/+9
| | | | | | | | Through asprintf() we can get rid of malloc() + sprintf(). Also we don't need to calculate the strlen() again since asprintf() returns the bytes printes. Only non UTF-8 characters. But that was true before already.
* Remove duplicate code in autocomplete_param*Michael Vetter2021-03-111-29/+22
| | | | | autocomplete_param_with_func and -autocomplete_param_with_ac had lots of duplicate code.
* Upload: Fix unused returnThorben Günther2021-03-111-4/+9
|
* Update to the newest version of XEP 0363 (HTTP Upload)Maximilian Wuttke2021-03-112-0/+32
| | | | | | | | | | | | | Main changes: 1. Attributes instead of tags 2. Read the optional <header> tags and send them in the HTTP PUT header: * Authorization * Cookie * Expires Co-authored-by: Martin Dosch <martin@mdosch.de>
* Update copyrightMichael Vetter2021-01-082-2/+2
|
* Fix deadlock on error before HTTP download has begunWilliam Wennerström2020-12-101-4/+6
|
* Remove cmd_tiny, empty files and link nonce with IVWilliam Wennerström2020-12-073-2/+2
|
* Add tests for format_call_external_argvWilliam Wennerström2020-12-071-2/+2
|
* Fix bad order of parameters for url saveWilliam Wennerström2020-12-071-1/+7
|
* Rework url to filenameWilliam Wennerström2020-12-062-8/+6
|
* Move unique_filename_from_url functions to commonWilliam Wennerström2020-12-042-21/+0
|
* Refactor for threaded external executable for built-in download methodsWilliam Wennerström2020-12-035-2/+45
|
* Fix stubs and move some tests to http_commonWilliam Wennerström2020-11-162-18/+12
|
* Switch to g_strerrorWilliam Wennerström2020-11-162-23/+19
|
* Move common http tool code to http_commonWilliam Wennerström2020-11-166-53/+154
|
* Add I/O error handling and use filenames instead of file descriptorsWilliam Wennerström2020-11-164-51/+87
|
* Refactor OMEMO download into AESGCMDownload toolWilliam Wennerström2020-11-166-2/+221
|
* Run make format on rebaseWilliam Wennerström2020-11-164-57/+64
|
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-11-16 17:32:12 +0000