| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
strncpy(3) is not so safe function and can lead to mistakes. For
example, strncpy(dest, "Profanity", 10); is redundant and leads to
problems when someone changes the source string.
Different example is when 3rd argument equals to length of the
destination buffer. strncpy(3) doesn't terminate string with '\0' when
it truncates. Therefore, the destination string becomes corrupted.
Zeroize storage for 'nid', so the last byte remains '\0' in case of
truncate.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://github.com/profanity-im/profanity/commit/98c38dc6d6d29333c63f80327774f094610d8602
sets C99 as standard.
strdup() is not part of C99.
For now set `-D_POSIX_C_SOURCE=200809L` macro to have strdup() in C99.
Using `gnu99` instead would be another option.
We should take more care to use glib functions whenever possible.
Regards https://github.com/profanity-im/profanity/issues/1357
|
|
|
|
|
|
|
|
| |
New options:
/connect <account> [auth default|legacy]
/account <account> set auth default|legacy
Fixes #1236.
|
|
|
|
| |
Fix https://github.com/profanity-im/profanity/issues/1348
|
|
|
|
|
|
|
|
| |
Mistake introduced in 86f0e0ea7033a27a83a5c24091ae1fd5b579296d
The functions later on dont set an explitic position when writing their
strings.
Fix https://github.com/profanity-im/profanity/issues/1346
|
| |
|
|
|
|
| |
Instead of connection_get_fulljid() and then creating a Jid from it.
|
|
|
|
|
|
| |
`/bookmarl ignore` lists the ignored bookmarks.
Regards https://github.com/profanity-im/profanity/issues/1115
|
| |
|
|
|
|
| |
Fix https://github.com/profanity-im/profanity/issues/715
|
|
|
|
|
|
| |
Have field in struct and display the name in `/bookmark list`.
Regards https://github.com/profanity-im/profanity/issues/697
|
|
|
|
|
|
|
| |
`statusbar.show.read` can be set to false in the config.
`/statusbar show|hide read`.
Implement https://github.com/profanity-im/profanity/issues/1285
|
| |
|
|
|
|
|
|
| |
Display [SCROLLED] in titlebar if a chat/muc/private win is scrolled up.
Implement https://github.com/profanity-im/profanity/issues/1289
|
|
|
|
|
| |
This is used to set the openers for various commands.
So far for /avatar and /urlopen.
|
| |
|
| |
|
| |
|
|
|
|
| |
Start https://github.com/profanity-im/profanity/issues/1340
|
|
|
|
|
| |
https://github.com/profanity-im/profanity/commit/1f8b1eb740391941e79e1004ad041f8178a2b674 made it possible to have utf8 chars as correction chars. So since then prefs_get_correction_char() doesn't return a regular char but a char*.
Seems like there was an oversight that we need to use %s then.
|
|
|
|
|
|
| |
For some time users could choose to have the old way "unanimous" where
all the MUC history is just grey (or whatever was set). Now it is always
just displayed like regular new incoming MUC text.
|
|
|
|
|
| |
Fix mistake in a condition. Also add sanity check to
win_refresh_with_subwin().
|
|
|
|
| |
sorry.. doing too many things at once..
|
|
|
|
| |
Fix https://github.com/profanity-im/profanity/issues/1321
|
|
|
|
| |
Protect against invalid reads by checking the length.
|
| |
|
|
|
|
| |
Fixup for 86af6925d9fc0b2656eac15b0c8c7aba60589ce5
|
| |
|
|
|
|
|
|
|
| |
Setting the local pointer to NULL has no effect.
_destroy_tab() is used for g_hash_table_new_full() so we cant use a **
and set tab to NULL.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
That's actually not good practise.
Realized this when checking for multiple symbol definition in issue
mentioned below.
Regards https://github.com/profanity-im/profanity/issues/1314
|
|
|
|
|
|
|
|
|
|
| |
glib functions can allocate a GError object that must be freed with
g_error_free(). Otherwise a memory leak happens.
There are similar unfixed places in omemo, check:
grep "&error" src/omemo/omemo.c
Fixes #1304.
|
|
|
|
|
|
|
|
|
|
|
| |
MUCPMs and regular chat messages get printed with the same code.
But we don't save MUC PMs in the sqldb, because another jid could use
the same nick the next time.
And if we would take the log out we would need a different routine,
checking for resourcepart too.
Fix https://github.com/profanity-im/profanity/issues/1312
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only when we start the conversation.
Not yet when we get messaged and a new window is opened.
Need to have sorting of messages in the window buffer then, I guess.
Also MAM IQ should only be send one time in such a case.
If MAM is enabled history from sql backend will not be shown.
`mam` in profrc enables experimental MAM.
Can change soon again. Don't rely on stuff in this stage ;)
|
| |
|
|
|
|
|
| |
Is usefult in many cases if we want cleaner code.
Hope this edit didn't break anything though ;-)
|
| |
|
| |
|
| |
|
|
|
|
| |
So we don't have to check for MUC another way.
|
| |
|
|
|
|
| |
Same behaviour like when we used to get it from the text files.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now dont get the log files from the text files via chat_log_get_previous() anymore.
We use the sql backend via log_database_get_previous_chat().
So far it just has the same behaviour like chat_log_get_previous(),
except that in _chatwin_history() we don't pass the sender to
win_print_history() which should be fixed in a commit soon.
And log_database_get_previous_chat() can later easily be expanded to fix
https://github.com/profanity-im/profanity/issues/205.
|
| |
|
|
|
|
|
| |
There are multiple paths which lead to rosterwin_roster(). The function
doesn't free list returned by wins_get_private_chats().
|