| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
introduced in 8d3c1f79ac7cc2b0830f0afed48dc1fb9008ab0e
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
|\ |
|
| |\
| | |
| | | |
Minor improvements
|
| | |
| | |
| | |
| | | |
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This fixes #1846
Issue introduced by a0aa26b6fa65ba625f4a6d3495a345c7120ff16d
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There were multiple reports where after a reconnect the window of the
MUC that was last opened, was empty.
`muc_join()` creates an instance of a MUC, `presence_join_room()` works
with this instance. Therefore the instance has to exist before working on
it.
I'm not sure if this really fixes the issue, but at least it didn't
happen anymore after I applied this modification.
I can't remember how I stumbled over this, either while looking at debug
logs or while looking at Valgrind output while a reconnect happened, but
something went wrong. Then I came to the conclusion that this may fix
the issue and for now it did ... maybe it comes back, then my RCA was
wrong.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Each of the cmd_executable_editor(), cmd_executable_urlopen() etc calls
this helper function since they were all doing the same just for
different configurations.
|
| | |
| | |
| | |
| | |
| | | |
We autocompleted `/executable` to `avatar`, `vcard_photo`, `editor` etc.
But didn't autocomplete the next parameter. Namely `set` and `default`.
|
| | |
| | |
| | |
| | |
| | | |
All the other commands (avatar, vcard_photo, urlsave, urlopen) have the
ability to reset to default already.
|
| | |
| | |
| | |
| | | |
Was forgotten in f934c5b59.
|
| | |
| | |
| | |
| | |
| | |
| | | |
`/executable avatar` now also uses cmdtemplate and parse %p.
It seems to me that the `/avatar` command was actually completely broken
on master.
|
| |/
| |
| |
| |
| |
| | |
This is done in `/executable avatar set` since d7848e38b.
The command help also didn't mention this anymore.
Seems like it was forgotten to remove the actual parsing of this.
|
|/
|
|
|
|
|
|
| |
Use gchar instead of char in most of the cases where gchar is intended.
Reason: improve compatibility and stability. Issue #1819
Minor refactoring.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add "/avatar disable" to comply with point "3.5 Publisher Disables
Avatar Publishing" in XEP-0084.
src/command/cmd_defs.c:2416
Add "disable" argument. Reword the "/avatar" command description
so it flows better.
src/command/cmd_ac.c:1101
Add "disable" to the "/avatar" autocomplete dictionary.
src/command/cmd_funcs.c:9277
Split "/avatar" commands into two groups with an if statement; those
with a parameter and those without. "cons_bad_cmd_usage()" is in both
groups, which is messy. "disable" has similar logic to "set", but it
includes a failure message.
src/xmpp/avatar.c:152
"avatar_publishing_disable()" uses the same logic to publish metadata
as in "avatar_set()".
src/xmpp/avatar.c:238
Add a message to inform users when they do not receive an avatar after
using "/avatar get" and "/avatar open". In case of a failure, the user
will be subscribed to future avatar updates as long as they continue
to use their current instance of profanity. Adding
"caps_remove_feature()" after "cons_show()" will unsubscribe the user
from avatar updates and prevent the user from downloading an avatar
unexpectedly hours later without issuing an "/avatar" command.
src/xmpp/stanza.c:2698
The new "disable" function follows the same logic as
"stanza_create_avatar_metadata_publish_iq()".
|
|\
| |
| | |
Improve OMEMO messages
|
| | |
|
|\ \
| | |
| | | |
Fix `/plugins update`
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before it tried to unload the plugin first and check the output.
But if broken plugin was loaded, then it couldn't unload it,
so before it require uninstall and install after it,
making update useless for plugin development purposes.
Unload is part of the uninstall so no unload is needed inside of the cmd function.
Refactoring of cmd_plugins_update.
|
| |
| |
| |
| | |
Introduced in 59b99fece.
|
|/
|
|
| |
Got introduced with 5d3c8ce7c.
|
|
|
|
|
|
|
| |
Since MUC private messages are not logged by design,
part where this logging happening is removed to add consistency.
Add explanation in comment.
|
|
|
|
|
|
| |
Fix crash caused by `/log level` command.
Minor refactoring of command function.
|
|\
| |
| | |
New Feature: Session Alarm
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Introduce new feature: sessions_alarm.
Added new account setting: max_connections. On exceeding this number,
user will get an alert. If number is less than 1, no alert will happen.
Tests altered to fit new feature.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Expected behaviour
When you type
/command
/command
it should be just 1 entry in the history.
Behaviour
All the entries were saved.
Behaviour is changed by introducing check. Before adding to history,
entry now is compared to the last history entry.
|
|/ |
|
|\
| |
| | |
Fix memory corruption crash
|
| |
| |
| |
| |
| |
| | |
In OX implementation gpgme's buffer remains untouched, thus not leading to the crash.
But code can be shorter and more concise.
|
| |
| |
| |
| |
| |
| |
| | |
Under certain circumstances setting plain_str[len] to 0 might lead to crash
and it does not follow the best practices as well.
This change allows better handling of buffer copying and prevents crash.
|
|/
|
|
|
|
| |
Add support of name/nickname instead of only JID for `/roster remove` command.
Add tests for it as well.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Let's set this to NULL.
Someone was using `picaur` and got an error about potential
uninitialization. Even though the code is fine let's set this to NULL to
make the compiler happy.
The strange thing was that building manually on the same system worked.
Related to 2e43b0ae62478bede34f6f52f73d22d671425f85.
|
|\
| |
| | |
Hotfix stanza release
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If custom client is not set and include_os is true,
stanzas might be released without initializiting.
This commit fixes it by introducing an additional check
on usage of custom client.
Related to commit e52ca2fbaa02acec3b2b757369ef5740e7a103da
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
While testing https://github.com/profanity-im/profanity/pull/1817
we found that:
```
/statusbar show name (I have this off by default
/msg someone where I chose someone in my roster that has a nick assigned
/statusbar chat jid
```
Will only take effect upon creation or redraw of that tab.
Reason is that we do this in create_tab to limit building this
dynamically.
Let's leave it like it is but add a note to users.
Not worth build that string all the time.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Fixes statusbar tabs.
Bug: Statusbar used nickname if it was set in roster,
irrelevant to /statusbar chat setting.
Expected behaviour would be using this setting set as "user" to show nickname,
and to show jid with "jid" setting.
Other solution is to give a user control over it with another settings.
- _status_bar_draw_maintext cleaned up, no changes to behaviour
|
|/
|
|
|
|
|
| |
Before this change, only nickname or JID (if no nickname set) is shown in the titlebar.
Change allows to alter nickname/JID preference
using already implemented /titlebar show jid|name setting.
If both are set to "show", then it is displayed in "nickname <JID>" format.
|
| |
|
|\
| |
| | |
Feature: Allow setting client identification name/version manually
|
| |
| |
| |
| |
| |
| |
| |
| | |
Add changes allowing user to switch client name and version.
Useful for enhancing user privacy.
Minor cleanup.
|
| |
| |
| |
| |
| |
| |
| | |
As stated in
https://github.com/profanity-im/profanity/pull/1820#issuecomment-1498083383
profanity uses "..." (three dots) in a lot of places instead the proper
ellipsis char "…".
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The existing way how active tabs are displayed didn't allow showing more
than 10 tabs. This patch adds a mode where the statusbar shows a
comma-separated list of tabs which were active since the last time viewed.
This view is inspired by how `irssi` shows the active tabs, therefore
it is also called `actlist`.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It is possible, that a server sends a form with a field as follows, which
has no (default) value assigned.
```
<field label="foo" type="list-single" var="bar">
<option label="a"><value>a</value></option>
<option label="b"><value>b</value></option>
<option label="c"><value>c</value></option>
</field>
```
This patch fixes profanity to show that list. Before this patch
profanity showed nothing.
I stumbled over this while running the `/room config` command inside
a newly created muc on the `sure.im` XMPP server.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
| |
| |
| |
| |
| |
| | |
...instead of having two separate arrays.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
| |
| |
| |
| |
| |
| |
| | |
Before this change the same hashtable was re-created each time one used the
auto-completion feature.
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
|/
|
|
|
|
|
|
| |
`found` was leaked before
This was somehow missed in e9aaba938b4f1b62b5f9018583a82ed7e7180977
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
|
| |
|
|\
| |
| |
| |
| | |
MarcoPolo-PasTonMolo/fix/empty_window_after_reconnect
Fix empty window after reconnect
|
| |
| |
| |
| |
| |
| |
| |
| | |
Sometimes after a reconnect the current window would get cleared. This
was a deliberate change to fix the profanity window looking all garbled
up after providing the passphrase for a gpg key using pinentry-curses.
Fixes https://github.com/profanity-im/profanity/issues/1556
|
|\ \
| | |
| | | |
Add autocomplete for the /reconnect command
|