| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
Additionally to:
7de83217c4d7bfdb70b77f2baeb8f12d4147d873
1e2a288d80fe0200f1d44d5106f7cc5bfd77718b
|
|
|
|
| |
not found
|
|
|
|
|
|
|
|
|
|
| |
So far:
```
/executable urlsave html "test %u" results in url.save.cmd[html]=test %u
/executable urlsave * "test %u" results in nothing.
```
Probably due to limitation in .ini file format.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additionally to ec7e635e752bdfef851fd177596c1d73d97afb42.
In the earlier commit I just setted the test value ignoring the real
format.
Now we correctly transform:
```
[logging]
urlopen.cmd=xdg-open
```
into:
```
[executables]
url.open.cmd=false;xdg-open %u;
```
|
| |
|
|
|
|
| |
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
|
|
|
|
| |
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
c56d530b67d09267eb46cba029217e4b84b32cef by peetah moves:
urlopen.cmd from the 'logging' to a new 'executables' section in profrc
avatar.cmd from the 'logging' to a new 'executables' section in profrc
We need to adapt this so that users don't have to set the setting again
themselves.
|
|
|
|
|
| |
f9961677aaa8d2713a80127f95a3770b33af4cef replaces prefs_free_string()
with g_free(). Both is correct but lets still use this.
|
|
|
|
| |
g_free(NULL); is noop.
|
|
|
|
| |
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
|
|
|
|
|
|
|
|
|
|
| |
The display of commands associated with specific file
types and protocols will need to be implemented later,
but this requires to use private data of the GKeyFile
structure, which can be a maintainability issue on the
long term.
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
|
|
|
|
| |
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
|
|
|
|
|
|
|
|
| |
/urlopen is replaced by /url with the following sub commands:
/url open <url>
/url save <url> [<path>]
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Where GKeyFile usually use the pref[locale] format to define
locale specific translated data, it is here hijacked to be used
as pref[option] in order to specialize a preference according
to an option:
open.url.cmd[pdf] = pdf-viewer
open.url.cmd[jpg] = image-viewer
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
|
|
|
|
| |
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
|
|
|
|
| |
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
strncpy(3) is not so safe function and can lead to mistakes. For
example, strncpy(dest, "Profanity", 10); is redundant and leads to
problems when someone changes the source string.
Different example is when 3rd argument equals to length of the
destination buffer. strncpy(3) doesn't terminate string with '\0' when
it truncates. Therefore, the destination string becomes corrupted.
Zeroize storage for 'nid', so the last byte remains '\0' in case of
truncate.
|
|
|
|
| |
strdup(3) requires string.h
|
|
|
|
| |
Regards https://github.com/profanity-im/profanity/issues/1367
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since https://github.com/profanity-im/profanity/commit/d92c576aa53505d712715b1acc6344af3262c84f
we rely on g_spawn_sync().
Which doesn't do variable/glob expansion.
For our use of call_external() in opening and URL or avatar this is
fine.
For getting the password we want to be able to use ~ for our files.
Let's use a shell here.
Fix https://github.com/profanity-im/profanity/issues/1364
|
|
|
|
| |
Check for pointer to be NULL before dereferencing it.
|
|
|
|
|
|
| |
"base" was not really base but the filename :-)
Fix https://github.com/profanity-im/profanity/issues/1362
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://github.com/profanity-im/profanity/commit/98c38dc6d6d29333c63f80327774f094610d8602
sets C99 as standard.
strdup() is not part of C99.
For now set `-D_POSIX_C_SOURCE=200809L` macro to have strdup() in C99.
Using `gnu99` instead would be another option.
We should take more care to use glib functions whenever possible.
Regards https://github.com/profanity-im/profanity/issues/1357
|
|
|
|
|
|
|
|
|
|
|
|
| |
Found this when looking to fix bug https://github.com/profanity-im/profanity/issues/1357
Not sure if it is related.
man 3 getenv sais:
```
As typically implemented, getenv() returns a pointer to a string within
the environment list. The caller must take care not to modify this
string, since that would change the environment of the process.
```
|
|
|
|
|
|
|
|
| |
Some systems don't provide recent libstrophe releases. When older
version of libstrophe is detected, don't build legacy auth support.
To simplify this patch, report about unsupported legacy auth and
keep commands option as is.
|
|
|
|
|
|
|
|
| |
New options:
/connect <account> [auth default|legacy]
/account <account> set auth default|legacy
Fixes #1236.
|
|
|
|
|
|
|
|
|
|
| |
Memleak was reinroduced in d92c576aa53505d712715b1acc6344af3262c84f
It was already fixed in ac5ce105ac08f022d88d7e73dc38f2706d4c44cf
But the rebase peetahs rebase ontop of master took the wrong changes.
I decided to pull anyways and fix since reviewing/giving feedback
without GH probably takes longer.
|
|
|
|
| |
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
|
|
|
|
| |
Signed-off-by: Pierre Mazière <pierre.maziere@gmx.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix https://github.com/profanity-im/profanity/issues/1280
p_contact_set_presence() is triggered in
(roster_process_pending_presence) to set the presence to online
after the roster is displayed.
This happened to me _every time_ with one certain account on my server.
But not even once with other accounts on my server.
I don't understand why that is the case, but AFAIK the code should be
like it is in this PR anyways.
roster_process_pending_presence() was added there in
973a05d15a9843f2e8f6dff598f2161367885994 to fix
https://github.com/profanity-im/profanity/issues/1050
|
| |
|
| |
|
|
|
|
| |
Fix https://github.com/profanity-im/profanity/issues/1348
|
|\ |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
NOTE: as per XEP-0060 §12.20, it is RECOMMENDED for the publisher to specify an
ItemID of "current" to ensure that the publication of a new item will overwrite
the existing item.
https://xmpp.org/extensions/xep-0384.html#devices
Issue: 1329
|
|\ \
| | |
| | | |
Incoming iq stanza - Reset the autoping timer
|
| |/
| |
| |
| |
| |
| |
| |
| | |
A autoping is to make sure that there is still a connection between server and
client. If the application receives incoming stanza, the connection is fine.
There is no need to wait for response, if there are other incomings.
Issue: #1333 and #1315
|
|\ \
| | |
| | | |
Bugfix: Status with PGP shows offline in titlebar
|
| |/
| |
| |
| |
| |
| |
| |
| | |
There is code to redraw the ui, because the user may enter a passphase for the
private key. There was also a ui_init, which shouldn't be called, because it
will set the status to the initial state, which is 'offline' and 'no tls'.
Issue: #1327
|
| |
| |
| |
| | |
Regards https://github.com/profanity-im/profanity/issues/1342
|
| |
| |
| |
| |
| |
| |
| |
| | |
Mistake introduced in 86f0e0ea7033a27a83a5c24091ae1fd5b579296d
The functions later on dont set an explitic position when writing their
strings.
Fix https://github.com/profanity-im/profanity/issues/1346
|
| | |
|
| | |
|