about summary refs log tree commit diff stats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Fix double free in room id handlerMichael Vetter2019-07-091-6/+1
| | | | | Free is done in destructor now. Regards https://github.com/profanity-im/profanity/issues/1148
* Fix double free in omemo_start_device_session_handle_bundle()Michael Vetter2019-07-081-0/+1
| | | | | | | | | omemo_key_free() was called to free the key. It free the key->data too. But in same cases this was not set yet. So we need to set the data to NULL (or use calloc) at initialization so that omemo_key_free() only frees it if it was actually allocated. Regards https://github.com/profanity-im/profanity/issues/1148
* Fix double free regarding iq handlersMichael Vetter2019-07-081-14/+4
|
* Merge pull request #1146 from profanity-im/fix/omemoleaks-autocomplMichael Vetter2019-07-045-27/+72
|\ | | | | Fix several OMEMO related leaks
| * Free iq_id_handlers correctlyMichael Vetter2019-07-041-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | so far only the key part was freed. We also need to free the actual handler. Fix: ``` ==21171== 1,128 bytes in 47 blocks are definitely lost in loss record 3,476 of 3,670 ==21171== at 0x483677F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==21171== by 0x434248: iq_id_handler_add (iq.c:265) ==21171== by 0x4B122E: omemo_devicelist_request (omemo.c:46) ==21171== by 0x4AC411: omemo_start_session (omemo.c:409) ==21171== by 0x4AC37C: omemo_start_sessions (omemo.c:396) ==21171== by 0x447881: sv_ev_roster_received (server_events.c:189) ==21171== by 0x444019: roster_result_handler (roster.c:312) ==21171== by 0x433FC2: _iq_handler (iq.c:202) ==21171== by 0x5AF118E: ??? (in /usr/lib64/libmesode.so.0.0.0) ==21171== by 0x5AEDBDA: ??? (in /usr/lib64/libmesode.so.0.0.0) ==21171== by 0x5AFA43E: ??? (in /usr/lib64/libmesode.so.0.0.0) ==21171== by 0x6818AA4: ??? (in /usr/lib64/libexpat.so.1.6.8) ==21171== by 0x681A3AB: ??? (in /usr/lib64/libexpat.so.1.6.8) ==21171== by 0x681D7EB: XML_ParseBuffer (in /usr/lib64/libexpat.so.1.6.8) ==21171== by 0x5AF0A63: xmpp_run_once (in /usr/lib64/libmesode.so.0.0.0) ==21171== by 0x432E5D: connection_check_events (connection.c:104) ==21171== by 0x4323B3: session_process_events (session.c:255) ==21171== by 0x42C097: prof_run (profanity.c:128) ==21171== by 0x4B2627: main (main.c:172) ```
| * Free key on error in omemo_start_device_session_handle_bundle()Michael Vetter2019-07-041-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix: ``` ==20561== 32 bytes in 1 blocks are definitely lost in loss record 1,467 of 3,678 ==20561== at 0x483677F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==20561== by 0x4B16C9: omemo_start_device_session_handle_bundle (omemo.c:167) ==20561== by 0x43405E: _iq_handler (iq.c:214) ==20561== by 0x5AF118E: ??? (in /usr/lib64/libmesode.so.0.0.0) ==20561== by 0x5AEDBDA: ??? (in /usr/lib64/libmesode.so.0.0.0) ==20561== by 0x5AFA43E: ??? (in /usr/lib64/libmesode.so.0.0.0) ==20561== by 0x6818AA4: ??? (in /usr/lib64/libexpat.so.1.6.8) ==20561== by 0x681A3AB: ??? (in /usr/lib64/libexpat.so.1.6.8) ==20561== by 0x681D7EB: XML_ParseBuffer (in /usr/lib64/libexpat.so.1.6.8) ==20561== by 0x5AF0A63: xmpp_run_once (in /usr/lib64/libmesode.so.0.0.0) ==20561== by 0x432E5D: connection_check_events (connection.c:104) ==20561== by 0x4323B3: session_process_events (session.c:255) ==20561== by 0x42C097: prof_run (profanity.c:128) ==20561== by 0x4B260D: main (main.c:172) ```
| * Rework omemo_start_device_session_handle_bundle exitMichael Vetter2019-07-041-24/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some conditions we just returned without freeing allocated variables. Should fix following valgrind reported leak: ``` ==17941== 19 bytes in 1 blocks are definitely lost in loss record 613 of 3,674 ==17941== at 0x483677F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==17941== by 0x5BB0DAA: strdup (strdup.c:42) ==17941== by 0x4B1592: omemo_start_device_session_handle_bundle (omemo.c:126) ==17941== by 0x43405E: _iq_handler (iq.c:214) ==17941== by 0x5AF118E: ??? (in /usr/lib64/libmesode.so.0.0.0) ==17941== by 0x5AEDBDA: ??? (in /usr/lib64/libmesode.so.0.0.0) ==17941== by 0x5AFA43E: ??? (in /usr/lib64/libmesode.so.0.0.0) ==17941== by 0x6818AA4: ??? (in /usr/lib64/libexpat.so.1.6.8) ==17941== by 0x681A3AB: ??? (in /usr/lib64/libexpat.so.1.6.8) ==17941== by 0x681D7EB: XML_ParseBuffer (in /usr/lib64/libexpat.so.1.6.8) ==17941== by 0x5AF0A63: xmpp_run_once (in /usr/lib64/libmesode.so.0.0.0) ==17941== by 0x432E5D: connection_check_events (connection.c:104) ==17941== by 0x4323B3: session_process_events (session.c:255) ==17941== by 0x42C097: prof_run (profanity.c:128) ==17941== by 0x4B2610: main (main.c:172) ```
| * Free omemo_ctx.device_list_handlerMichael Vetter2019-07-041-0/+1
| |
| * Dont initialize omemo autocompleter twiceMichael Vetter2019-07-041-2/+0
| | | | | | | | | | We already do this in omemo_init() no need to do it again in omemo_on_connect().
| * Add omemo_close functionMichael Vetter2019-07-043-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We call omemo_init() when starting profanity and should have an omemo_close() at exit. For now we free the fingerprint autocompleter in there. Fixes valgrind: ``` ==13226== 24 bytes in 1 blocks are definitely lost in loss record 2,855 of 6,958 ==13226== at 0x483677F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==13226== by 0x48AD39: autocomplete_new (autocomplete.c:57) ==13226== by 0x4AB89F: omemo_init (omemo.c:127) ==13226== by 0x42C283: _init (profanity.c:206) ==13226== by 0x42BFF3: prof_run (profanity.c:98) ==13226== by 0x4B25E6: main (main.c:172) ``` Regards https://github.com/profanity-im/profanity/issues/1131
* | Fix plaintext private message handlingPaul Fariello2019-07-041-3/+3
|/
* Use correct jid variableMichael Vetter2019-07-031-1/+1
|
* Define goto out in _private_chat_handler()Michael Vetter2019-07-031-0/+1
|
* Set plain message in _private_chat_handlerMichael Vetter2019-07-031-0/+7
| | | | | | In case that plain is NULL we need to copy over from body. Fix https://github.com/profanity-im/profanity/issues/1144
* Show MUC history on intentional reconnectMichael Vetter2019-07-034-7/+42
| | | | | Small bug caused by 13675fb and ce5a4ed. Fix https://github.com/profanity-im/profanity/issues/1142
* Mark messages received from a session as trustedPaul Fariello2019-06-253-10/+25
|
* Fix a segfault when carbon has no bodyPaul Fariello2019-06-211-11/+13
|
* Fix handling of encrypted carbonsPaul Fariello2019-06-213-30/+62
|
* Don't highlight cleartext message as untrustedPaul Fariello2019-06-211-0/+1
|
* Fix segfault when receiving messages without IDPaul Fariello2019-06-211-1/+3
|
* Fix NULL pointer when handling non encrypted message in MUCPaul Fariello2019-06-211-1/+9
|
* Rename prof_message_t into ProfMessagePaul Fariello2019-06-2013-45/+45
|
* Set foreground color for untrusted messagesPaul Fariello2019-06-205-9/+10
|
* Add prof_message_t to wrap all message attributesPaul Fariello2019-06-2017-337/+410
| | | | | | | Probably missing copy of body to plain in carbon and privmessage. Only covers the incoming message path because goal is OMEMO decryption of untrusted message. Cover some of the log functions but not all.
* Use flags in xmmp/message.c for encryption and trustPaul Fariello2019-06-206-25/+44
|
* Add trusted state after OMEMO decryptionPaul Fariello2019-06-207-18/+24
| | | | Use it to print message on red background if not trusted.
* Decrypt all incoming OMEMO msgPaul Fariello2019-06-203-1/+23
| | | | | Trust all key as long as it's for reading. This code isn't multithread safe.
* _bookmark_destroy: follow normal logicMichael Vetter2019-06-201-7/+5
|
* Call message_handlers_clear() upon disconnectMichael Vetter2019-06-203-0/+10
| | | | Free pubsub_event_handlers. Fix memory leaks.
* Call iq_handlers_clear() upon disconnectMichael Vetter2019-06-203-0/+10
| | | | Free id_handlers. Fix memory leaks.
* Free contacts in omemo_start_sessions()Michael Vetter2019-06-191-0/+1
|
* Free OMEMO session store upon disconnectMichael Vetter2019-06-191-0/+1
|
* Fix prefs_get_string mem leaks in statusbarMichael Vetter2019-06-191-6/+18
|
* Free last_msg_timestampMichael Vetter2019-06-191-0/+4
| | | | Fix memory leak.
* Add option to set all window related time formatsMichael Vetter2019-06-173-4/+51
| | | | | | | | | | | | | | | | | | | Implements feature requested at: https://github.com/profanity-im/profanity/issues/632 So instead of: /time console set <format> /time chat set <format> /time muc set <format> /time mucconfig set <format> /time private set <format> /time xml set <format> As a short cut the user can do: /time all set <format> Excluding statusbar and lastactivity settings since they are not for main windows, but used slightly differently.
* Add copyright to omemo codeMichael Vetter2019-06-176-0/+199
|
* Add myself to copyrightMichael Vetter2019-06-1714-0/+16
| | | | Like discussed with James.
* Use profanity channel as exampleMichael Vetter2019-06-171-3/+3
|
* Merge pull request #1110 from profanity-im/feature/704-ui-behaviour-reconnectMichael Vetter2019-06-115-2/+57
|\ | | | | Feature/704 ui behaviour reconnect
| * Safe last MUC message timestamp per MUCMichael Vetter2019-06-113-8/+10
| | | | | | | | | | | | After pasis review of my code he thinks it's better to safe the timestamp per MUC so we can account for some problems that could occur with timing.
| * Only show MUC subject on first connectMichael Vetter2019-06-051-1/+1
| | | | | | | | | | | | For #704 we don't show the room history upon reconnect. Now we also don't show the room subject in the channel upon re-established connection.
| * Reduce timestamp call when saving last muc messageMichael Vetter2019-06-051-12/+13
| | | | | | | | Let's test for mucwin earlier.
| * Only print room history for new messages upon reconnectMichael Vetter2019-06-053-1/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If re-establish a connection don't print the room history again. In case there there happened nothing at all since we got the room history on the last connection. And in case there were no new messages during the time we have been disconnected. Instead of printing the room history again we now print 'Re-established Connection'. This adds a bit of overhead since we save the timestamp upon every MUC message. See: https://github.com/profanity-im/profanity/issues/704
* | Rejoin all MUCs on reconnectMichael Vetter2019-06-101-5/+3
| | | | | | | | Should fix https://github.com/profanity-im/profanity/issues/1120
* | Merge pull request #1125 from profanity-im/fix/519-logrotateMichael Vetter2019-06-101-6/+9
|\ \ | | | | | | Iterate logfiles until 100 are reached
| * | Iterate logfiles until 100 are reachedMichael Vetter2019-06-071-6/+9
| | | | | | | | | | | | Fix https://github.com/profanity-im/profanity/issues/519
* | | Merge pull request #1124 from ↵Michael Vetter2019-06-082-16/+122
|\ \ \ | |/ / |/| | | | | | | | paulfariello/feature/remove_session_when_untrusting_omemo_device Remove OMEMO session when untrusting a fingerprint
| * | Remove OMEMO session when untrusting a fingerprintPaul Fariello2019-06-072-16/+122
| | | | | | | | | | | | | | | | | | We have to store known_devices in a long term fashion otherwise we might not be able to delete session if it is remove from device list server side.
* | | Merge pull request #1123 from profanity-im/fix/1093-already-started-messageMichael Vetter2019-06-071-40/+25
|\ \ \ | | | | | | | | Print omemo start related msgs into correct window
| * | | Refactor cmd_omemo_startMichael Vetter2019-06-071-38/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some code was duplicated/similar. The parts about using a chatwin while being started from another window (recipient provided) and being a chatwin were the same. Like this it should be easier to read and less code.