about summary refs log tree commit diff stats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* | Fix typos and update codespell configurationDaniel Santos2023-04-032-2/+2
|/ | | | | | | | | | * Fix typos. * Add words that are not typos to codespell's ignore words list and ignore regex. * Make codespell ignore URIs. * Make `make doublecheck` throw no error. Signed-off-by: Daniel Santos <dacs.git@brilhante.top>
* Merge pull request #1801 from alexandre1985/editor-with-argumentsMichael Vetter2023-03-312-2/+8
|\ | | | | Editor executable support flags
| * Add editor executable to CMD_SYNDaniel Santos2023-03-311-0/+1
| | | | | | | | | | | | * Add missing text of how to set editor in CMD_SYN Signed-off-by: Daniel Santos <dacs.git@brilhante.top>
| * Editor executable support flagsDaniel Santos2023-03-302-2/+7
| | | | | | | | | | | | | | | | * Make editor executable into a string to be able to support (multiple) flags. * Change /help executable to suit this new feature Signed-off-by: Daniel Santos <dacs.git@brilhante.top>
* | Fix OTRJohn Hernandez2023-03-311-4/+0
| | | | | | | | Fix OTR: carbon in stanza breaks OTR and prevents it from starting and working properly.
* | Fix PGPJohn Hernandez2023-03-313-13/+10
|/ | | | Fix of PGP and potentially other encryption methods by calling correct function that would initiate them in case if someone writes.
* Add WIN_VCARD to win_get_tab_identifier()Michael Vetter2023-03-231-0/+4
| | | | | | Thanks to 12b997c5f34776f34634d4ca155a14586aebc905 we already found a place where we should add this missing window type. AFAIK there can be only one vcard window.
* Adapt to new g_string_free() usageMichael Vetter2023-03-232-13/+4
| | | | | Somehow this must have been overlooked when doing e59c401c840f379e64945734969db03b0e55ef22.
* ui: make it easier to find non covered window typesMichael Vetter2023-03-231-20/+31
| | | | | | | | | | | | | | | | Rewrite `win_get_title()` to using switch without a default case. So the compiler warns us (`enumeration value ‘WIN_XXX’ not handled in switch`) in case we add a new window type (WIN_CHAT, WIN_PRIV etc) and forget to adapt this function. Add assert() in the end to make compiler happy when he realizes there the function might have no return value (`control reaches end of non-void function`). This should ever be reached. Replace the default value of `win_to_string()`, `win_get_tab_identifier()` as well, and replace it with an assert. See discussion started at https://github.com/profanity-im/profanity/pull/1799#discussion_r1142444684
* Adapt to g_string_free glib 2.75.3 changeMichael Vetter2023-03-2117-145/+42
| | | | | | | | | | | | glib 2.75.3 changes warning behaviour of `g_string_free()`. See: * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3219 * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3226 Use this opportunity to replace the use of GString with `g_strdup_printf()` where possible. Otherwise correctly take the return value of `g_string_free()` which is nicer anyways.
* change OMEMO QR code `0` bits to 'space'Steffen Jaeckel2023-03-121-2/+6
| | | | | | This makes the generated QR code a lot better recognizable in my case. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* fix #1797Steffen Jaeckel2023-03-121-1/+1
| | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* fix #1761 by changing the implementation from recursiveSteffen Jaeckel2023-03-111-23/+22
| | | | | | ... to an iterative approach Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* simplify some codeSteffen Jaeckel2023-03-111-5/+1
| | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* remove compat codeSteffen Jaeckel2023-03-111-15/+0
| | | | | | We already depend on libstrophe >= 0.12, so this code can go. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Fix duplicate download IDs.IsaacM882023-03-099-27/+40
| | | | | | | | | | Fixes https://github.com/profanity-im/profanity/issues/1794 Explanation The problem is the download's identifier. Downloads are given an ID so they can be referenced later when their progress changes. Currently, the download's ID is the download's URL. When you download the same file twice, you have two downloads with the same ID. Download progress updates are shown on the first of both downloads with the same ID. Solution Change the download's ID from its URL to a random number. A random ID is generated when get_random_string() is called from cmd_funcs.c. Several other functions are updated to cope with the new ID format.
* cmd: Update MAM helpMichael Vetter2023-02-151-2/+2
|
* Merge pull request #1789 from MarcoPolo-PasTonMolo/fix/autocompletion_after_MAMMichael Vetter2023-02-158-20/+41
|\ | | | | Fix quote and url autocompletion for MAM and history
| * Fix quote and url autocompletion for MAM and historyMarcoPolo-PasTonMolo2023-02-138-20/+41
| | | | | | | | | | | | | | | | After adding MAM quote and url autocompletion wouldn't pick up messages from MAM or history(from DB) or would have them in the wrong order. This commit fixes that. Fixes https://github.com/profanity-im/profanity/issues/1770
* | Fix MAM not loading some recent messagesMarcoPolo-PasTonMolo2023-02-141-4/+4
|/ | | | | Reverse a small change from commit e886ba0 that caused this issue. Fixes https://github.com/profanity-im/profanity/issues/1790
* Merge pull request #1788 from profanity-im/minor-improvementsMichael Vetter2023-01-302-9/+13
|\ | | | | Minor improvements
| * prevent setting invalid combination of libstrophe flagsSteffen Jaeckel2023-01-271-2/+10
| | | | | | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * simplify some codeSteffen Jaeckel2023-01-261-4/+2
| | | | | | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * fix libstrophe timer-callback usageSteffen Jaeckel2023-01-261-3/+1
| | | | | | | | | | | | | | The timer will be auto-removed if the callback returns `0`. The way it was done before breaks some internals of libstrophe. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* | Remove space to match clang coding stylethe xhr2023-01-261-1/+1
| |
* | Add macro for possible NULL prints and use it on known sportsthe xhr2023-01-264-5/+11
| | | | | | | | | | The macro is effective on OpenBSD and basically a no op on other platforms. Use it for one existing and the other known debug statements.
* | Check if string is NULL and print placeholder insteadthe xhr2023-01-262-2/+2
|/ | | | OpenBSD's kernel warns about NULL printfs. Fix this with a standard check.
* introduce `auto_gcharv`Steffen Jaeckel2023-01-193-71/+23
| | | | | | This also fixes memory leaks in `_omemo_autocomplete()`. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* introduce `auto_jid` and refcounting in `Jid`Steffen Jaeckel2023-01-193-26/+36
| | | | | | | | This also fixes a memory leak from within `_handle_groupchat()` in [0]. [0] src/xmpp/message.c Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* improve const correctnessSteffen Jaeckel2023-01-183-8/+8
| | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* fix more memory leaksSteffen Jaeckel2023-01-187-23/+38
| | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* fix memory leaks in OMEMOSteffen Jaeckel2023-01-185-36/+61
| | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* let `account_new()` take ownership of passed valuesSteffen Jaeckel2023-01-183-110/+38
| | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* add `now` option to `/reconnect` commandSteffen Jaeckel2023-01-184-15/+18
| | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* slightly improve `command_defs[]`Steffen Jaeckel2023-01-185-463/+274
| | | | | | | | | * make the struct `const` * use designated initializers * remove `CMD_NOxyz` macros * fix function-pointer correctness of `sub_func[]` Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* minor changesSteffen Jaeckel2023-01-186-73/+43
| | | | | | | | | | | * fix typo * less code duplication * less `GString` usage * more `auto_gchar` usage * document connecting to servers supporting SASL ANONYMOUS * ignore valgrind output Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* add `/strophe` command to modify libstrophe-specific settingsSteffen Jaeckel2023-01-1811-23/+189
| | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
* Update copyright yearMichael Vetter2023-01-1053-55/+55
|
* Make `/url save` autocomplete filenames after a urlMarcoPolo-PasTonMolo2022-12-271-1/+15
| | | | | | | | | | Previously after the url if you pressed tab, even if you typed out a filepath, profanity would erase that and cycle through url autocomplete results. This patch solves that and autocompletes filepaths after the url. Fixes https://github.com/profanity-im/profanity/issues/1783
* Work around different clang-format versionsMichael Vetter2022-10-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | Locally I have clang-format 15.0.2. Our CI runs ubuntu-20.04 so it has 10.0. Seems like a default value changed but I can't find it. When I still had clang-format 14.x everything was fine and checking: https://releases.llvm.org/15.0.0/tools/clang/docs/ReleaseNotes.html#clang-format I only see irrelevant things. Someone on the llvm IRC channel sais "there is no guarantee" and "maybe a regression or intended change". But seems like noone knows which setting could be the one we need. Since I don't have a better solution for now I will just edit this by hand to apply to the clang-format version we have on the CI. Will look into updating this one. But in any case it would be best if the configuration file could have this setting so formatting works the same for all contributors.
* Improve MAM loading string.Martin Dosch2022-10-221-1/+1
| | | | | Replaced three dots `...` by a proper ellipsis `…`. Removed plenking (space between `messages` and ellipsis.
* Fix segfault when loading from MAMMarcoPolo-PasTonMolo2022-10-221-2/+13
| | | | | | When loading messages from MAM profanity would segfault. Reason was that we were freeing the timestamp of messages when displaying them and we needed it for loading MAM.
* Apply codigng style on new MAM codeMichael Vetter2022-10-215-9/+9
|
* Let users scroll up againMichael Vetter2022-10-211-4/+0
| | | | | | | | | | | | We removed this so that we don't get "[SCROLLED]" in the titlebar when there is actually not more text available. But now with MAM we can enable this again so that the user can scroll up and load more text out of the database. Maybe this also could use a check. This reverts commit c84b1b5e5d038684a6a475a251b738c3c5ffb9a5.
* Fix merge mistake in databaseMichael Vetter2022-10-211-1/+1
| | | | | When doing 3bdc14dbcf1114fa1ea68cd6f455eecf90a9ac5e I forgot an `,` before encryption
* Fix GSList handling in new MAM codePaul Fertser2022-10-211-13/+8
| | | | | This patch was provided by @paulfertser and applied by @jubalh. Thanks a lot Paul!
* Fix merge mistakeMichael Vetter2022-10-211-1/+1
|
* Merge MAM improvements from #1724Michael Vetter2022-10-2113-63/+494
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I think this PR already solves and improves the MAM situation a lot. What's @MarcoPolo-PasTonMolo still wanted to do in this branch is: * MAM for mucs * Check if url and quotes autocompletion works fine * Check if the api still works fine * Resolve conflicts Conflicts are solved with this commit. MAM for mucs can be another feature PR. The rest we can check while being on master. And more people can help testing.
| * Don't notify on MAM messagesMarcoPolo-PasTonMolo2022-08-201-7/+10
| |
| * Handle late deliveryMarcoPolo-PasTonMolo2022-08-205-27/+109
| |