about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorHiltjo Posthuma <hiltjo@codemadness.org>2017-11-03 16:36:32 +0100
committerHiltjo Posthuma <hiltjo@codemadness.org>2017-11-03 21:14:58 +0100
commit99f78fa553f9ddb23fab73e47a408d66ca7f974c (patch)
tree3e03dccedc131f19a9e9916b1cf0111016f80f5d
parenta9b6a312a77b9cc81ca8b08a95c09e9f7948d7a6 (diff)
downloaddwm-99f78fa553f9ddb23fab73e47a408d66ca7f974c.tar.gz
gettextprop: check result of XGetTextProperty (undefined behaviour for XFree)
-rw-r--r--dwm.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/dwm.c b/dwm.c
index b0d99c0..650d19f 100644
--- a/dwm.c
+++ b/dwm.c
@@ -910,8 +910,7 @@ gettextprop(Window w, Atom atom, char *text, unsigned int size)
 	if (!text || size == 0)
 		return 0;
 	text[0] = '\0';
-	XGetTextProperty(dpy, w, &name, atom);
-	if (!name.nitems)
+	if (!XGetTextProperty(dpy, w, &name, atom) || !name.nitems)
 		return 0;
 	if (name.encoding == XA_STRING)
 		strncpy(text, (char *)name.value, size - 1);