about summary refs log tree commit diff stats
path: root/src/js/fromjs.nim
diff options
context:
space:
mode:
authorbptato <nincsnevem662@gmail.com>2023-10-21 23:44:40 +0200
committerbptato <nincsnevem662@gmail.com>2023-10-21 23:45:57 +0200
commit28473c9e9a44567642785901f6fe198968a99db9 (patch)
tree94f22d429181124f25ba04a95722dd73f4b08552 /src/js/fromjs.nim
parent8e49de968fded9d43230e03beaaa4f9bd59b5dea (diff)
downloadchawan-28473c9e9a44567642785901f6fe198968a99db9.tar.gz
fromJSInt: do not fail if not IsNumber
to match standard behavior (e.g. accept null as int, etc)
Diffstat (limited to 'src/js/fromjs.nim')
-rw-r--r--src/js/fromjs.nim2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/js/fromjs.nim b/src/js/fromjs.nim
index 80fdc1cd..eb03af40 100644
--- a/src/js/fromjs.nim
+++ b/src/js/fromjs.nim
@@ -59,8 +59,6 @@ func fromJSString2(ctx: JSContext, val: JSValue): JSResult[JSString] =
 
 func fromJSInt[T: SomeInteger](ctx: JSContext, val: JSValue):
     JSResult[T] =
-  if not JS_IsNumber(val):
-    return err()
   when T is int:
     # Always int32, so we don't risk 32-bit only breakage.
     # If int64 is needed, specify it explicitly.