Rework broken non-blocking io

Piped input works correctly again!
(Also fix hash's setter not working with url's without a fragment)

1 files changed, 3 insertions, 1 deletions

diff --git a/src/types/url.nim b/src/types/url.nim
index fc9e20e8..f77faec1 100644
--- a/src/types/url.nim
+++ b/src/types/url.nim
@@ -702,6 +702,7 @@ proc basicParseUrl*(input: string, base = none(Url), url: Url = Url(), stateOver
       #TODO encoding
       if not has or (not override and c == '#'):
         let querypercentencodeset = if url.is_special: SpecialQueryPercentEncodeSet else: QueryPercentEncodeSet
+        if url.query.isNone: url.query = some("")
         url.query.get.percentEncode(buffer, querypercentencodeset)
         buffer = ""
         if has and c == '#':
@@ -715,6 +716,7 @@ proc basicParseUrl*(input: string, base = none(Url), url: Url = Url(), stateOver
       if has:
         #TODO If c is not a URL code point and not U+0025 (%), validation error.
         #TODO If c is U+0025 (%) and remaining does not start with two ASCII hex digits, validation error.
+        if url.fragment.isNone: url.fragment = some("")
         url.fragment.get.percentEncode(c, FragmentPercentEncodeSet)
     inc pointer
   return url.some
@@ -950,7 +952,7 @@ proc set*(params: URLSearchParams, name: string, value: string) {.jsfunc.} =
 proc newURL*(url: URL): URL =
   new(result)
   result[] = url[]
-  if url.searchParams != nil: #TODO ideally this should never be false
+  if url.searchParams != nil: #TODO ideally this would never be false
     result.searchParams = URLSearchParams()
     result.searchParams[] = url.searchParams[]
     result.searchParams.url = some(result)