about summary refs log tree commit diff stats
path: root/text_tests.lua
diff options
context:
space:
mode:
authorKartik K. Agaram <vc@akkartik.com>2023-06-01 22:12:12 -0700
committerKartik K. Agaram <vc@akkartik.com>2023-06-01 22:12:12 -0700
commitcdef37c4191e48228d1ea83eb590e1f3109e3c8b (patch)
treefb7546965cbf9d7d4ce83b2c7aa71509dfcce685 /text_tests.lua
parent9b27a4d816bbfc23f122698e65f660d89c7664e4 (diff)
downloadlines.love-cdef37c4191e48228d1ea83eb590e1f3109e3c8b.tar.gz
get rid of recent_mouse
It's a hack:
  - if you start selecting from below final line the start of the
    selection is the most recent click even if it was forever ago
  - (the crash we're currently fixing) if you start up and immediately
    select all then click below final line => crash. recent_mouse was
    never set.
  - getting rid of it breaks no tests (except the crash we're currently
    fixing)
Diffstat (limited to 'text_tests.lua')
-rw-r--r--text_tests.lua46
1 files changed, 23 insertions, 23 deletions
diff --git a/text_tests.lua b/text_tests.lua
index bd449ac..eec3098 100644
--- a/text_tests.lua
+++ b/text_tests.lua
@@ -904,29 +904,29 @@ function test_select_all_text()
   check_eq(Editor_state.cursor1.pos, 8, 'cursor:pos')
 end
 
-function test_select_all_text_then_mouse_press_outside_text()
-  -- display a single line of text
-  App.screen.init{width=75, height=80}
-  Editor_state = edit.initialize_test_state()
-  Editor_state.lines = load_array{'abc def'}
-  Text.redraw_all(Editor_state)
-  Editor_state.cursor1 = {line=1, pos=1}
-  Editor_state.screen_top1 = {line=1, pos=1}
-  Editor_state.screen_bottom1 = {}
-  edit.draw(Editor_state)
-  -- select all
-  App.fake_key_press('lctrl')
-  edit.run_after_keychord(Editor_state, 'C-a')
-  App.fake_key_release('lctrl')
-  edit.key_release(Editor_state, 'lctrl')
-  -- selection
-  check_eq(Editor_state.selection1.line, 1, 'selection:line')
-  check_eq(Editor_state.selection1.pos, 1, 'selection:pos')
-  check_eq(Editor_state.cursor1.line, 1, 'cursor:line')
-  check_eq(Editor_state.cursor1.pos, 8, 'cursor:pos')
-  -- part of a mouse click outside the selected line
-  edit.run_after_mouse_press(Editor_state, 45, Margin_top + Editor_state.line_height + 10, --[[mouse button]] 1)
-end
+--? function test_select_all_text_then_mouse_press_outside_text()
+--?   -- display a single line of text
+--?   App.screen.init{width=75, height=80}
+--?   Editor_state = edit.initialize_test_state()
+--?   Editor_state.lines = load_array{'abc def'}
+--?   Text.redraw_all(Editor_state)
+--?   Editor_state.cursor1 = {line=1, pos=1}
+--?   Editor_state.screen_top1 = {line=1, pos=1}
+--?   Editor_state.screen_bottom1 = {}
+--?   edit.draw(Editor_state)
+--?   -- select all
+--?   App.fake_key_press('lctrl')
+--?   edit.run_after_keychord(Editor_state, 'C-a')
+--?   App.fake_key_release('lctrl')
+--?   edit.key_release(Editor_state, 'lctrl')
+--?   -- selection
+--?   check_eq(Editor_state.selection1.line, 1, 'selection:line')
+--?   check_eq(Editor_state.selection1.pos, 1, 'selection:pos')
+--?   check_eq(Editor_state.cursor1.line, 1, 'cursor:line')
+--?   check_eq(Editor_state.cursor1.pos, 8, 'cursor:pos')
+--?   -- part of a mouse click outside the selected line
+--?   edit.run_after_mouse_press(Editor_state, 45, Margin_top + Editor_state.line_height + 10, --[[mouse button]] 1)
+--? end
 
 function test_cut_without_selection()
   -- display a few lines