about summary refs log tree commit diff stats
path: root/text_tests.lua
Commit message (Collapse)AuthorAgeFilesLines
* fix all tests in LÖVE v12Kartik K. Agaram2023-10-091-3/+10
| | | | | | | | | | | | | | | | This is all quite hacky. Many of my tests are unfortunately brittle to changes in text rendering. Fortunately there's only one test that currently requires a hacky special case (and a second test I tweaked slightly to be more robust). I can't think of a better approach. It doesn't help to standardize the font, because version changes still come with changes to text-shaping algorithms even if the font itself is unchanged. I could base all my assertions on the widths of individual characters, but that would make the tests much less readable and not express intent as clearly. So here we are, with hopefully just a few hacky special cases (there might be a few more as LÖVE v12 advances towards publication, and in further versions).
* bugfix: clear selection when clicking above or below linesKartik K. Agaram2023-09-201-0/+24
| | | | | | | | | | | | | | | | | | | Matt Wynne pointed out that snap.love would crash when a node went off screen. While debugging it I noticed that selection1 was being set when it shouldn't be. Turns out I introduced a bug when I fixed the inscript bug back in June (commit 9656e137742). One invariant I want to preserve is: selection1 should be unset after a mouse click (press and release without intervening drag). This invariant was violated in my bugfix back in June. I was concerned only with selection back then, and I didn't realize I was breaking the mouse click case (in a fairly subtle way; you can have selection set, and when it's set identically to the cursor everything looks the same). I think there might still be an issue in snap.love after this fix. I noticed screen_bottom1.pos was nil, and as far as I recall that should never happen.
* bugfix: inscript's bugKartik K. Agaram2023-06-041-0/+27
| | | | | | | | | | To fix this I have to first stop incrementally updating screen_bottom1 in the middle of a frame. Now it always has a good value from the end of a frame. I'm also running into some limitations in the test I'd ideally like to write (that are documented in a comment), but I still get some sort of automated test for this bugfix.
* handle wrapping linesKartik K. Agaram2023-06-031-0/+17
|
* change how we handle clicks above top marginKartik K. Agaram2023-06-031-24/+19
|
* get rid of recent_mouseKartik K. Agaram2023-06-011-23/+23
| | | | | | | | | | | It's a hack: - if you start selecting from below final line the start of the selection is the most recent click even if it was forever ago - (the crash we're currently fixing) if you start up and immediately select all then click below final line => crash. recent_mouse was never set. - getting rid of it breaks no tests (except the crash we're currently fixing)
* failing test now looks realisticKartik K. Agaram2023-06-011-0/+46
|
* bugfix: searching files containing unicodeKartik K. Agaram2023-05-131-10/+10
| | | | | Before this change the cursor was moving, but not being highlighted properly when the cursor line contained unicode before the cursor.
* avoid saving fragments in linesKartik K. Agaram2023-04-011-1/+1
| | | | | | | Now we render lines one screen line at a time rather than one word at a time. I can't port the source side just yet; I need to fix hyperlinks first..
* give a test a unique nameKartik K. Agaram2023-03-191-3/+3
|
* bugfixKartik K. Agaram2023-03-171-0/+22
| | | | Thanks Mikoláš Štrajt.
* bugfix: up arrow when line above is a drawingKartik K. Agaram2023-01-311-0/+50
| | | | This bug was introduced in commit 528c64d690 on 2022-09-05 :/
* deduce test names on failuresKartik K. Agaram2023-01-201-533/+438
|
* overzealous search-and-replaceKartik K. Agaram2022-12-231-1/+1
|
* make love event names consistentKartik K. Agaram2022-12-231-22/+22
| | | | | I want the words to be easy to read, and to use a consistent tense. update and focus seem more timeless; let's make everything like those.
* streamline one more test nameKartik K. Agaram2022-12-131-14/+14
|
* more streamlined test namesKartik K. Agaram2022-12-131-29/+29
| | | | https://lobste.rs/messages/e1rimy
* remove a duplicate testKartik K. Agaram2022-12-131-27/+10
|
* bugfix: check after cursor on same line when searching upwardsKartik K. Agaram2022-08-111-0/+19
|
* bugfix: search upwardsKartik K. Agaram2022-08-111-0/+19
|
* bugfix: check before cursor on same lineKartik K. Agaram2022-08-111-0/+19
|
* bugfix: pagedown was sometimes bouncing upKartik K. Agaram2022-08-101-0/+17
|
* bugfix: backspace from start of final lineKartik K. Agaram2022-08-101-0/+16
|
* click to the left of a lineKartik K. Agaram2022-07-291-0/+19
|
* line.y -> line_cache.starty in a few more placesKartik K. Agaram2022-07-271-4/+4
| | | | | | Disquieting that none of my tests caught these. On the other hand, I also haven't noticed any issues in practice. Perhaps cache invalidation is often unnecessary.
* bugfix: skip over drawings when searchingKartik K. Agaram2022-07-251-7/+2
|
* bugfix: searchKartik K. Agaram2022-07-211-0/+33
| | | | | Broken since commit 188bbc73 9 days ago :/ At least we have a test for it now.
* bugfix: where cursor is drawnKartik K. Agaram2022-07-201-10/+10
| | | | | | | The published version of lines.love was broken for almost an hour. The cursor would render one position to the right of where it really is. To fix it, this commit rolls back 26ba6e4e5a71. There doesn't seem a good way to test it.
* exclude left margin from my word-split heuristicKartik K. Agaram2022-07-201-2/+2
| | | | | Gratifying how few tests need changing. Recent commits seem on the right track.
* allow Text.nearest_pos_less_than to return 0Kartik K. Agaram2022-07-201-2/+2
| | | | This eliminates another case of overflowing margins.
* unify two similar functionsKartik K. Agaram2022-07-191-13/+12
| | | | | | The cost is just having to tweak a few more brittle tests. I can't actually perceive any difference in how the cursor moves when I click on text.
* keep text from overflowing right marginKartik K. Agaram2022-07-191-36/+33
| | | | | | | | | | I've been sloppy about this so far, and outside of tests I can't find any examples where it matters, but it matters in a potential fork where I'm rendering multiple columns of text. It's unfortunate that my tests have this level of brittleness. What I'd really like to assert in many of these changed lines is that the text stays inside the margins and that more text would overflow margins.
* delete some duplicate initializationKartik K. Agaram2022-07-191-4/+0
|
* bugfix: couple of margin-relative computationsKartik K. Agaram2022-07-171-1/+61
|
* separate data structure for each line's cache dataKartik K. Agaram2022-07-171-12/+96
| | | | I have no idea what the performance implications of this are..
* bring back a set of constantsKartik K. Agaram2022-07-161-1/+1
| | | | | It's starting to sink in that I don't want hard-coded constants inside objects.
* more decoupling editor tests from AppKartik K. Agaram2022-07-161-1/+1
|
* more decoupling editor tests from AppKartik K. Agaram2022-07-161-3/+3
|
* make test initializations a little more obviousKartik K. Agaram2022-07-151-93/+93
|
* left/right margin -> left/right coordinatesKartik K. Agaram2022-07-121-121/+214
| | | | | Editor state initialization now depends on window dimensions, so we have to more carefully orchestrate startup.
* call edit rather than App callbacks in testsKartik K. Agaram2022-07-121-101/+101
|
* start passing in Editor_state explicitlyKartik K. Agaram2022-07-121-76/+77
| | | | | | | | | | | | In this commit, top-level edit functions: - edit.draw - edit.update - edit.quit - edit.mouse_pressed - edit.mouse_released - edit.textinput - edit.keychord_pressed - edit.key_released
* initialize contains test stateKartik K. Agaram2022-07-121-87/+0
|
* group all editor globalsKartik K. Agaram2022-07-121-877/+877
| | | | We're still accessing them through a global. But we'll change that next.
* start decoupling editor tests from AppKartik K. Agaram2022-07-111-76/+76
|
* skip multiple consecutive whitespaceKartik K. Agaram2022-07-111-0/+22
|
* support other whitespace chars in word movementsKartik K. Agaram2022-07-111-0/+22
|
* flesh out some tests for word movementsKartik K. Agaram2022-07-111-0/+125
|
* yet another bugfix in selection managementKartik K. Agaram2022-07-071-18/+1
| | | | | | | | | | Thanks Leonard Schütz for the report! Failing scenario: click to move cursor hit backspace First backspace wasn't being doing anything earlier.
* bugfix: clicking on empty linesKartik K. Agaram2022-07-011-0/+16
|
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-06-23 19:15:32 +0000