about summary refs log tree commit diff stats
path: root/src/teliva.c
diff options
context:
space:
mode:
authorKartik K. Agaram <vc@akkartik.com>2022-03-16 21:19:19 -0700
committerKartik K. Agaram <vc@akkartik.com>2022-03-16 21:19:19 -0700
commitef5195dee92732408466a9cc8dd48a63ff46667b (patch)
tree346f9c430006760a32f79ef50b40a6b78669e4d2 /src/teliva.c
parent182408ec548dd6f5dc816bf5c8fdcc8c7597fb6d (diff)
downloadteliva-ef5195dee92732408466a9cc8dd48a63ff46667b.tar.gz
simplify function call instrumentation
src/ldo.c now has a minimal diff with Lua 5.1.

It might be a bit slower than it was before, but not noticeably so..

This approach doesn't support indirect calls.
Diffstat (limited to 'src/teliva.c')
-rw-r--r--src/teliva.c25
1 files changed, 19 insertions, 6 deletions
diff --git a/src/teliva.c b/src/teliva.c
index 1bc06d5..3d20267 100644
--- a/src/teliva.c
+++ b/src/teliva.c
@@ -13,6 +13,9 @@
 #include "lua.h"
 #include "lauxlib.h"
 #include "lualib.h"
+
+#undef getstr
+#include "lstate.h"
 #include "teliva.h"
 #include "tlv.h"
 
@@ -341,11 +344,21 @@ static void save_caller_as(lua_State* L, const char* name, const char* caller_na
   lua_pop(L, 1);  // table of caller tables
 }
 
-void save_caller(lua_State* L, const char* name, int call_graph_depth) {
-  lua_Debug ar;
-  lua_getstack(L, 1, &ar);
-  lua_getinfo(L, "n", &ar);
-  if (ar.name) save_caller_as(L, name, ar.name);
+void record_metadata_about_function_call (lua_State *L, CallInfo *ci) {
+  lua_Debug f;
+  lua_getstack(L, 0, &f);
+  lua_getinfo(L, "n", &f);
+  long int call_depth = ci - L->base_ci;
+  /* note to self: the function pointer is at ci_func(ci) */
+  if (f.name) {
+    assign_call_graph_depth_to_name(L, call_depth, f.name);
+    if (call_depth <= 1) return;
+    lua_Debug caller_f;
+    lua_getstack(L, 1, &caller_f);
+    lua_getinfo(L, "n", &caller_f);
+    if (caller_f.name)
+      save_caller_as(L, f.name, caller_f.name);
+  }
 }
 
 static void clear_caller(lua_State* L) {
@@ -496,7 +509,7 @@ restart:
   y += 2;
   mvprintw(y, 0, "functions: ");
   y++;
-  for (int depth = /*ignore call_main*/2; ; ++depth) {
+  for (int depth = /*ignore callers of main*/3; ; ++depth) {
     mvaddstr(y, 0, "                ");
     bool drew_anything = false;
     index_within_level = 0;