diff options
author | Kartik K. Agaram <vc@akkartik.com> | 2022-06-14 08:15:51 -0700 |
---|---|---|
committer | Kartik K. Agaram <vc@akkartik.com> | 2022-06-14 08:15:51 -0700 |
commit | e38bec4f46023990373f32009a77a137cc9ee5b5 (patch) | |
tree | 9e907c91e5ff95581159bf9cc0f5dba61cebdc1b /manual_tests | |
parent | b97daf7733d5f1e0993b1a506c0d5b00406b561f (diff) | |
download | text.love-e38bec4f46023990373f32009a77a137cc9ee5b5.tar.gz |
go through and fix similar issues
All places where string.sub was being passed a _pos variable.
Diffstat (limited to 'manual_tests')
-rw-r--r-- | manual_tests | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/manual_tests b/manual_tests index 8ca2893..4fbe02d 100644 --- a/manual_tests +++ b/manual_tests @@ -1,3 +1,10 @@ +-- static properties of the code +All strings are UTF-8. Bytes within them are not characters. +I try to label byte offsets as _offset, and character positions as _pos. +For example, string.sub should never use a _pos to substring, only an _offset. +Wish I had some static typing here. We're not going to try to write tests to catch issues like this. + +-- manual tests file load: cursor_line = 1 first line is a drawing -> cursor_line = 2 |