about summary refs log tree commit diff stats
path: root/edit.lua
Commit message (Collapse)AuthorAgeFilesLines
* handle wrapping linesKartik K. Agaram2023-06-031-2/+2
|
* change how we handle clicks above top marginKartik K. Agaram2023-06-031-0/+11
|
* get rid of recent_mouseKartik K. Agaram2023-06-011-4/+0
| | | | | | | | | | | It's a hack: - if you start selecting from below final line the start of the selection is the most recent click even if it was forever ago - (the crash we're currently fixing) if you start up and immediately select all then click below final line => crash. recent_mouse was never set. - getting rid of it breaks no tests (except the crash we're currently fixing)
* idea: set recent_mouse on mouse eventsKartik K. Agaram2023-06-011-1/+2
| | | | | This helps, but doesn't address the C-a case. As it stands, literally my first click of the mouse might need access to recent_mouse.line/pos
* ah, I see the problemKartik K. Agaram2023-06-011-7/+7
| | | | | | | Text.mouse_pos can sometimes set recent_mouse.time but not recent_mouse.x/y. I'd assumed x/y is never nil in those situations, but that's violated. It's most easily seen when typing C-a and then clicking.
* some temporary logging to catch a bugKartik K. Agaram2023-06-011-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The bug has been spotted twice: 1. In snap.love, I selected text in one node, then another, and hit: Error: text.lua:789: attempt to compare nil with number stack traceback: text.lua:789: in function 'lt1' select.lua:19: in function 'clip_selection' text.lua:32: in function 'draw' edit.lua:117: in function 'draw' [string "REPL"]:21: in function 'draw' main.lua:152: in function 'draw' app.lua:102: in function <app.lua:84> [C]: in function 'xpcall' app.lua:112: in function <app.lua:111> [C]: in function 'xpcall' Couldn't reproduce. 2. In text.love, inscript selected all text in a small buffer and then clicked outside the text. And got: Error: text.lua:784: attempt to compare nil with number Traceback [love "callbacks.lua"]:228: in function 'handler' text.lua:784: in function 'lt1' select.lua:19: in function 'clip_selection' text.lua:27: in function 'draw' edit.lua:117: in function 'draw' run.lua:136: in function 'draw' main.lua:148: in function 'draw' app.lua:42: in function <app.lua:22> [C]: in function 'xpcall' This is reproducible, and also across forks.
* enhance bugfix of commit a9aa3436f (Dec 2024)Kartik K. Agaram2023-04-081-1/+1
| | | | | | | | | | | | Scenario: * start out with some text on screen * select some text A, delete * select some more text B, delete * press C-z twice to restore A and B * press C-y twice Before this commit only the first C-y was having an effect (deleting B). The second was failing to delete A.
* switch source side to new screen-line-based renderKartik K. Agaram2023-04-031-1/+0
| | | | Also copy over the implementation of links from pensieve.love.
* streamline the interface for Text.drawKartik K. Agaram2023-04-021-1/+0
|
* update documentation on fragmentsKartik K. Agaram2023-04-011-1/+1
| | | | | | I see a path to at least maintain a single fragment per screen line. But can we do better? It even seems unnecessary to maintain two copies of the data, chopped up into lines and screen lines.
* no more Text allocationsKartik K. Agaram2023-04-011-1/+0
| | | | Is it just my imagination, or does the app feel lighter and more fluffy?
* App.width can no longer take a TextKartik K. Agaram2023-04-011-7/+0
| | | | | In the process I discovered the horrible fact that Text.x allocates a new Text. And it gets called (just once, thank goodness) on every single frame.
* bugfix: naming pointsKartik K. Agaram2023-03-261-4/+5
|
* bugfixKartik K. Agaram2023-03-261-4/+6
|
* bugfixKartik K. Agaram2023-03-261-2/+4
| | | | | | | | | | | | | | | | | | scenario: open a file starting with a drawing After this commit the program doesn't crash. Error: [string "edit.lua"]:127: attempt to get length of field 'data' (a nil value) stack traceback: [love "boot.lua"]:345: in function '__len' [string "edit.lua"]:127: in function 'invalid1' [string "edit.lua"]:116: in function 'check_locs' [string "run.lua"]:35: in function 'initialize' main.lua:96: in function 'initialize' [string "app.lua"]:144: in function 'run_tests_and_initialize' [string "app.lua"]:16: in function <[string "app.lua"]:13> [C]: in function 'xpcall' [love "boot.lua"]:361: in function <[love "boot.lua"]:348> [C]: in function 'xpcall'
* clean up some absolute coordinatesKartik K. Agaram2023-03-251-1/+1
|
* some minor cleanupKartik K. Agaram2023-03-231-1/+1
| | | | | I can't see the mouse wheel ever setting dx, but it's more obvious now that the editor doesn't support panning left/right.
* mouse wheel supportKartik K. Agaram2023-03-231-0/+14
|
* move default file locationKartik K. Agaram2023-03-181-1/+1
| | | | | | | | This works better on mobile platforms while seeming about as useful anywhere else. I've verified that anyone who already edited a file will continue to use its path from settings.
* bring a few things in sync between run and sourceKartik K. Agaram2023-03-171-1/+4
|
* bugfix: disallow font size of 0Kartik K. Agaram2023-03-171-2/+4
| | | | Thanks Mikoláš Štrajt.
* more robust state validationKartik K. Agaram2023-03-171-2/+24
|
* bugfixKartik K. Agaram2023-02-091-0/+1
| | | | | | | | | | | scenario: press ctrl+f, type in a string hit down arrow if needed until the screen scrolls press enter click with the mouse somewhere Before this commit the app would crash because cursor was above screen top.
* wait a little to flush disk before quittingKartik K. Agaram2023-01-281-0/+2
| | | | | | | I've been noticing in pensieve.love in particular that once a month or so I lose data if I quit immediately after typing in something. Nothing major, just the odd link between notes which leaves things in an inconsistent state. Let's see if this helps.
* bugfixKartik K. Agaram2022-12-241-1/+1
| | | | | | | | | | | Scenario: make some edits, select some text, make some more edits. Press ctrl-z. Before this commit, undo would stop at the point of selection and previous edits would become unreachable. After this commit, both ctrl-z and ctrl-y seem able to span the point of selection.
* typoKartik K. Agaram2022-12-241-1/+1
|
* consistent names in a few more placesKartik K. Agaram2022-12-231-4/+4
|
* make love event names consistentKartik K. Agaram2022-12-231-19/+19
| | | | | I want the words to be easy to read, and to use a consistent tense. update and focus seem more timeless; let's make everything like those.
* require editor margins to be intsKartik K. Agaram2022-12-231-2/+2
| | | | | | | | | | | | Not directly relevant here, but forks of this project that permit zooming can run into weird glitches if margins are not a whole number of pixels. I'd always assumed a type system that divided ints into floats was strictly superior, but now I have experienced a situation where requiring ints isn't just a compromise for the underlying CPU implementation. Particularly since Lua's print() silently hides really tiny fractions.
* bugfix in changing shape mid-strokeKartik K. Agaram2022-12-121-2/+5
|
* bugfix: naming points in drawingsKartik K. Agaram2022-12-121-1/+6
| | | | | | | | | We had a regression since commit 60e1023f0 on Nov 27. Turns out we do need the ancient hack after all. But no, we won't go back to the hack. It's a simple problem to fix right. And while we're at it, we'll fix the test harness to be more realistic so it would have caught this problem.
* bugfixKartik K. Agaram2022-11-271-1/+1
|
* ctrl+a: select entire bufferKartik K. Agaram2022-11-191-1/+4
|
* stop tracking wallclock timeKartik K. Agaram2022-11-031-2/+2
| | | | We only need time differences.
* bugfix: path munging on WindowsKartik K. Agaram2022-09-101-1/+1
|
* self-documenting 0 Test_right_marginKartik K. Agaram2022-09-071-1/+4
|
* support drawings in the source editorKartik K. Agaram2022-09-051-3/+5
|
* editing source code from within the appKartik K. Agaram2022-09-031-9/+0
| | | | | integrated from pong.love via text.love: https://merveilles.town/@akkartik/108933336531898243
* infrastructure for caching LÖVE text objectsKartik K. Agaram2022-08-241-0/+1
|
* flip return value of button handlersKartik K. Agaram2022-08-231-2/+1
| | | | | | This is compatible with Javascript, and it also seems like a better default; when people forget to think about return values in click handlers, they should be consumed.
* stop putting button state in a globalKartik K. Agaram2022-08-231-2/+3
| | | | | | | | | | | | | | | | Symptom: a test (test_click_to_create_drawing) started randomly failing after I inserted a `return` 2 commits ago. Cause: my tests call edit.draw, but button handlers only get cleared in app.draw. So my tests weren't clearing button handlers, and every call to edit.draw was accumulating states. Still unclear why those were going to different state objects after the `return`, but anyway. I'm not going to understand every last thing that happens when things go wrong, just guarantee they can't go wrong. And the way to do that is to decentralize button handlers to each state that receives them. The State object in buttons.lua doesn't have to be Editor_state. It just has to be some table that provides a Schelling Point for shared state.
* allow buttons to interrupt eventsKartik K. Agaram2022-08-231-1/+5
| | | | Most button onpress1 handlers will want to return true.
* distinguish consistently between mouse buttons and other buttonsKartik K. Agaram2022-08-231-11/+11
|
* subsection headings in a long switchKartik K. Agaram2022-08-181-0/+2
|
* simplify cursor-on-screen checkKartik K. Agaram2022-08-171-5/+3
|
* remove some duplicationKartik K. Agaram2022-08-141-6/+4
|
* bugfix: obsolete location for attributeKartik K. Agaram2022-08-141-2/+2
|
* click to the left of a lineKartik K. Agaram2022-07-291-2/+4
|
* copying to clipboard can never scrollKartik K. Agaram2022-07-271-1/+0
|
* line.y -> line_cache.starty in a few more placesKartik K. Agaram2022-07-271-8/+8
| | | | | | Disquieting that none of my tests caught these. On the other hand, I also haven't noticed any issues in practice. Perhaps cache invalidation is often unnecessary.
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-11-20 13:30:21 +0000