about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
* Merge text.loveKartik K. Agaram2024-02-048-168/+168
|\
| * Merge lines.loveKartik K. Agaram2024-02-048-192/+192
| |\
| | * fix yet another placeKartik K. Agaram2024-02-041-3/+3
| | |
| | * more realism in one more helperKartik K. Agaram2024-02-042-5/+5
| | |
| | * bugfix: don't clear selection on M-arrowKartik K. Agaram2024-02-041-1/+1
| | | | | | | | | | | | | | | | | | | | | We now treat all arrow chords as cursor movement. Many thanks to Ryan Kessler (https://tone.support) for reporting this issue.
| | * more carefully pass the 'key' arg aroundKartik K. Agaram2024-02-045-188/+188
| | |
* | | Merge text.loveKartik K. Agaram2024-01-1512-72/+71
|\| |
| * | Merge lines.loveKartik K. Agaram2024-01-1512-72/+71
| |\|
| | * use editor state font for width calculationsKartik K. Agaram2024-01-129-71/+67
| | |
| | * don't save settings on error in source editorKartik K. Agaram2024-01-123-2/+3
| | |
| | * fix still more issues with the previous scenarioKartik K. Agaram2024-01-122-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - source editor always expects relative paths - refresh mocked data There's still one issue after this: the font size saved in the config file is the one we use in tests. More broadly, Editor_state is completely wrong. Ideally I'd just not save any settings for the source editor if the tests fail.
| | * clean up test mocks before abortingKartik K. Agaram2024-01-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Scenario: modify a test to fail in the source editor delete any settings in the 'config' file in the save dir start lines.love press C-e to switch to source editor Before this commit, this scenario led to the following events: the C-e keypress invokes App.run_tests_and_initialize() the failing test results in a call to error() the call to error() is trapped by the xpcall around the event handler in love.run handle_error runs Current_app is 'source', so love.event.quit() is triggered love.quit() is invoked source.settings() is invoked App.screen.position() is invoked, which calls the test mock Since App.screen.move was never invoked, App.screen.position() returns nil The 'config' file is written without values for source.x and source.y As a result, future runs fail to open. This is likely a corner case only I will ever run into, since I'm careful to never commit failing unit tests. Still, I spent some time trying to figure out the best place to fix this. Options: * don't write config if Error_message is set but we do want config written in this scenario: * we hit an error, source editor opens * we spend some time debugging and don't immediately fix the issue * we quit, with some new files opened in various places * hardcode source.settings() to call love.window.getPosition() rather than App.screen.position(). drawback: weird special case * clean up test mocks before aborting this seems like something we always want I'm not very sure of my choice. This bug doesn't leave me feeling very great about my whole app. Arguably everything I've done is bullshit hacks piled on hacks. Perhaps the issue is: - naked error() in LÖVE apps never invokes love.quit(), but - an unhandled error within my handle_error invokes love.quit() (via love.event.quit) Perhaps LÖVE should provide a way to abort without invoking the quit handler. There's literally no other way in LÖVE to request a quit.
* | | Merge text.loveKartik K. Agaram2023-12-296-23/+25
|\| |
| * | Merge lines.loveKartik K. Agaram2023-12-296-23/+25
| |\|
| | * moar bugfix X-(Kartik K. Agaram2023-12-292-2/+2
| | |
| | * bugfixKartik K. Agaram2023-12-296-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | scenario: run without config file, quit, run again expected: font size remains the same on second run Before this commit it was increasing on each run. It turns out the font height that you pass into love.graphics.newFont() is not the result of font:getHeight().
| | * update docKartik K. Agaram2023-12-291-1/+1
| | |
| | * pull font into editorKartik K. Agaram2023-12-295-23/+23
| | | | | | | | | | | | | | | Now it adjusts the current font for itself. And it's up to the caller to adjust the current font after.
* | | Merge text.loveKartik K. Agaram2023-12-262-2/+4
|\| |
| * | Merge lines.loveKartik K. Agaram2023-12-262-2/+4
| |\|
| | * bugfix: utf-8Kartik K. Agaram2023-12-262-2/+4
| | |
* | | Merge text.loveKartik K. Agaram2023-12-191-3/+6
|\| |
| * | Merge lines.loveKartik K. Agaram2023-12-191-3/+6
| |\|
| | * document a missing editor APIKartik K. Agaram2023-12-191-3/+6
| | |
* | | Merge text.loveKartik K. Agaram2023-12-183-13/+14
|\| |
| * | Merge lines.loveKartik K. Agaram2023-12-183-13/+14
| |\|
| | * bugfix :(Kartik K. Agaram2023-12-181-1/+1
| | |
| | * make button backgrounds optionalKartik K. Agaram2023-12-183-12/+13
| | |
* | | Merge text.loveKartik K. Agaram2023-12-182-3/+7
|\| |
| * | Merge lines.loveKartik K. Agaram2023-12-182-3/+7
| |\|
| | * add a helper and update some docsKartik K. Agaram2023-12-182-3/+7
| | |
* | | Merge text.loveKartik K. Agaram2023-12-165-10/+6
|\| |
| * | Merge lines.loveKartik K. Agaram2023-12-165-10/+6
| |\|
| | * streamline button.luaKartik K. Agaram2023-12-166-11/+7
| | |
* | | Merge text.loveKartik K. Agaram2023-12-092-4/+2
|\| |
| * | Merge lines.loveKartik K. Agaram2023-12-092-4/+2
| |\|
| | * fix a couple of asserts missed in the recent auditKartik K. Agaram2023-12-093-5/+2
| | |
* | | Merge text.loveKartik K. Agaram2023-12-072-4/+9
|\| |
| * | Merge lines.loveKartik K. Agaram2023-12-072-4/+9
| |\|
| | * copy correct warning messageKartik K. Agaram2023-12-071-1/+6
| | | | | | | | | | | | Not really useful here, but other forks might make use of it.
| | * minor tweaks to manual tests while pushing to all forksKartik K. Agaram2023-12-071-3/+3
| | |
* | | Merge text.loveKartik K. Agaram2023-12-064-40/+100
|\| |
| * | Merge lines.loveKartik K. Agaram2023-12-064-40/+100
| |\|
| | * hide some details within the 'warning' stateKartik K. Agaram2023-12-061-27/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Renamed from the 'error' state. Now we no longer overload Error_message; it's only used for actual errors that trigger opening the source editor. I was tempted to hide Skip_rest_of_key_events inside the 'warning' state as well, but that isn't right. It applies to all Current_app transitions, not just those in and out of 'warning'.
| | * redo version checks yet againKartik K. Agaram2023-12-063-19/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm starting to feel better after replacing 1 line with 20 and 2 new bits of global state. I'm now handling two scenarios more explicitly: * If I change Current_app within key_press, the corresponding text_input and key_release events go to the new app. If it's an editor it might insert the key, which is undesirable. Putting such handlers in key_release now feels overly clever, particularly since it took me forever to realize why I was getting stuck in an infinite loop. * Both 'run' and 'source' can hit the version check, so we need to be able to transition from the 'error' app to either. Which necessitates yet another global bit of state: Next_app.
| | * redo version checksKartik K. Agaram2023-12-064-22/+40
| | | | | | | | | | | | This is still ugly, but hopefully easier to follow.
| | * _yet another_ bugfix to the version check X-(Kartik K. Agaram2023-12-062-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When I stopped running the version check before the tests I also stopped initializing Version, which can be used in tests to watch out for font changes across versions. As a result I started seeing a test failure with LÖVE v12. It looks like all manual tests pass now. And we're also printing the warning about version checks before running tests, which can come in handy if a new version ever causes test failures. The only thing that makes me unhappy is the fact that we're calling the version check twice. And oh, the fact that this part around initialization and version management is clearly still immature. I'll capture some desires and fragmentary thought processes around them: * If there's an error, go to the source editor. * But oh, don't go to source editor on some unactionable errors, so we include a new `Current_app` mode for them: * Unsupported version requires an expert. Just muddle through if you can or give a warning someone can send me. * A failing test might be spurious depending on the platform and font rendering scheme. So again just provide a warning someone can send me. [Source editor can be confusing for errors. Also an editor! But not showing the file you asked for!] * But our framework clears the warning after running tests: * If someone is deep in developing a new feature and quits -> restore back in the source editor. [Perhaps `Current_app` is the wrong place for this third hacky mode, since we actually want to continue running. Perhaps it's orthogonal to `Current_app`.] [Ideally I wouldn't run the tests after the version check. I'd pause, wait for a key and then resume tests? "Muddle through" is a pain to orchestrate.] * We store `Current_app` in settings. But we don't really intend to persist a `Current_app` of 'error'. Only the main app or 'source' editor. [Another vote against storing 'error' in `Current_app`.] * So we need to rerun the version check after running tests to actually show the warning. [Perhaps I need to separate out the side-effect of setting `Version` from the side-effect of changing `Current_app`. But that's not right either, because I do still want to raise an error message if the version check fails before running tests. Which brings us back to wanting to run the tests after raising the version check..] One good thing: none of the bugs so far have been about silently ignoring test failures. I thought that might be the case for a bit, which was unnerving. I grew similar muddiness in Mu's bootstrap system over time, with several surrounding modes around the core program that interacted poorly or at least unsatisfyingly with each other. On one level it just feels like this outer layer reflects muddy constraints in the real world. But perhaps there's some skill I still need to learn here.. Why am I even displaying this error if we're going to try to muddle through anyway? In (vain) hopes that someone will send me that information. It's not terribly actionable even to me. But it's really intended for when making changes. If a test fails then, you want to know. The code would be cleaner if I just threw an unrecoverable error from the version check. Historically, the way I arrived at this solution was: * I used the default love.errorhandler for a while * I added xpcall and error recovery, but now I have situations where I would rather fall back on love.errorhandler. How to tell xpcall that? But no, this whole line of thought is wrong. LÖVE has a precedent for trying to muddle through on an unexpected version. And spurious test failures don't merit a hard crash. There's some irreducible requirement here. No point making the code simplistic when the world is complex. Perhaps I should stop caching Version and just recompute it each time. It's only used once so far, hardly seems worth the global. We have two bits of irreducible complexity here: * If tests fail it might be a real failure, or it might not. * Even if it's an unexpected version, everything might be fine. And the major remaining problem happens at the intersection of these two bits. What if we get an unexpected version with some difference that causes tests to fail? But this is a hypothetical and not worth thinking about since I'll update the app fairly quickly in response to new versions.
* | | Merge text.loveKartik K. Agaram2023-12-033-4/+8
|\| |
| * | Merge lines.loveKartik K. Agaram2023-12-033-4/+8
| |\|
| | * yet another bugfix to the version checkKartik K. Agaram2023-12-032-2/+2
| | | | | | | | | | | | | | | We could now get test failures before the version check, which might be confusing.