about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorReto Brunner <reto@labrat.space>2019-07-28 15:02:09 +0200
committerDrew DeVault <sir@cmpwn.com>2019-07-29 14:51:16 -0400
commitb812257ba97020e90e7598378b54f737364a1636 (patch)
treeef43964c6200d2a584114b56aa29f5674bc6c682
parentc81b3eb1cb8f25fb563b7d9ea99814e9ba21c737 (diff)
downloadaerc-b812257ba97020e90e7598378b54f737364a1636.tar.gz
Print errors from config load issues.
Currently we /dev/null stdout, if it is a tty.
The checkConfigPerms function, as well as the error print were incorrectly
writing to stdout and therefore weren't visible to most users.
-rw-r--r--aerc.go2
-rw-r--r--config/config.go6
2 files changed, 4 insertions, 4 deletions
diff --git a/aerc.go b/aerc.go
index 033de7b..cfd192a 100644
--- a/aerc.go
+++ b/aerc.go
@@ -135,7 +135,7 @@ func main() {
 
 	conf, err := config.LoadConfigFromFile(nil, ShareDir)
 	if err != nil {
-		fmt.Printf("Failed to load config: %v\n", err)
+		fmt.Fprintf(os.Stderr, "Failed to load config: %v\n", err)
 		os.Exit(1)
 	}
 
diff --git a/config/config.go b/config/config.go
index 356d562..8ba705c 100644
--- a/config/config.go
+++ b/config/config.go
@@ -465,9 +465,9 @@ func checkConfigPerms(filename string) error {
 	goPerms := perms >> 3
 	// group or others have read access
 	if goPerms&0x44 != 0 {
-		fmt.Printf("The file %v has too open permissions.\n", filename)
-		fmt.Println("This is a security issue (it contains passwords).")
-		fmt.Printf("To fix it, run `chmod 600 %v`\n", filename)
+		fmt.Fprintf(os.Stderr, "The file %v has too open permissions.\n", filename)
+		fmt.Fprintln(os.Stderr, "This is a security issue (it contains passwords).")
+		fmt.Fprintf(os.Stderr, "To fix it, run `chmod 600 %v`\n", filename)
 		return errors.New("account.conf permissions too lax")
 	}
 	return nil
1' href='#n161'>161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322