diff options
| author | toonn <toonn@toonn.io> | 2021-07-24 18:22:14 +0200 |
|---|---|---|
| committer | toonn <toonn@toonn.io> | 2021-07-24 18:22:14 +0200 |
| commit | 23a2b55eaa4e9b9a1f967c600480a8b2fc557867 (patch) | |
| tree | 0a90f68dd0e61c53117b11fbea7238f77503fa75 | |
| parent | cacb1b866772fd945385e52c8585e51cdf379cff (diff) | |
| download | ranger-23a2b55eaa4e9b9a1f967c600480a8b2fc557867.tar.gz | |
Actions: Add on pull_request again
My testing was flawed. The status checks seemed to work fine because the builds were triggered on push in the same repo. But this doesn't work across repos. So GH Actions having run to completion on someone's fork doesn't give us the status checks we need. Therefore we want to run our Actions on PRs too, that way they're run from the ranger repo as well and the status checks should actually be informative. One possible improvement is that we could duplicate the workflows we want to run on PRs, that way we can drop all the things that don't really matter for status checks from the version matrices. Otoh that means we have pretty much duplicated workflows we need to keep in sync. Thank you for your lack of abstractions, GH Actions 🙄
| -rw-r--r-- | .github/workflows/pylint.yml | 4 | ||||
| -rw-r--r-- | .github/workflows/python.yml | 4 | ||||
| -rw-r--r-- | .github/workflows/shellcheck.yml | 4 |
3 files changed, 12 insertions, 0 deletions
diff --git a/.github/workflows/pylint.yml b/.github/workflows/pylint.yml index 349c9af4..eac9aa5c 100644 --- a/.github/workflows/pylint.yml +++ b/.github/workflows/pylint.yml @@ -5,6 +5,10 @@ on: paths: - '.github/workflows/pylint.yml' - '**.py' + pull_request: + paths: + - '.github/workflows/pylint.yml' + - '**.py' jobs: test_pylint: diff --git a/.github/workflows/python.yml b/.github/workflows/python.yml index 82672bfb..b96d6812 100644 --- a/.github/workflows/python.yml +++ b/.github/workflows/python.yml @@ -5,6 +5,10 @@ on: paths: - '.github/workflows/python.yml' - '**.py' + pull_request: + paths: + - '.github/workflows/python.yml' + - '**.py' jobs: test_py: diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml index cd718a2d..783ff0fa 100644 --- a/.github/workflows/shellcheck.yml +++ b/.github/workflows/shellcheck.yml @@ -5,6 +5,10 @@ on: paths: - '.github/workflows/shellcheck.yml' - 'ranger/data/scope.sh' + pull_request: + paths: + - '.github/workflows/shellcheck.yml' + - 'ranger/data/scope.sh' jobs: test_shellcheck: |