| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My testing was flawed. The status checks seemed to work fine because the
builds were triggered on push in the same repo. But this doesn't work
across repos. So GH Actions having run to completion on someone's fork
doesn't give us the status checks we need. Therefore we want to run our
Actions on PRs too, that way they're run from the ranger repo as well
and the status checks should actually be informative.
One possible improvement is that we could duplicate the workflows we
want to run on PRs, that way we can drop all the things that don't
really matter for status checks from the version matrices. Otoh that
means we have pretty much duplicated workflows we need to keep in sync.
Thank you for your lack of abstractions, GH Actions 🙄
|
| | |
|
| | |
|
| |
|
|
|
|
| |
This should enable the pylint, pytest, flake8 and shellcheck lints to
run when PRs are opened and have them act as status checks so PRs aren't
merged without them passing.
|
| | |
|
| | |
|
|
|
Run our python tests and shellcheck in seperate workflows only when
relevant files are changed, respectively python files or `scope.sh`.
This tests with one extra version of python, 3.7.
GitHub's version of shellcheck seems to be missing a few flags. So we
download the latest stable version, 0.7.0 currently.
|