about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorDebXWoody <stefan@debxwoody.de>2021-05-28 21:48:43 +0200
committerDebXWoody <stefan@debxwoody.de>2021-05-28 21:48:43 +0200
commit3b020144d5a851492729b59e4e53b0f968f5222b (patch)
treefe82ba06d21986fc69ca34fd6924ff86b9f05be9
parent69e3cebf26dc5c6a9c13fe3269bcd659060d7c4e (diff)
downloadprofani-tty-3b020144d5a851492729b59e4e53b0f968f5222b.tar.gz
OMEMO: Don't encrypt to yourself (MUC)
As defined in XEP-0384 the application should not encrypt the message to own
devices. Within a groupchat, yourself are a recipients as well.

We will check the recipients and filter out the own device of the own jid.

This Pull Request will fix Issue: #1541
-rw-r--r--src/omemo/omemo.c13
1 files changed, 13 insertions, 0 deletions
diff --git a/src/omemo/omemo.c b/src/omemo/omemo.c
index b6c7585d..5e945505 100644
--- a/src/omemo/omemo.c
+++ b/src/omemo/omemo.c
@@ -791,6 +791,19 @@ omemo_on_message_send(ProfWin* win, const char* const message, gboolean request_
                 .device_id = GPOINTER_TO_INT(device_ids_iter->data)
             };
 
+            // Don't encrypt for this device (according to
+            // <https://xmpp.org/extensions/xep-0384.html#encrypt>).
+            // Yourself as recipients in case of MUC
+            Jid* me = jid_create(connection_get_fulljid());
+            if ( !g_strcmp0(me->barejid, recipients_iter->data) ) {
+                if (GPOINTER_TO_INT(device_ids_iter->data) == omemo_ctx.device_id) {
+                    jid_destroy(me);
+                    log_debug("[OMEMO][SEND] Skipping %d (my device) ", GPOINTER_TO_INT(device_ids_iter->data));
+                    continue;
+                }
+            }
+            jid_destroy(me);
+
             log_debug("[OMEMO][SEND] recipients with device id %d for %s", GPOINTER_TO_INT(device_ids_iter->data), recipients_iter->data);
             res = session_cipher_create(&cipher, omemo_ctx.store, &address, omemo_ctx.signal);
             if (res != SG_SUCCESS ) {