about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorMichael Vetter <jubalh@iodoru.org>2021-06-08 19:42:41 +0200
committerMichael Vetter <jubalh@iodoru.org>2021-06-08 19:42:41 +0200
commit6bc440c6f7e8c2c40d2d45f5c0decc15821abc8b (patch)
treea95f3c98da9d02c6cd792e246b0251990fe54580
parent8ffb1bdd37fc92c14294ad2b1d3dbc7b849249fc (diff)
downloadprofani-tty-6bc440c6f7e8c2c40d2d45f5c0decc15821abc8b.tar.gz
Use utf-8 safe functions in _mucwin_print_mention()
get_mentions() correctly counts utf-8 chars. So the positions of
mentions we get from there are correct.

But in _mucwin_print_mention() we set position equal to byte.
We need to use utf-8 safe functions here.

Regards https://github.com/profanity-im/profanity/issues/1231
-rw-r--r--src/ui/mucwin.c17
1 files changed, 12 insertions, 5 deletions
diff --git a/src/ui/mucwin.c b/src/ui/mucwin.c
index bd67b53f..54db7a38 100644
--- a/src/ui/mucwin.c
+++ b/src/ui/mucwin.c
@@ -389,7 +389,8 @@ _mucwin_print_mention(ProfWin* window, const char* const message, const char* co
     while (curr) {
         pos = GPOINTER_TO_INT(curr->data);
 
-        char* before_str = g_strndup(message + last_pos, pos - last_pos);
+        char *before_str = g_utf8_substring(message, last_pos, last_pos + pos - last_pos);
+
         if (strncmp(before_str, "/me ", 4) == 0) {
             win_print_them(window, THEME_ROOMMENTION, ch, flags, "");
             win_append_highlight(window, THEME_ROOMMENTION, "*%s ", from);
@@ -399,16 +400,22 @@ _mucwin_print_mention(ProfWin* window, const char* const message, const char* co
             win_append_highlight(window, THEME_ROOMMENTION, "%s", before_str);
         }
         g_free(before_str);
-        char* mynick_str = g_strndup(message + pos, strlen(mynick));
+
+        glong mynick_len = g_utf8_strlen(mynick, -1);
+        char* mynick_str = g_utf8_substring(message, pos, pos + mynick_len);
         win_append_highlight(window, THEME_ROOMMENTION_TERM, "%s", mynick_str);
         g_free(mynick_str);
 
-        last_pos = pos + strlen(mynick);
+        last_pos = pos + mynick_len;
 
         curr = g_slist_next(curr);
     }
-    if (last_pos < strlen(message)) {
-        win_appendln_highlight(window, THEME_ROOMMENTION, "%s", &message[last_pos]);
+
+    glong message_len = g_utf8_strlen(message, -1);
+    if (last_pos < message_len) {
+        char* rest = g_utf8_substring(message, last_pos, last_pos + message_len);
+        win_appendln_highlight(window, THEME_ROOMMENTION, "%s", rest);
+        g_free(rest);
     } else {
         win_appendln_highlight(window, THEME_ROOMMENTION, "");
     }