Copy feature strings on caps_get_features

2 files changed, 5 insertions, 3 deletions

diff --git a/src/xmpp/capabilities.c b/src/xmpp/capabilities.c
index 6310352e..da74665b 100644
--- a/src/xmpp/capabilities.c
+++ b/src/xmpp/capabilities.c
@@ -113,17 +113,19 @@ caps_get_features(void)
 
     GList *curr = prof_features;
     while (curr) {
-        result = g_list_append(result, curr->data);
+        result = g_list_append(result, strdup(curr->data));
         curr = g_list_next(curr);
     }
 
     GList *plugin_features = plugins_get_disco_features();
     curr = plugin_features;
     while (curr) {
-        result = g_list_append(result, curr->data);
+        result = g_list_append(result, strdup(curr->data));
         curr = g_list_next(curr);
     }
 
+    g_list_free(plugin_features);
+
     return result;
 }
 
diff --git a/src/xmpp/stanza.c b/src/xmpp/stanza.c
index 0853a345..c88df237 100644
--- a/src/xmpp/stanza.c
+++ b/src/xmpp/stanza.c
@@ -1096,7 +1096,7 @@ stanza_create_caps_query_element(xmpp_ctx_t *ctx)
 
         curr = g_list_next(curr);
     }
-    g_list_free(features);
+    g_list_free_full(features, free);
 
     return query;
 }