about summary refs log tree commit diff stats
path: root/RELEASE_GUIDE.md
diff options
context:
space:
mode:
authorMichael Vetter <jubalh@iodoru.org>2022-04-27 17:00:30 +0200
committerMichael Vetter <jubalh@iodoru.org>2022-04-27 17:00:30 +0200
commit2dc0cc489c872941e18a622c091f74bf5b0b043f (patch)
tree02169c1db2ce75d5090f58fe6ba99f8f72b7fa60 /RELEASE_GUIDE.md
parent196fdd9cb91e2bdb58c5cb0fad53746c32460d8c (diff)
downloadprofani-tty-2dc0cc489c872941e18a622c091f74bf5b0b043f.tar.gz
ox: dont print empty body message
Fix https://github.com/profanity-im/profanity/issues/1693

```
@StefanKropp @DebXWoody please check `_handle_ox_chat()` I don't
understand what you are doing there.
1)
First plain is assigned `message->plain =
p_ox_gpg_decrypt(xmpp_stanza_get_text(ox));`
and then in the same if block you overwrite this with `message->plain =
xmpp_stanza_get_text(b);` without freeing the old value as far as I can
see.

2)
Sometimes even doing `message->plain = "OX error: No payload found";`.
Shouldn't there be a `strdup()`? I think later on we try to free the
whole message struct. So we can't mix this static things.
```
Diffstat (limited to 'RELEASE_GUIDE.md')
0 files changed, 0 insertions, 0 deletions