about summary refs log tree commit diff stats
path: root/src/common.h
diff options
context:
space:
mode:
authorMichael Vetter <jubalh@iodoru.org>2021-06-28 17:41:48 +0200
committerMichael Vetter <jubalh@iodoru.org>2021-06-28 17:41:48 +0200
commit482f8955d7ee21515a82d1844620385ad4503079 (patch)
treeca8de66eb2bef5b81f59ae6373305a0f70cd007d /src/common.h
parenta4230603d3ae5ed52506b097a23d9f4f8a984107 (diff)
downloadprofani-tty-482f8955d7ee21515a82d1844620385ad4503079.tar.gz
Fix log rotation
See https://github.com/profanity-im/profanity/issues/1518
It has a good explanation of what happened:

```
Apparently, the _rotate_log_file function tried to extract user-provided
name from currently used mainlogfile and restart logging to the same
place after rotation, but currently this is interpreted as a full path
instead. As I understand, the log rotation is no longer done with
user-provided paths at all so this should be simply skipped altogether
now as passing any non-NULL value is interpreted as user-provided.
Replacing start with NULL appears to fix it for me.
```

In log_msg() we only rotate the log if not user_provided_log.

https://github.com/profanity-im/profanity/pull/1455 changed the
behaviour from user defined filename in the log dir to using full path.
Diffstat (limited to 'src/common.h')
0 files changed, 0 insertions, 0 deletions