Added cmd_connect tests for invalid properties

3 files changed, 42 insertions, 0 deletions

diff --git a/tests/test_cmd_connect.c b/tests/test_cmd_connect.c
index 6e3ab0b5..6b89efb3 100644
--- a/tests/test_cmd_connect.c
+++ b/tests/test_cmd_connect.c
@@ -238,6 +238,44 @@ void cmd_connect_shows_usage_when_port_provided_twice(void **state)
     free(help);
 }
 
+void cmd_connect_shows_usage_when_invalid_first_property(void **state)
+{
+    stub_ui_ask_password();
+    mock_cons_show();
+    CommandHelp *help = malloc(sizeof(CommandHelp));
+    help->usage = "some usage";
+    gchar *args[] = { "user@server.org", "wrong", "server", NULL };
+
+    mock_connection_status(JABBER_DISCONNECTED);
+
+    expect_cons_show("Usage: some usage");
+    expect_cons_show("");
+
+    gboolean result = cmd_connect(args, *help);
+    assert_true(result);
+
+    free(help);
+}
+
+void cmd_connect_shows_usage_when_invalid_second_property(void **state)
+{
+    stub_ui_ask_password();
+    mock_cons_show();
+    CommandHelp *help = malloc(sizeof(CommandHelp));
+    help->usage = "some usage";
+    gchar *args[] = { "user@server.org", "server", "aserver", "wrong", "1234", NULL };
+
+    mock_connection_status(JABBER_DISCONNECTED);
+
+    expect_cons_show("Usage: some usage");
+    expect_cons_show("");
+
+    gboolean result = cmd_connect(args, *help);
+    assert_true(result);
+
+    free(help);
+}
+
 void cmd_connect_when_no_account(void **state)
 {
     mock_cons_show();
diff --git a/tests/test_cmd_connect.h b/tests/test_cmd_connect.h
index 34770a5a..c9859b72 100644
--- a/tests/test_cmd_connect.h
+++ b/tests/test_cmd_connect.h
@@ -23,3 +23,5 @@ void cmd_connect_with_port_when_provided(void **state);
 void cmd_connect_with_server_and_port_when_provided(void **state);
 void cmd_connect_shows_usage_when_server_provided_twice(void **state);
 void cmd_connect_shows_usage_when_port_provided_twice(void **state);
+void cmd_connect_shows_usage_when_invalid_first_property(void **state);
+void cmd_connect_shows_usage_when_invalid_second_property(void **state);
diff --git a/tests/testsuite.c b/tests/testsuite.c
index 04353aa0..ade951e1 100644
--- a/tests/testsuite.c
+++ b/tests/testsuite.c
@@ -192,6 +192,8 @@ int main(int argc, char* argv[]) {
         unit_test(cmd_connect_with_server_and_port_when_provided),
         unit_test(cmd_connect_shows_usage_when_server_provided_twice),
         unit_test(cmd_connect_shows_usage_when_port_provided_twice),
+        unit_test(cmd_connect_shows_usage_when_invalid_first_property),
+        unit_test(cmd_connect_shows_usage_when_invalid_second_property),
 
         unit_test(cmd_rooms_shows_message_when_disconnected),
         unit_test(cmd_rooms_shows_message_when_disconnecting),