about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
...
* command: rename /mood clean to /mood clearMichael Vetter2022-02-013-5/+5
| | | | As per suggestion of @mdosch.
* Merge branch 'DebXWoody/usermoodimprovement1'Michael Vetter2022-01-304-16/+24
|\
| * command: adapt mood descriptionMichael Vetter2022-01-301-3/+3
| |
| * XEP-0107: User Mood - Clean moodStefan Kropp2022-01-304-14/+22
|/ | | | | | | | | | | | | | | | | | * Bugfix in mood_autocomplete (wrong parameter) * Implemented /mood clean ______________________________________ / Profanity! THE XMPP client with mood \ \ support! / -------------------------------------- \ \ .--. |o_o | |:_/ | // \ \ (| | ) /'\_ _/`\ \___)=(___/
* presence: guard against invalid inputMichael Vetter2022-01-271-3/+12
| | | | | | | | | | | | | | | | | | | | | | It shouldn't happen that we get the presence stanza without a resource. https://datatracker.ietf.org/doc/html/rfc6120 ``` Implementation Note: It is the server's responsibility to deliver only stanzas that are addressed to the client's full JID or the user's bare JID; thus, there is no need for the client to check the 'to' address of incoming stanzas. However, if the client does check the 'to' address then it is suggested to check at most the bare JID portion (not the full JID), since the 'to' address might be the user's bare JID, the client's current full JID, or even a full JID with a different resourcepart (e.g., in the case of so- called "offline messages" as described in [XEP-0160]). ``` Let's not segfault though. Close https://github.com/profanity-im/profanity/issues/1630
* ci: dont verify sslMichael Vetter2022-01-123-3/+3
|
* ci: remove building of stabberMichael Vetter2022-01-124-20/+20
| | | | | It's not run anyways. See https://github.com/profanity-im/profanity/issues/789
* ci: git clone from httpsMichael Vetter2022-01-114-7/+7
| | | | | | | | | ``` Cloning into 'stabber'... fatal: remote error: The unauthenticated git protocol on port 9418 is no longer supported. Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information. ```
* Merge pull request #1625 from JurajMlich/masterMichael Vetter2022-01-011-1/+1
|\ | | | | database.c: fix inserting messages to chat logs if archive_id is empty
| * database.c: fix inserting messages to chat logs if archive_id is emptyJuraj Mlich2021-12-311-1/+1
|/ | | | | | | | | | | The original intention of the code was that in case archive_id is not set, NULL should be inserted. What is inserted however is an empty string. This causes the condition to not insert messages with non-unique archive_id insert only one message in total and ignore all further ones (if NULL was there, the condition would work properly). And this in turn causes chat history not work properly. This commit makes the SQL condition work properly and therefore fixes chat history. Fixes #1589.
* Merge pull request #1623 from wstrm/openbsd-buildMichael Vetter2021-12-252-4/+5
|\ | | | | Upgrade to OpenBSD 7.0 in CI
| * Upgrade to OpenBSD 7.0 in CIWilliam Wennerström2021-12-242-4/+5
|/
* Merge pull request #1622 from a02c1175-5220-4e75-b7a1-18e20548305f/masterMichael Vetter2021-12-221-1/+1
|\ | | | | use wildcard for man pages in Makefile.am
| * use wildcard for man pages in Makefile.ama02c1175-5220-4e75-b7a1-18e20548305f2021-12-221-1/+1
|/
* omemo: log when no pubsubMichael Vetter2021-12-131-0/+4
| | | | Closes https://github.com/profanity-im/profanity/issues/1621
* Merge pull request #1605 from DebXWoody/xep/xep0107-user-moodMichael Vetter2021-12-0610-1/+246
|\ | | | | xep-0107: User Mood
| * Merge branch 'master' into xep/xep0107-user-moodMichael Vetter2021-12-069-28/+52
| |\ | |/ |/|
* | Merge pull request #1620 from profanity-im/readd-ciMichael Vetter2021-12-033-15/+16
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Re-Enable CI for TW, ubuntu and macos. For Arch I get: ``` Step 1/24 : FROM archlinux/latest pull access denied for archlinux/latest, repository does not exist or may require 'docker login': denied: requested access to the resource is denied ``` for both archlinux/latest and archlinux/base. Let's leave it out :-)
| * | ci: re-enable tumblweedMichael Vetter2021-12-032-2/+2
| | | | | | | | | | | | | | | | | | Old docker/libseccomp from GH got updated. This reverts commit 5c5c45321976c9a859694afa781178c68d076ee2.
| * | ci: update ubuntu python package namesMichael Vetter2021-12-031-1/+2
| | |
| * | ci: re-enable ubuntuMichael Vetter2021-12-031-1/+1
| | | | | | | | | | | | This reverts commit cc206ee8cc2cf8458325337f2e68b0dd11b95afd.
| * | ci: re-enable macosMichael Vetter2021-12-031-12/+12
|/ / | | | | | | | | They have libstrophe 0.11.0 now. This reverts commit 472a3ceec4ce4bd018d7276372cf3ccdc24b76c9.
* | Merge pull request #1610 from nandesu-utils/masterMichael Vetter2021-11-301-4/+10
|\ \ | | | | | | Fix message encryption for sender devices
| * | Refined sender device acquirementnandesu-utils2021-10-291-5/+7
| | | | | | | | | | | | | | | Now the sender devices are acknowledged only after omemo is loaded. That is, after key generation has been completed or identity has been loaded.
| * | Acquire sender's device list on connectionnandesu-utils2021-10-281-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | After generation of an identity we observe that `omemo_ctx.device_list` has an entry for sender's jid. But on application restart it is absent thus messages are not encrypted for the rest set of sender devices. This commit fixes this by applying code for acquiring the aforementioned device list after the connection.
* | | Merge pull request #1616 from trofi/masterMichael Vetter2021-11-262-3/+3
|\ \ \ | | | | | | | | gcc-12 fixes
| * | | python_api.c: enlarge `c_arguments` array to avoid OOB writeSergei Trofimovich2021-11-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Code below explicitly refers past `args_len`th element: c_arguments[args_len][0] = NULL; c_arguments[args_len][1] = NULL; Let's always allocate space for `NULL`. Noticed by Steffen Jaeckel.
| * | | src/plugins/python_api.c: drop redundant NULL pointer checkSergei Trofimovich2021-11-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gcc-12 detects redundant check against array of arrays as: src/plugins/python_api.c: In function ‘python_api_register_command’: src/plugins/python_api.c:199:31: error: the comparison will always evaluate as ‘true’ for the address of ‘c_arguments’ will never be NULL [-Werror=address] 199 | while (c_arguments[i] != NULL && c_arguments[i][0] != NULL) { | ^~ src/plugins/python_api.c:161:15: note: ‘c_arguments’ declared here 161 | char* c_arguments[args_len == 0 ? 0 : args_len + 1][2]; | ^~~~~~~~~~~
| * | | src/plugins/callbacks.c: drop redundant NULL pointer checkSergei Trofimovich2021-11-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gcc-12 detects redundant check against array of arrays as: src/plugins/callbacks.c: In function ‘_free_command_help’: src/plugins/callbacks.c:85:26: error: the comparison will always evaluate as ‘true’ for the address of ‘args’ will never be NULL [-Werror=address] 85 | while (help->args[i] != NULL && help->args[i][0] != NULL) { | ^~ In file included from ./src/ui/ui.h:44, from ./src/command/cmd_defs.h:42, from src/plugins/callbacks.c:41: ./src/command/cmd_funcs.h:48:12: note: ‘args’ declared here 48 | gchar* args[128][2]; | ^~~~
* | | | Merge pull request #1618 from profanity-im/fix/1614-otrMichael Vetter2021-11-252-2/+10
|\ \ \ \ | | | | | | | | | | Fix carbons criteria
| * | | | Fix carbons criteriaMichael Vetter2021-11-252-2/+10
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We came into the carbons checking code when we received `<private xmlns="urn:xmpp:carbons:2"/>`. Which actually marks a message to _not_ be a carbon. In this code we also make sure that carbons only come from us. If not we don't call the message handler code. So we should actually only check for `<sent xmlns='urn:xmpp:carbons:2'>` and `<received xmlns='urn:xmpp:carbons:2'>`. Thanks pukkamustard and Holger. Fixes https://github.com/profanity-im/profanity/issues/1614
* | | | Merge pull request #1617 from carlocab/osx-configureMichael Vetter2021-11-241-4/+13
|\ \ \ \ | |/ / / |/| | | Make readline check more portable
| * | | Improve macOS Readline checksCarlo Cabrera2021-11-241-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of checking for `lib` directories, let's make sure `libreadline` exists. Also, let's improve the error message if we can't find it. Finally, since we're only looking for `brew` on macOS, we don't need to use `$PATH_SEPARATOR` since we know what the path separator is.
| * | | Make readline check more portableCarlo Cabrera2021-11-231-3/+12
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, `configure.ac` assumes Readline is installed via Homebrew in `/usr/local`. This doesn't work for Homebrew on Apple Silicon, or MacPorts. Let's fix this by checking for a `brew` installation, and querying that for Readline's prefix if available. If not, it checks for an existing MacPorts prefix, and finally falls back to checking `/usr/local` in case a user installed Readline for themselves there.
| | * xep-0107: adapting the pubsub/headline codeMichael Vetter2021-12-061-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Like mentioned on the review at https://github.com/profanity-im/profanity/pull/1605 I don't ge why @DebXWoody changed the code like he did. I changed it to something that made more sense to me now. Instead of looking for headline in two places and checking for pubsub in a headline place (only). I didn't check this deeply. And still have a feeling that this is not the best way to go. But I didn't read the XEP yet. Added a TODO to the code regarding this too. A quick skimming through https://xmpp.org/extensions/xep-0107.html doesn't show me anything regarding headline. So I really don't see why this needs to go here. Hopefully @DebXWoody checks this in the future. But since he didn't react on the PR I decided to make some adjustments myself so we can merge it.
| | * xep-0107: adjust helpMichael Vetter2021-12-061-5/+5
| | |
| | * xep-0107: code reviewDebXWoody2021-12-066-33/+33
| | | | | | | | | | | | | | | | | | | | | | | | * Remarks in the Merge Request (ac_reset, help) * Defines in iq.c * Mood help and null check * Added additional information about tab key in CMD_DESC. * Added additional null check
| | * tests: add publish_user_mood stubMichael Vetter2021-12-061-0/+5
| | |
| | * Add xep-0107: User Mood supportDebXWoody2021-12-068-1/+240
| |/ |/| | | | | Implementation of XEP 0107 - User Mood
* | Cleanup _get_message_from_editor a bitMichael Vetter2021-11-011-5/+12
| | | | | | | | | | | | | | | | * Fix `src/command/cmd_funcs.c:9463:9: error: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]` * Free memory earlier and on less places * Check for succesful open() and write()
* | Merge pull request #1611 from nlfx/fix-omemo-sendfileMichael Vetter2021-11-011-1/+1
|\ \ | | | | | | Fix OMEMO /sendfile on non-glibc systems
| * | Fix OMEMO /sendfile on non-glibc systemsnlfx2021-11-011-1/+1
|/ /
* | Merge pull request #1608 from sjaeckel/deprecate-libmesodeMichael Vetter2021-10-2825-199/+54
|\ \ | |/ |/| Deprecate libmesode
| * ci: disable osx until they updated libstropheMichael Vetter2021-10-281-12/+12
| |
| * ci: switch from libmesode to libstropheMichael Vetter2021-10-285-12/+11
| |
| * bump libstrophe requirement to 0.11.0Michael Vetter2021-10-281-1/+1
| |
| * auto-formatSteffen Jaeckel2021-10-272-3/+2
| | | | | | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * use new libstrophe APISteffen Jaeckel2021-10-272-45/+23
| | | | | | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * ran `autoupdate`Steffen Jaeckel2021-10-271-2/+2
| | | | | | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
| * first step to remove libmesodeSteffen Jaeckel2021-10-2717-125/+4
|/ | | | Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-10-31 07:17:50 +0000