about summary refs log tree commit diff stats
path: root/tests/unittests/test_roster_list.c
blob: fc10d1a740901351d0b690f6e27ef5df099e1b1b (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
//: The goal of this skeleton is to make programs more easy to understand and
//: more malleable, easy to rewrite in radical ways without accidentally
//: breaking some corner case. Tests further both goals. They help
//: understandability by letting one make small changes and get feedback. What
//: if I wrote this line like so? What if I removed this function call, is it
//: really necessary? Just try it, see if the tests pass. Want to explore
//: rewriting this bit in this way? Tests put many refactorings on a firmer
//: footing.
//:
//: But the usual way we write tests seems incomplete. Refactorings tend to
//: work in the small, but don't help with changes to function boundaries. If
//: you want to extract a new function you have to manually test-drive it to
//: create tests for it. If you want to inline a function its tests are no
//: longer valid. In both cases you end up having to reorganize code as well as
//: tests, an error-prone activity.
//:
//: This file tries to fix this problem by supporting domain-driven testing
//: We try to focus on the domain of inputs the program should work on. All
//: tests invoke the program in a single way: by calling run() with different
//: inputs. The program operates on the input and logs _facts_ it deduces to a
//: trace:
//:   trace("label") << "fact 1: " << val;
//:
//: The tests check for facts:
//:   :(scenario foo)
//:   34  # call run() with this input
//:   +label: fact 1: 34  # trace should have logged this at the end
//:   -label: fact 1: 35  # trace should never contain such a line
//:
//: Since we never call anything but the run() function directly, we never have
//: to rewrite the tests when we reorganize the internals of the program. We
//: just have to make sure our rewrite deduces the same facts about the domain,
//: and that's something we're going to have to do anyway.
//:
//: To avoid the combinatorial explosion of integration tests, we organize the
//: program into different layers, and each fact is logged to the trace with a
//: specific label. Individual tests can focus on specific labels. In essence,
//: validating the facts logged with a specific label is identical to calling
//: some internal subsystem.
//:
//: Traces interact salubriously with layers. Thanks to our ordering
//: directives, each layer can contain its own tests. They may rely on other
//: layers, but when a test fails its usually due to breakage in the same
//: layer. When multiple tests fail, it's usually useful to debug the very
//: first test to fail. This is in contrast with the traditional approach,
//: where changes can cause breakages in faraway subsystems, and picking the
//: right test to debug can be an important skill to pick up.
//:
//: To build robust tests, trace facts about your domain rather than details of
//: how you computed them.
//:
//: More details: http://akkartik.name/blog/tracing-tests
//:
//: ---
//:
//: Between layers and domain-driven testing, programming starts to look like a
//: fundamentally different activity. Instead of a) superficial, b) local rules
//: on c) code [like http://blog.bbv.ch/2013/06/05/clean-code-cheat-sheet],
//: we allow programmers to engage with the a) deep, b) global structure of the
//: c) domain. If you can systematically track discontinuities in the domain
//: you don't care if the code used gotos as long as it passed the tests. If
//: tests become more robust to run it becomes easier to try out radically
//: different implementations for the same program. If code is super-easy to
//: rewrite, it becomes less important what indentation style it uses, or that
//: the objects are appropriately encapsulated, or that the functions are
//: referentially transparent.
//:
//: Instead of plumbing, programming becomes building and gradually refining a
//: map of the environment the program must operate under. Whether a program is
//: 'correct' at a given point in time is a red herring; what matters is
//: avoiding regression by monotonically nailing down the more 'eventful' parts
//: of the terrain. It helps readers new and old and rewards curiosity to
//: organize large programs in self-similar hiearchies of example scenarios
//: colocated with the code that makes them work.
//:
//:   "Programming properly should be regarded as an activity by which
//:   programmers form a mental model, rather than as production of a program."
//:   -- Peter Naur (http://alistair.cockburn.us/ASD+book+extract%3A+%22Naur,+Ehn,+Musashi%22)

:(before "int main")
// End Tracing  // hack to ensure most code in this layer comes before anything else

:(before "End Tracing
#include <glib.h>
#include <stdarg.h>
#include <string.h>
#include <stddef.h>
#include <setjmp.h>
#include <cmocka.h>
#include <stdlib.h>

#include "xmpp/contact.h"
#include "xmpp/roster_list.h"

void
empty_list_when_none_added(void** state)
{
    roster_create();
    GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
    assert_null(list);

    g_slist_free(list);
    roster_destroy();
}

void
contains_one_element(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
    assert_int_equal(1, g_slist_length(list));

    g_slist_free(list);
    roster_destroy();
}

void
first_element_correct(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
    PContact james = list->data;

    assert_string_equal("James", p_contact_barejid(james));

    g_slist_free(list);
    roster_destroy();
}

void
contains_two_elements(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("Dave", NULL, NULL, NULL, FALSE);
    GSList* list = roster_get_contacts(ROSTER_ORD_NAME);

    assert_int_equal(2, g_slist_length(list));

    g_slist_free(list);
    roster_destroy();
}

void
first_and_second_elements_correct(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("Dave", NULL, NULL, NULL, FALSE);
    GSList* list = roster_get_contacts(ROSTER_ORD_NAME);

    PContact first = list->data;
    PContact second = (g_slist_next(list))->data;

    assert_string_equal("Dave", p_contact_barejid(first));
    assert_string_equal("James", p_contact_barejid(second));

    g_slist_free(list);
    roster_destroy();
}

void
contains_three_elements(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("Bob", NULL, NULL, NULL, FALSE);
    roster_add("Dave", NULL, NULL, NULL, FALSE);
    GSList* list = roster_get_contacts(ROSTER_ORD_NAME);

    assert_int_equal(3, g_slist_length(list));

    g_slist_free(list);
    roster_destroy();
}

void
first_three_elements_correct(void** state)
{
    roster_create();
    roster_add("Bob", NULL, NULL, NULL, FALSE);
    roster_add("Dave", NULL, NULL, NULL, FALSE);
    roster_add("James", NULL, NULL, NULL, FALSE);
    GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
    PContact bob = list->data;
    PContact dave = (g_slist_next(list))->data;
    PContact james = (g_slist_next(g_slist_next(list)))->data;

    assert_string_equal("James", p_contact_barejid(james));
    assert_string_equal("Dave", p_contact_barejid(dave));
    assert_string_equal("Bob", p_contact_barejid(bob));

    g_slist_free(list);
    roster_destroy();
}

void
add_twice_at_beginning_adds_once(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("Dave", NULL, NULL, NULL, FALSE);
    roster_add("Bob", NULL, NULL, NULL, FALSE);
    GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
    PContact first = list->data;
    PContact second = (g_slist_next(list))->data;
    PContact third = (g_slist_next(g_slist_next(list)))->data;

    assert_int_equal(3, g_slist_length(list));
    assert_string_equal("Bob", p_contact_barejid(first));
    assert_string_equal("Dave", p_contact_barejid(second));
    assert_string_equal("James", p_contact_barejid(third));

    g_slist_free(list);
    roster_destroy();
}

void
add_twice_in_middle_adds_once(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("Dave", NULL, NULL, NULL, FALSE);
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("Bob", NULL, NULL, NULL, FALSE);
    GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
    PContact first = list->data;
    PContact second = (g_slist_next(list))->data;
    PContact third = (g_slist_next(g_slist_next(list)))->data;

    assert_int_equal(3, g_slist_length(list));
    assert_string_equal("Bob", p_contact_barejid(first));
    assert_string_equal("Dave", p_contact_barejid(second));
    assert_string_equal("James", p_contact_barejid(third));

    g_slist_free(list);
    roster_destroy();
}

void
add_twice_at_end_adds_once(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("Dave", NULL, NULL, NULL, FALSE);
    roster_add("Bob", NULL, NULL, NULL, FALSE);
    roster_add("James", NULL, NULL, NULL, FALSE);
    GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
    PContact first = list->data;
    PContact second = (g_slist_next(list))->data;
    PContact third = (g_slist_next(g_slist_next(list)))->data;

    assert_int_equal(3, g_slist_length(list));
    assert_string_equal("Bob", p_contact_barejid(first));
    assert_string_equal("Dave", p_contact_barejid(second));
    assert_string_equal("James", p_contact_barejid(third));

    g_slist_free(list);
    roster_destroy();
}

void
find_first_exists(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("Dave", NULL, NULL, NULL, FALSE);
    roster_add("Bob", NULL, NULL, NULL, FALSE);

    char* search = strdup("B");

    char* result = roster_contact_autocomplete(search, FALSE, NULL);
    assert_string_equal("Bob", result);
    free(result);
    free(search);
    roster_destroy();
}

void
find_second_exists(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("Dave", NULL, NULL, NULL, FALSE);
    roster_add("Bob", NULL, NULL, NULL, FALSE);

    char* result = roster_contact_autocomplete("Dav", FALSE, NULL);
    assert_string_equal("Dave", result);
    free(result);
    roster_destroy();
}

void
find_third_exists(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("Dave", NULL, NULL, NULL, FALSE);
    roster_add("Bob", NULL, NULL, NULL, FALSE);

    char* result = roster_contact_autocomplete("Ja", FALSE, NULL);
    assert_string_equal("James", result);
    free(result);
    roster_destroy();
}

void
find_returns_null(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("Dave", NULL, NULL, NULL, FALSE);
    roster_add("Bob", NULL, NULL, NULL, FALSE);

    char* result = roster_contact_autocomplete("Mike", FALSE, NULL);
    assert_null(result);
    roster_destroy();
}

void
find_on_empty_returns_null(void** state)
{
    roster_create();
    char* result = roster_contact_autocomplete("James", FALSE, NULL);
    assert_null(result);
    roster_destroy();
}

void
find_twice_returns_second_when_two_match(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("Jamie", NULL, NULL, NULL, FALSE);
    roster_add("Bob", NULL, NULL, NULL, FALSE);

    char* result1 = roster_contact_autocomplete("Jam", FALSE, NULL);
    char* result2 = roster_contact_autocomplete(result1, FALSE, NULL);
    assert_string_equal("Jamie", result2);
    free(result1);
    free(result2);
    roster_destroy();
}

void
find_five_times_finds_fifth(void** state)
{
    roster_create();
    roster_add("Jama", NULL, NULL, NULL, FALSE);
    roster_add("Jamb", NULL, NULL, NULL, FALSE);
    roster_add("Mike", NULL, NULL, NULL, FALSE);
    roster_add("Dave", NULL, NULL, NULL, FALSE);
    roster_add("Jamm", NULL, NULL, NULL, FALSE);
    roster_add("Jamn", NULL, NULL, NULL, FALSE);
    roster_add("Matt", NULL, NULL, NULL, FALSE);
    roster_add("Jamo", NULL, NULL, NULL, FALSE);
    roster_add("Jamy", NULL, NULL, NULL, FALSE);
    roster_add("Jamz", NULL, NULL, NULL, FALSE);

    char* result1 = roster_contact_autocomplete("Jam", FALSE, NULL);
    char* result2 = roster_contact_autocomplete(result1, FALSE, NULL);
    char* result3 = roster_contact_autocomplete(result2, FALSE, NULL);
    char* result4 = roster_contact_autocomplete(result3, FALSE, NULL);
    char* result5 = roster_contact_autocomplete(result4, FALSE, NULL);
    assert_string_equal("Jamo", result5);
    free(result1);
    free(result2);
    free(result3);
    free(result4);
    free(result5);
    roster_destroy();
}

void
find_twice_returns_first_when_two_match_and_reset(void** state)
{
    roster_create();
    roster_add("James", NULL, NULL, NULL, FALSE);
    roster_add("Jamie", NULL, NULL, NULL, FALSE);
    roster_add("Bob", NULL, NULL, NULL, FALSE);

    char* result1 = roster_contact_autocomplete("Jam", FALSE, NULL);
    roster_reset_search_attempts();
    char* result2 = roster_contact_autocomplete(result1, FALSE, NULL);
    assert_string_equal("James", result2);
    free(result1);
    free(result2);
    roster_destroy();
}

void
add_contact_with_no_group(void** state)
{
    roster_create();
    roster_add("person@server.org", NULL, NULL, NULL, FALSE);

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 0);

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
add_contact_with_group(void** state)
{
    roster_create();

    GSList* groups = NULL;
    groups = g_slist_append(groups, strdup("friends"));
    roster_add("person@server.org", NULL, groups, NULL, FALSE);

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 1);

    GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "friends");

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
add_contact_with_two_groups(void** state)
{
    roster_create();

    GSList* groups = NULL;
    groups = g_slist_append(groups, strdup("friends"));
    groups = g_slist_append(groups, strdup("work"));
    roster_add("person@server.org", NULL, groups, NULL, FALSE);

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 2);

    GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "friends");
    found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "work");

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
add_contact_with_three_groups(void** state)
{
    roster_create();

    GSList* groups = NULL;
    groups = g_slist_append(groups, strdup("friends"));
    groups = g_slist_append(groups, strdup("work"));
    groups = g_slist_append(groups, strdup("stuff"));
    roster_add("person@server.org", NULL, groups, NULL, FALSE);

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 3);

    GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "friends");
    found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "work");
    found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "stuff");

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
add_contact_with_three_groups_update_adding_two(void** state)
{
    roster_create();

    GSList* groups1 = NULL;
    groups1 = g_slist_append(groups1, strdup("friends"));
    groups1 = g_slist_append(groups1, strdup("work"));
    groups1 = g_slist_append(groups1, strdup("stuff"));
    roster_add("person@server.org", NULL, groups1, NULL, FALSE);

    GSList* groups2 = NULL;
    groups2 = g_slist_append(groups2, strdup("friends"));
    groups2 = g_slist_append(groups2, strdup("work"));
    groups2 = g_slist_append(groups2, strdup("stuff"));
    groups2 = g_slist_append(groups2, strdup("things"));
    groups2 = g_slist_append(groups2, strdup("people"));
    roster_update("person@server.org", NULL, groups2, NULL, FALSE);

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 5);

    GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "friends");
    found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "work");
    found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "stuff");
    found = g_list_find_custom(groups_res, "things", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "things");
    found = g_list_find_custom(groups_res, "people", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "people");

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
add_contact_with_three_groups_update_removing_one(void** state)
{
    roster_create();

    GSList* groups1 = NULL;
    groups1 = g_slist_append(groups1, strdup("friends"));
    groups1 = g_slist_append(groups1, strdup("work"));
    groups1 = g_slist_append(groups1, strdup("stuff"));
    roster_add("person@server.org", NULL, groups1, NULL, FALSE);

    GSList* groups2 = NULL;
    groups2 = g_slist_append(groups2, strdup("friends"));
    groups2 = g_slist_append(groups2, strdup("stuff"));
    roster_update("person@server.org", NULL, groups2, NULL, FALSE);

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 2);

    GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "friends");
    found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "stuff");

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
add_contact_with_three_groups_update_removing_two(void** state)
{
    roster_create();

    GSList* groups1 = NULL;
    groups1 = g_slist_append(groups1, strdup("friends"));
    groups1 = g_slist_append(groups1, strdup("work"));
    groups1 = g_slist_append(groups1, strdup("stuff"));
    roster_add("person@server.org", NULL, groups1, NULL, FALSE);

    GSList* groups2 = NULL;
    groups2 = g_slist_append(groups2, strdup("stuff"));
    roster_update("person@server.org", NULL, groups2, NULL, FALSE);

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 1);

    GList* found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    assert_string_equal(found->data, "stuff");

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
add_contact_with_three_groups_update_removing_three(void** state)
{
    roster_create();

    GSList* groups1 = NULL;
    groups1 = g_slist_append(groups1, strdup("friends"));
    groups1 = g_slist_append(groups1, strdup("work"));
    groups1 = g_slist_append(groups1, strdup("stuff"));
    roster_add("person@server.org", NULL, groups1, NULL, FALSE);

    roster_update("person@server.org", NULL, NULL, NULL, FALSE);

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 0);

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
add_contact_with_three_groups_update_two_new(void** state)
{
    roster_create();

    GSList* groups1 = NULL;
    groups1 = g_slist_append(groups1, strdup("friends"));
    groups1 = g_slist_append(groups1, strdup("work"));
    groups1 = g_slist_append(groups1, strdup("stuff"));
    roster_add("person@server.org", NULL, groups1, NULL, FALSE);

    GSList* groups2 = NULL;
    groups2 = g_slist_append(groups2, strdup("newfriends"));
    groups2 = g_slist_append(groups2, strdup("somepeople"));
    roster_update("person@server.org", NULL, groups2, NULL, FALSE);

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 2);

    GList* found = g_list_find_custom(groups_res, "newfriends", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    found = g_list_find_custom(groups_res, "somepeople", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
add_remove_contact_groups(void** state)
{
    roster_create();

    GSList* groups1 = NULL;
    groups1 = g_slist_append(groups1, strdup("friends"));
    groups1 = g_slist_append(groups1, strdup("work"));
    groups1 = g_slist_append(groups1, strdup("stuff"));
    roster_add("person@server.org", NULL, groups1, NULL, FALSE);

    roster_remove("person@server.org", "person@server.org");

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 0);

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
add_contacts_with_different_groups(void** state)
{
    roster_create();

    GSList* groups1 = NULL;
    groups1 = g_slist_append(groups1, strdup("friends"));
    groups1 = g_slist_append(groups1, strdup("work"));
    groups1 = g_slist_append(groups1, strdup("stuff"));
    roster_add("person@server.org", NULL, groups1, NULL, FALSE);

    GSList* groups2 = NULL;
    groups2 = g_slist_append(groups2, strdup("newfriends"));
    groups2 = g_slist_append(groups2, strdup("somepeople"));
    roster_add("bob@server.org", NULL, groups2, NULL, FALSE);

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 5);

    GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    found = g_list_find_custom(groups_res, "newfriends", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    found = g_list_find_custom(groups_res, "somepeople", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
add_contacts_with_same_groups(void** state)
{
    roster_create();

    GSList* groups1 = NULL;
    groups1 = g_slist_append(groups1, strdup("friends"));
    groups1 = g_slist_append(groups1, strdup("work"));
    groups1 = g_slist_append(groups1, strdup("stuff"));
    roster_add("person@server.org", NULL, groups1, NULL, FALSE);

    GSList* groups2 = NULL;
    groups2 = g_slist_append(groups2, strdup("friends"));
    groups2 = g_slist_append(groups2, strdup("work"));
    groups2 = g_slist_append(groups2, strdup("stuff"));
    roster_add("bob@server.org", NULL, groups2, NULL, FALSE);

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 3);

    GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
add_contacts_with_overlapping_groups(void** state)
{
    roster_create();

    GSList* groups1 = NULL;
    groups1 = g_slist_append(groups1, strdup("friends"));
    groups1 = g_slist_append(groups1, strdup("work"));
    groups1 = g_slist_append(groups1, strdup("stuff"));
    roster_add("person@server.org", NULL, groups1, NULL, FALSE);

    GSList* groups2 = NULL;
    groups2 = g_slist_append(groups2, strdup("friends"));
    groups2 = g_slist_append(groups2, strdup("work"));
    groups2 = g_slist_append(groups2, strdup("different"));
    roster_add("bob@server.org", NULL, groups2, NULL, FALSE);

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 4);

    GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    found = g_list_find_custom(groups_res, "different", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
remove_contact_with_remaining_in_group(void** state)
{
    roster_create();

    GSList* groups1 = NULL;
    groups1 = g_slist_append(groups1, strdup("friends"));
    groups1 = g_slist_append(groups1, strdup("work"));
    groups1 = g_slist_append(groups1, strdup("stuff"));
    roster_add("person@server.org", NULL, groups1, NULL, FALSE);

    GSList* groups2 = NULL;
    groups2 = g_slist_append(groups2, strdup("friends"));
    groups2 = g_slist_append(groups2, strdup("work"));
    groups2 = g_slist_append(groups2, strdup("different"));
    roster_add("bob@server.org", NULL, groups2, NULL, FALSE);

    roster_remove("bob@server.org", "bob@server.org");

    GList* groups_res = roster_get_groups();
    assert_int_equal(g_list_length(groups_res), 3);

    GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);
    found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
    assert_true(found != NULL);

    g_list_free_full(groups_res, free);
    roster_destroy();
}

void
get_contact_display_name(void** state)
{
    roster_create();
    roster_add("person@server.org", "nickname", NULL, NULL, FALSE);

    assert_string_equal("nickname", roster_get_display_name("person@server.org"));

    roster_destroy();
}

void
get_contact_display_name_is_barejid_if_name_is_empty(void** state)
{
    roster_create();
    roster_add("person@server.org", NULL, NULL, NULL, FALSE);

    assert_string_equal("person@server.org", roster_get_display_name("person@server.org"));

    roster_destroy();
}

void
get_contact_display_name_is_passed_barejid_if_contact_does_not_exist(void** state)
{
    roster_create();

    assert_string_equal("person@server.org", roster_get_display_name("person@server.org"));

    roster_destroy();
}